Skip to content

[REVIEW] fix mg_renumber non-deterministic errors#1523

Merged
rapids-bot[bot] merged 24 commits intorapidsai:branch-0.19from
Iroy30:mg_renumber_fixes
Apr 9, 2021
Merged

[REVIEW] fix mg_renumber non-deterministic errors#1523
rapids-bot[bot] merged 24 commits intorapidsai:branch-0.19from
Iroy30:mg_renumber_fixes

Conversation

@Iroy30
Copy link
Contributor

@Iroy30 Iroy30 commented Apr 8, 2021

  • @Iroy30 added missing dask persist() call to ensure deterministic indirection map state prior to merging renumbering results.
  • @rlratzel updated MG renumbering test for latest API changes, removed redundant test, and updated test IDs to include the dataset name.

@Iroy30 Iroy30 requested a review from a team as a code owner April 8, 2021 18:49
@rlratzel rlratzel added bug Something isn't working non-breaking Non-breaking change labels Apr 8, 2021
@BradReesWork BradReesWork added this to the 0.19 milestone Apr 8, 2021
@BradReesWork
Copy link
Member

@gpucibot merge

@BradReesWork
Copy link
Member

rerun tests

Copy link
Contributor

@jnke2016 jnke2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looks good to me. No comments to add

@rapids-bot rapids-bot bot merged commit e9d09ee into rapidsai:branch-0.19 Apr 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants