[50] bug convert to clocktime with wrong response when more than 1 day (#51)

* [50] Bump gemfile with Ruby 3.4.2

* [50] Adjust converter to clocktime method to handle results bigger than 1 day

* [50] Change Ruby version to 3.4.2

* [50] Update Readme to 1.5.2 version

* [50] Remove unused require of bigdecimal

* [50] Rubocop lint

* [50] Update gemspec to version 1.5.2

Author: 0jonjo

.ruby-version

@@ -1 +1 @@
-3.2.1
+3.4.2

Gemfile

@@ -2,7 +2,7 @@
 
 source 'https://rubygems.org'
 
-ruby '3.2.1'
+ruby '3.4.2'
 
 gem 'minitest', '~> 5.25'
 gem 'rake', '~> 13.2'

Gemfile.lock

@@ -3,39 +3,41 @@ GEM
   specs:
     ast (2.4.2)
     date (3.4.1)
-    json (2.9.1)
-    language_server-protocol (3.17.0.3)
+    json (2.10.1)
+    language_server-protocol (3.17.0.4)
+    lint_roller (1.1.0)
     minitest (5.25.4)
     parallel (1.26.3)
-    parser (3.3.6.0)
+    parser (3.3.7.1)
       ast (~> 2.4.1)
       racc
-    psych (5.2.2)
+    psych (5.2.3)
       date
       stringio
     racc (1.8.1)
     rainbow (3.1.1)
     rake (13.2.1)
     rake-compiler (1.2.9)
       rake
-    rdoc (6.10.0)
+    rdoc (6.12.0)
       psych (>= 4.0.0)
     regexp_parser (2.10.0)
-    rubocop (1.69.2)
+    rubocop (1.73.2)
       json (~> 2.3)
-      language_server-protocol (>= 3.17.0)
+      language_server-protocol (~> 3.17.0.2)
+      lint_roller (~> 1.1.0)
       parallel (~> 1.10)
       parser (>= 3.3.0.2)
       rainbow (>= 2.2.2, < 4.0)
       regexp_parser (>= 2.9.3, < 3.0)
-      rubocop-ast (>= 1.36.2, < 2.0)
+      rubocop-ast (>= 1.38.0, < 2.0)
       ruby-progressbar (~> 1.7)
       unicode-display_width (>= 2.4.0, < 4.0)
-    rubocop-ast (1.37.0)
+    rubocop-ast (1.38.1)
       parser (>= 3.3.1.0)
     ruby-progressbar (1.13.0)
-    stringio (3.1.2)
-    unicode-display_width (3.1.3)
+    stringio (3.1.5)
+    unicode-display_width (3.1.4)
       unicode-emoji (~> 4.0, >= 4.0.4)
     unicode-emoji (4.0.4)
 
@@ -50,7 +52,7 @@ DEPENDENCIES
   rubocop (~> 1.69)
 
 RUBY VERSION
-   ruby 3.2.1p31
+   ruby 3.4.2p28
 
 BUNDLED WITH
    2.5.10

README.md

@@ -1,4 +1,4 @@
-# Calcpace [![Gem Version](https://d25lcipzij17d.cloudfront.net/badge.svg?id=rb&r=r&ts=1683906897&type=6e&v=1.5.1&x2=0)](https://badge.fury.io/rb/calcpace)
+# Calcpace [![Gem Version](https://d25lcipzij17d.cloudfront.net/badge.svg?id=rb&r=r&ts=1683906897&type=6e&v=1.5.2&x2=0)](https://badge.fury.io/rb/calcpace)
 
 Calcpace is a Ruby gem designed for calculations and conversions related to distance and time. It can calculate velocity, pace, total time, and distance, accepting time in various formats, including HH:MM:SS. The gem supports conversion to 42 different units, including kilometers, miles, meters, and feet. It also provides methods to validate input.
 
@@ -7,7 +7,7 @@ Calcpace is a Ruby gem designed for calculations and conversions related to dist
 ### Add to your Gemfile
 
 ```ruby
-gem 'calcpace', '~> 1.5.1'
+gem 'calcpace', '~> 1.5.2'
 ```
 
 Then run:
@@ -134,6 +134,7 @@ Calcpace also provides other useful methods:
 converter = Calcpace.new
 converter.convert_to_seconds('01:00:00') # => 3600
 converter.convert_to_clocktime(3600) # => '01:00:00'
+converter.converto_to_clocktime(100000) # => '1 03:46:40'
 converter.check_time('01:00:00') # => nil
 ```
 

calcpace.gemspec

@@ -2,7 +2,7 @@
 
 Gem::Specification.new do |s|
   s.name        = 'calcpace'
-  s.version     = '1.5.1'
+  s.version     = '1.5.2'
   s.summary     = 'Calcpace: calculate total, distance, speed, and convert distances and velocity in an easy way.'
   s.description = 'It is designed for calculations related to distance, speed and time. The gem also supports conversion to 42 different units of distance and velocity, including metric, nautical and imperial units.'
   s.authors     = ['Joao Gilberto Saraiva']

lib/calcpace/converter.rb

@@ -62,8 +62,9 @@ def convert_to_seconds(time)
   end
 
   def convert_to_clocktime(seconds)
-    format = seconds >= 86_400 ? '%d %H:%M:%S' : '%H:%M:%S'
-    Time.at(seconds.to_i).utc.strftime(format)
+    days = seconds / 86_400
+    format = days.to_i.positive? ? "#{days} %H:%M:%S" : '%H:%M:%S'
+    Time.at(seconds).utc.strftime(format)
   end
 
   def constant(symbol)

test/calcpace/test_calculator.rb

@@ -1,7 +1,6 @@
 # frozen_string_literal: true
 
 require 'minitest/autorun'
-require 'bigdecimal'
 require_relative '../../lib/calcpace'
 
 class TestCalculator < Minitest::Test

test/calcpace/test_converter.rb

@@ -16,6 +16,10 @@ def test_convert_to_clocktime
     assert_equal '01:11:02', @checker.convert_to_clocktime(4262)
   end
 
+  def test_convert_to_clocktime_more_than_24_hours
+    assert_equal '1 03:46:40', @checker.convert_to_clocktime(100_000)
+  end
+
   def test_convert_distance_one
     assert_equal 0.621371, @checker.convert(1, :km_to_mi)
     assert_equal 1.60934, @checker.convert(1, :mi_to_km)