Skip to content

Commit 4db169c

Browse files
committed
[go/fixchain] updated x509 lib doesn't verify roots
The Go 1.8 library doesn't verify root certificates that have been explicitly included in the roots pool. golang/go@8ad70a5
1 parent 527739b commit 4db169c

File tree

1 file changed

+2
-5
lines changed

1 file changed

+2
-5
lines changed

go/fixchain/fix_and_log_test.go

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -82,18 +82,15 @@ var newFixAndLogTests = []fixAndLogTest{
8282
},
8383
// Tests that add chains to the FixAndLog using QueueAllCertsInChain()
8484
{ // Full chain successfully logged.
85-
// Note: Verifying a root to itself results in an error.
86-
// This is not an issue as the root will already be known to the log, and chains
87-
// aren't required to contain the root.
8885
url: "https://ct.googleapis.com/pilot",
8986
chain: []string{googleLeaf, thawteIntermediate, verisignRoot},
9087

9188
function: "QueueAllCertsInChain",
9289
expLoggedChains: [][]string{
9390
{"Google", "Thawte", "VeriSign"},
9491
{"Thawte", "VeriSign"},
92+
{"VeriSign"},
9593
},
96-
expectedErrs: []errorType{VerifyFailed, FixFailed},
9794
},
9895
{
9996
url: "https://ct.googleapis.com/pilot",
@@ -155,10 +152,10 @@ var newFixAndLogTests = []fixAndLogTest{
155152
expLoggedChains: [][]string{
156153
{"Google", "Thawte", "VeriSign"},
157154
{"Thawte", "VeriSign"},
155+
{"VeriSign"},
158156
},
159157
expectedErrs: []errorType{
160158
VerifyFailed, FixFailed,
161-
VerifyFailed, FixFailed,
162159
},
163160
},
164161
{ // Garbled chain (with a leaf that has a chain to our roots)

0 commit comments

Comments
 (0)