File tree Expand file tree Collapse file tree 1 file changed +6
-0
lines changed
Expand file tree Collapse file tree 1 file changed +6
-0
lines changed Original file line number Diff line number Diff line change @@ -39,6 +39,10 @@ const char kNodeId3[] = "node3";
3939
4040class ClusterStateControllerTest : public ::testing::Test {
4141 public:
42+ // TODO: Some of the tests in this class rely on sleep() calls.
43+ // Ideally they should be waiting for defined conditions to avoid timing
44+ // races.
45+
4246 // TODO(pphaneuf): The size of the thread pool is a bit of a magic
4347 // number... We have some callbacks that block, so it has to be "at
4448 // least this" (so we're setting it explicitly, in case your machine
@@ -99,6 +103,8 @@ class ClusterStateControllerTest : public ::testing::Test {
99103 return controller_.local_node_state_ ;
100104 }
101105
106+ // TODO: This should probably return a util::StatusOr<ClusterNodeState>
107+ // rather than failing a CHECK if absent.
102108 ct::ClusterNodeState GetNodeStateView (const string& node_id) {
103109 auto it (controller_.all_peers_ .find (" /nodes/" + node_id));
104110 CHECK (it != controller_.all_peers_ .end ());
You can’t perform that action at this time.
0 commit comments