Skip to content

Commit b1d0f3d

Browse files
committed
Added some TODOs.
1 parent 94e2790 commit b1d0f3d

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed

cpp/log/cluster_state_controller_test.cc

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,10 @@ const char kNodeId3[] = "node3";
3939

4040
class ClusterStateControllerTest : public ::testing::Test {
4141
public:
42+
// TODO: Some of the tests in this class rely on sleep() calls.
43+
// Ideally they should be waiting for defined conditions to avoid timing
44+
// races.
45+
4246
// TODO(pphaneuf): The size of the thread pool is a bit of a magic
4347
// number... We have some callbacks that block, so it has to be "at
4448
// least this" (so we're setting it explicitly, in case your machine
@@ -99,6 +103,8 @@ class ClusterStateControllerTest : public ::testing::Test {
99103
return controller_.local_node_state_;
100104
}
101105

106+
// TODO: This should probably return a util::StatusOr<ClusterNodeState>
107+
// rather than failing a CHECK if absent.
102108
ct::ClusterNodeState GetNodeStateView(const string& node_id) {
103109
auto it(controller_.all_peers_.find("/nodes/" + node_id));
104110
CHECK(it != controller_.all_peers_.end());

0 commit comments

Comments
 (0)