Skip to content

Commit bb550ab

Browse files
committed
Remove a variable that is only written to.
1 parent 8b5d114 commit bb550ab

File tree

1 file changed

+1
-3
lines changed

1 file changed

+1
-3
lines changed

cpp/util/masterelection.cc

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -502,7 +502,7 @@ void MasterElection::OnProposalUpdate(
502502

503503
// Check to see whether the apparent master from the previous stage is backed
504504
// by all participating nodes:
505-
bool found_master(!proposals_.empty());
505+
CHECK(!proposals_.empty());
506506
// Check if everyone is in agreement about who the master is:
507507
for (const auto& pair : proposals_) {
508508
// Discount any participant who has explicitly abstained from the vote.
@@ -526,7 +526,6 @@ void MasterElection::OnProposalUpdate(
526526
VLOG(1) << my_proposal_path_ << ": Apparent master is "
527527
<< apparent_master.key_ << " but " << pair.first
528528
<< " is backing: " << pair.second.value_;
529-
found_master = false;
530529
// No master, so we can't be master
531530
is_master_ = false;
532531
is_master_gauge->Set(0);
@@ -535,7 +534,6 @@ void MasterElection::OnProposalUpdate(
535534
}
536535

537536
// There must be consensus about who the master is now.
538-
CHECK(found_master);
539537
VLOG(2) << my_proposal_path_ << ": Agreed that master is "
540538
<< apparent_master.key_;
541539
current_master_ = apparent_master;

0 commit comments

Comments
 (0)