Skip to content

Commit f9f8008

Browse files
authored
Temporary workaround for issue with gclient and DEPS (google#1409)
* Temporary workaround for issue with gclient and DEPS For the moment just build with openssl until a proper fix can be developed. * Update DEPS to remove icu4c We believe that this dep is currently not used and can be removed to help fix build issues. * Remove icu4c from configure.ac
1 parent 66796fe commit f9f8008

File tree

2 files changed

+7
-17
lines changed

2 files changed

+7
-17
lines changed

DEPS

Lines changed: 7 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -11,12 +11,11 @@ vars = {
1111
}
1212

1313
deps = {
14-
Var("ssl_impl"): Var(Var("ssl_impl")),
14+
"openssl": "https://github.com/openssl/openssl.git@OpenSSL_1_0_2d",
1515
"gflags": "https://github.com/gflags/gflags.git@v2.1.2",
1616
"glog": "https://github.com/benlaurie/glog.git@0.3.4-fix",
1717
"googlemock": "https://github.com/google/googlemock.git@release-1.7.0",
1818
"googlemock/gtest": "https://github.com/google/googletest.git@release-1.7.0",
19-
"icu4c": "https://github.com/icu-project/icu4c.git@8ce90b88807aa2bd031a4b7608b23b1c5984cf08",
2019
"json-c": "https://github.com/AlCutter/json-c.git@json-c-0.12-20140410-fix",
2120
"ldns": "https://github.com/benlaurie/ldns.git@1.6.17-fix",
2221
"leveldb": "https://github.com/google/leveldb.git@v1.18",
@@ -70,7 +69,7 @@ else:
7069

7170
num_cores = multiprocessing.cpu_count()
7271

73-
print("Building with %s" % Var("ssl_impl"))
72+
print("Building with %s" % "openssl")
7473
print("Using make %s with %d jobs" % (make, num_cores))
7574

7675
here = os.getcwd()
@@ -88,8 +87,8 @@ hooks = [
8887
},
8988
{
9089
"name": "ssl",
91-
"pattern": Var("ssl_impl") + "/",
92-
"action": [ make, "-f", os.path.join(here, "certificate-transparency/build.gclient"), "_" + Var("ssl_impl") ],
90+
"pattern": "openssl/",
91+
"action": [ make, "-f", os.path.join(here, "certificate-transparency/build.gclient"), "_" + "openssl" ],
9392
},
9493
{
9594
"name": "libevent",
@@ -136,27 +135,19 @@ hooks = [
136135
"pattern": "^json-c/",
137136
"action": [ make, "-f", os.path.join(here, "certificate-transparency/build.gclient"), "_json-c" ],
138137
},
139-
{
140-
"name": "icu4c",
141-
"pattern": "^icu4c/",
142-
"action": [ make, "-f", os.path.join(here, "certificate-transparency/build.gclient"), "_icu4c" ],
143-
},
144138
{
145139
"name": "objecthash",
146140
"pattern": "^certificate-transparency/third_party/objecthash/",
147141
"action": [ make, "-f", os.path.join(here, "certificate-transparency/build.gclient"), "_objecthash" ],
148142
}]
149143

150144
# Currently only Openssl is supported for building the DNS server due to LDNS's dependency.
151-
if Var("ssl_impl") == 'openssl':
152-
hooks.append(
153-
{
145+
hooks.append(
146+
{
154147
"name": "ldns",
155148
"pattern": "^ldns/",
156149
"action": [ make, "-f", os.path.join(here, "certificate-transparency/build.gclient"), "_ldns" ],
157-
})
158-
else:
159-
print("NOT building DNS server since we're using BoringSSL.")
150+
})
160151

161152
# Do this last
162153
hooks.append(

configure.ac

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,6 @@ AX_CXX_COMPILE_STDCXX_11
3030

3131
PKG_CHECK_MODULES([json_c], [json-c])
3232
PKG_CHECK_MODULES([evhtp], [evhtp])
33-
PKG_CHECK_MODULES([icu], [icu-uc])
3433

3534
if test "x${enable_hardening}" != "xno"; then
3635
common_harden_copts="-fstack-protector-all -fPIC -Wa,--noexecstack -Wformat -Wformat-security"

0 commit comments

Comments
 (0)