Update dependency pinning#118
Open
mm-psy wants to merge 9 commits into
Open
Conversation
Dependency ReviewThe following issues were found:
License Issuessource/AAS.TwinEngine.DataEngine/AAS.TwinEngine.DataEngine.csproj
OpenSSF Scorecard
Scanned Files
|
- Modified AAS.TwinEngine.Plugin.TestPlugin.csproj to include RestorePackagesWithLockFile property. - Changed package references to use version ranges for better dependency management. - Added packages.lock.json to lock dependencies and ensure consistent builds.
This reverts commit 0556ec8.
There was a problem hiding this comment.
Pull request overview
This PR introduces deterministic NuGet dependency pinning across the solution by enabling/committing packages.lock.json files and updating build steps/configuration to respect locked restores.
Changes:
- Enabled NuGet lock files (
RestorePackagesWithLockFile) and committedpackages.lock.jsonfor application and test projects. - Updated Docker build stages to
dotnet publish --no-restoreafter an explicitdotnet restore --locked-mode. - Removed
renovate.jsonand adjusted Dependabot configuration (addedcooldownfor the docker ecosystem).
Reviewed changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| source/AAS.TwinEngine.Plugin.TestPlugin/packages.lock.json | Adds NuGet lock file for deterministic dependency restore. |
| source/AAS.TwinEngine.Plugin.TestPlugin/Dockerfile | Publishes with --no-restore after locked restore. |
| source/AAS.TwinEngine.Plugin.TestPlugin/AAS.TwinEngine.Plugin.TestPlugin.csproj | Enables lock file restores and pins dependency versions. |
| source/AAS.TwinEngine.Plugin.TestPlugin.UnitTests/packages.lock.json | Adds NuGet lock file for test project restore determinism. |
| source/AAS.TwinEngine.Plugin.TestPlugin.UnitTests/AAS.TwinEngine.Plugin.TestPlugin.UnitTests.csproj | Enables lock file restores and pins dependency versions. |
| source/AAS.TwinEngine.Plugin.TestPlugin.PlaywrightTests/packages.lock.json | Adds NuGet lock file for Playwright test project restore determinism. |
| source/AAS.TwinEngine.Plugin.TestPlugin.PlaywrightTests/AAS.TwinEngine.Plugin.TestPlugin.PlaywrightTests.csproj | Enables lock file restores and pins dependency versions. |
| source/AAS.TwinEngine.DataEngine/packages.lock.json | Adds NuGet lock file for deterministic dependency restore. |
| source/AAS.TwinEngine.DataEngine/Dockerfile | Publishes with --no-restore after locked restore. |
| source/AAS.TwinEngine.DataEngine/AAS.TwinEngine.DataEngine.csproj | Enables lock file restores and pins dependency versions. |
| source/AAS.TwinEngine.DataEngine.UnitTests/packages.lock.json | Adds NuGet lock file for test project restore determinism. |
| source/AAS.TwinEngine.DataEngine.UnitTests/AAS.TwinEngine.DataEngine.UnitTests.csproj | Enables lock file restores and pins dependency versions. |
| source/AAS.TwinEngine.DataEngine.ModuleTests/packages.lock.json | Adds NuGet lock file for module test project restore determinism. |
| source/AAS.TwinEngine.DataEngine.ModuleTests/AAS.TwinEngine.DataEngine.ModuleTests.csproj | Enables lock file restores and pins dependency versions. |
| renovate.json | Removes Renovate configuration. |
| .github/dependabot.yml | Adds cooldown configuration for docker updates. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mm-hsh
approved these changes
May 22, 2026
|
Test & Coverage ReportTest Results Summary
Code CoverageUnit Tests Coverage
Minimum allowed line rate is Module Tests Coverage
|
mm-asha
approved these changes
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



No description provided.