Skip to content

chore(coderabbit): flip request_changes_workflow → false (advisory posture)#150

Merged
ANcpLua merged 1 commit into
mainfrom
claude/coderabbit-advisory-posture
May 13, 2026
Merged

chore(coderabbit): flip request_changes_workflow → false (advisory posture)#150
ANcpLua merged 1 commit into
mainfrom
claude/coderabbit-advisory-posture

Conversation

@ANcpLua
Copy link
Copy Markdown
Owner

@ANcpLua ANcpLua commented May 13, 2026

Summary

Aligns NET.Sdk's CodeRabbit posture with the other 3 framework repos
(Analyzers, Roslyn.Utilities, Agents): CodeRabbit posts comments rather
than "Request Changes" reviews, so its feedback never blocks GitHub
native auto-merge.

Why

CodeRabbit's "Request Changes" reviews block native auto-merge even
with 0 required approvals on branch protection (GitHub-wide behavior).
On a Renovate or owner PR opened while no human is around to dismiss or
address the review, that means the PR sits indefinitely.

The other 3 framework repos already flipped this (Agents commit
bc06b2e); NET.Sdk was missed. Folding the fix in now since the
follow-on auto-merge PR (#149) already squash-merged before I could
amend it onto that branch.

Test plan

  • Diff is the single-line config flip
  • CI passes
  • Future CodeRabbit review on this repo posts a Comment, not a
    Request Changes — verifiable on the next Renovate PR

🤖 Generated with Claude Code


View in Codesmith
Need help on this PR? Tag @codesmith with what you need.

  • Let Codesmith autofix CI failures and bot reviews

…sture)

CodeRabbit's "Request Changes" reviews block GitHub native auto-merge
even with 0 required approvals on branch protection — so a CodeRabbit
review on a Renovate or owner PR while no human is available to dismiss
or address it would freeze the merge indefinitely.

Aligns NET.Sdk with Analyzers / Roslyn.Utilities / Agents, which already
made this flip (Agents commit bc06b2e). Folds into the auto-merge hygiene
PR since it's the same concern: keep auto-merge from being blocked by
advisory bot reviews when the owner is away.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings May 13, 2026 02:20
@ANcpLua ANcpLua enabled auto-merge (squash) May 13, 2026 02:20
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 13, 2026

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (1)
  • .coderabbit.yaml is excluded by none and included by none

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 54520f36-1acf-4a14-851b-7344ec8bd02f

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

@coderabbitai autofix

@claude
Copy link
Copy Markdown

claude Bot commented May 13, 2026

Claude encountered an error —— View job


I'll analyze this and get back to you.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 13, 2026

Note

Autofix is a beta feature. Expect some limitations and changes as we gather feedback and continue to improve it.

Autofix skipped. No unresolved CodeRabbit review comments with fix instructions found.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adjusts the repository’s CodeRabbit configuration to adopt an “advisory” review posture so that CodeRabbit feedback is posted as comments rather than “Request Changes” reviews, avoiding blocked GitHub native auto-merge.

Changes:

  • Flips .coderabbit.yaml reviews.request_changes_workflow from true to false.
  • Adds inline configuration comments documenting the rationale and alignment with other related repos.

@ANcpLua ANcpLua merged commit 7d1f431 into main May 13, 2026
16 checks passed
@ANcpLua ANcpLua deleted the claude/coderabbit-advisory-posture branch May 13, 2026 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants