Skip to content

fix(versions): bump BitNet hosting pin to 1.4.10-alpha.1#151

Merged
github-actions[bot] merged 1 commit into
mainfrom
fix/bitnet-version-pin-1.4.10-alpha.1
May 13, 2026
Merged

fix(versions): bump BitNet hosting pin to 1.4.10-alpha.1#151
github-actions[bot] merged 1 commit into
mainfrom
fix/bitnet-version-pin-1.4.10-alpha.1

Conversation

@ANcpLua
Copy link
Copy Markdown
Owner

@ANcpLua ANcpLua commented May 13, 2026

Summary

  • Bump `ANcpLuaAgentsHostingBitNetVersion` from `1.4.3-alpha.1` (never published) to `1.4.10-alpha.1` (first actually-published version).

Why

`ANcpLua.Agents.Hosting.BitNet 1.4.3-alpha.1` was a placeholder pin pointing at a version that was never released. Two upstream bugs landed it in this state:

  1. ANcpLua/ANcpLua.Agents' publish workflow pack step never included `Hosting.BitNet` — 10/11 packages got pushed on v1.4.9, BitNet wasn't one of them.
  2. The Must-Publish gate only diffed `src/` and `tests/`, so the workflow-only fix that added the pack line couldn't itself publish.

Both fixed upstream:

First real publish landed at `ANcpLua.Agents.Hosting.BitNet 1.4.10-alpha.1`.

Without this PR, every consumer pulling `ANcpLua.NET.Sdk` hits `NU1101: Unable to find package ANcpLua.Agents.Hosting.BitNet` — confirmed on O-ANcppLua/qyl run 25765366669 where the qyl.loom backend restore failed for exactly this reason.

Test plan

  • Diff is a single-line version bump, no surface-area change.
  • CI green on this PR.
  • On merge → SDK auto-publishes a new patch version.
  • Re-run O-ANcppLua/qyl main CI; `Backend (.NET)` restore step resolves `ANcpLua.Agents.Hosting.BitNet 1.4.10-alpha.1` from nuget.org and proceeds.

🤖 Generated with Claude Code


View in Codesmith
Need help on this PR? Tag @codesmith with what you need.

  • Let Codesmith autofix CI failures and bot reviews

Summary by CodeRabbit

  • Chores
    • Updated BitNet Hosting component default version from 1.4.3-alpha.1 to 1.4.10-alpha.1.

…lly-published version)

The pin was 1.4.3-alpha.1, but that version was never published to
nuget.org — the BitNet hosting package was silently dropped from the
ANcpLua.Agents publish workflow's pack step (10/11 packages got pushed,
BitNet wasn't one of them). Fixed upstream by ANcpLua/ANcpLua.Agents
@ 2f0f882 (workflow pack-step fix) + 0314ccb (gate fix that allowed
the recovery release to actually ship). First real publish is
ANcpLua.Agents.Hosting.BitNet 1.4.10-alpha.1.

Without this bump, every consumer pulling ANcpLua.NET.Sdk hits
NU1101 ("Unable to find package ANcpLua.Agents.Hosting.BitNet, no
packages exist with this id in source(s): nuget.org") — confirmed
on O-ANcppLua/qyl run 25765366669 where the qyl.loom backend
restore failed for exactly this reason.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings May 13, 2026 03:02
@github-actions github-actions Bot enabled auto-merge (squash) May 13, 2026 03:02
@github-actions
Copy link
Copy Markdown

@coderabbitai autofix

@claude
Copy link
Copy Markdown

claude Bot commented May 13, 2026

Claude encountered an error —— View job


I'll analyze this and get back to you.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 13, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 8825aa8b-100d-454c-9bd2-92bd79d13f9a

📥 Commits

Reviewing files that changed from the base of the PR and between 7d1f431 and e9cb48c.

📒 Files selected for processing (1)
  • src/Build/Common/Version.props
📜 Recent review details
⏰ Context from checks skipped due to timeout of 180000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: create_nuget
  • GitHub Check: Agent
  • GitHub Check: lint_config
🧰 Additional context used
📓 Path-based instructions (5)
src/Build/**/*.props

📄 CodeRabbit inference engine (src/CLAUDE.md)

src/Build/**/*.props: Props files in src/Build/Common/ and src/Build/Enforcement/ should set properties and defaults using guard patterns like Condition="'$(Property)' == ''" to allow consumer override
Use GlobalPackageReference in analyzer injection configuration for immutable package references when Central Package Management (CPM) is enabled

Files:

  • src/Build/Common/Version.props
src/Build/Common/Version.props

📄 CodeRabbit inference engine (src/CLAUDE.md)

Version.props in src/Build/Common/ is the authoritative source of truth for all package versions across the SDK

Define all package versions in src/Build/Common/Version.props as the single source of truth for the SDK ecosystem

Files:

  • src/Build/Common/Version.props
**/*.props

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

Do not import Common.props outside the Sdk.props wrapper and do not change the import order: Sdk.propsMicrosoft.NET.SdkCommon.propsEnforcement.props — the _MustImportMicrosoftNETSdk guard enforces this

Files:

  • src/Build/Common/Version.props

⚙️ CodeRabbit configuration file

**/*.props: MSBuild property files. Review for: condition guards on every override
(consumer must be able to opt out), no <RemoveAttributes> on items
that consumers may have set, and that defaults are sensible without
forcing a downstream cascade.

Files:

  • src/Build/Common/Version.props
**/*.{props,targets}

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

Never use hardcoded paths in .props/.targets files — always use $(MSBuildThisFileDirectory) instead

Files:

  • src/Build/Common/Version.props
src/Build/**

⚙️ CodeRabbit configuration file

src/Build/**: Build targets shared across .NET.Sdk, .Test, .Web variants. Review for:
target-name collisions with consumer csproj (use unique prefixes), correct
BeforeTargets/AfterTargets ordering, and idempotent execution (target
should be safe to run twice).

Files:

  • src/Build/Common/Version.props
🔇 Additional comments (1)
src/Build/Common/Version.props (1)

128-128: LGTM!


📝 Walkthrough

Walkthrough

This change updates the default NuGet package version for the BitNet Hosting dependency. The property ANcpLuaAgentsHostingBitNetVersion in src/Build/Common/Version.props is updated from version 1.4.3-alpha.1 to 1.4.10-alpha.1. This default applies when the property remains unset at build time. The modification affects the conditional version assignment for the hosting component in the BitNet build infrastructure. One line modified in the version properties file.


Important

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

❌ Failed checks (1 error, 1 warning)

Check name Status Explanation Resolution
No Datetime.Now/Utcnow ❌ Error DateTime.Now/UtcNow found in modified C# files without required inline comments. Violations: BannedApiTests.cs line 50, SdkTests.cs lines 227, 272, 291. Add explicit inline comments explaining why DateTime.Now is necessary in test fixtures (e.g., "// Intentional: testing banned API detection").
No Suppression Of Fixable Diagnostics ⚠️ Warning Three [SuppressMessage] attributes added in test files for CA2000 (Dispose objects before losing scope) without matching approved suppressions allowlist. CA2000 disposal suppressions in MtpDetectionTests.cs, SdkTests.cs, SourceGeneratorDefaultsTests.cs not on approved list. Either add to allowlist or refactor to avoid suppressions.
✅ Passed checks (6 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed Title follows conventional commits format (fix prefix), is 56 chars (<72), contains no period, and accurately describes the version bump change.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
No .Result/.Wait() Blocking Async ✅ Passed PR modifies only .props file (MSBuild metadata), not C# source. Check targets C# files exclusively. No C# files modified means check not applicable.
No Null-Forgiving Operator Without Justification ✅ Passed Scanned all 18 added/modified C# files for null-forgiving operators. Zero instances found. All ! uses are logical NOT or pattern matching, not nullability suppressors.

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 13, 2026

Note

Autofix is a beta feature. Expect some limitations and changes as we gather feedback and continue to improve it.

Autofix skipped. No unresolved CodeRabbit review comments with fix instructions found.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the SDK’s pinned version for the BitNet hosting package to a NuGet version that actually exists, preventing downstream restores from failing when consumers opt into ANcpLua.NET.Sdk.BitNet.

Changes:

  • Bump ANcpLuaAgentsHostingBitNetVersion from 1.4.3-alpha.1 to 1.4.10-alpha.1 in the shared versions props file.

@github-actions github-actions Bot merged commit d2e30ee into main May 13, 2026
16 checks passed
@ANcpLua ANcpLua deleted the fix/bitnet-version-pin-1.4.10-alpha.1 branch May 16, 2026 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants