Bump ANcpLua.Analyzers to 1.29.2 by ANcpLua · Pull Request #154 · ANcpLua/ANcpLua.NET.Sdk

ANcpLua · 2026-05-13T09:24:51Z

Summary

Bump ANcpLuaAnalyzersVersion from 1.29.1 to the newly published 1.29.2 package.
Regenerate Analyzer.ANcpLua.Analyzers.editorconfig from the published analyzer package, removing stale diagnostics no longer emitted by the package and adding AL0139/AL0140.

Release chain verified

ANcpLua.Analyzers v1.29.2 tag was pushed at 94f4d05410346c1b597a5863e64574cf2991afad.
Trusted publishing workflow completed successfully: Restore, Build, Pack, NuGet OIDC login, NuGet push, and GitHub Packages push.
NuGet flat-container now serves ANcpLua.Analyzers 1.29.2.

Validation

dotnet run --project tools/ConfigFilesGenerator/ConfigFilesGenerator.csproj (0 configuration files written on second run)
dotnet build ANcpLua.NET.Sdk.slnx -c Release (0 Warning(s), 0 Error(s))
dotnet test --project tests/ANcpLua.Sdk.Tests/ANcpLua.Sdk.Tests.csproj -c Release --no-build (235 passed, 0 failed)
git diff --check

^{Need help on this PR? Tag @codesmith with what you need.}

Let Codesmith autofix CI failures and bot reviews

Summary by CodeRabbit

Chores
- Updated analyzers to version 1.29.2
- Refined diagnostic rule configuration: removed several legacy checks, adjusted severities for existing rules, and added two new suggestion-level validations to improve code analysis feedback

github-actions · 2026-05-13T09:25:03Z

@coderabbitai autofix

coderabbitai · 2026-05-13T09:25:05Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: b4a36f90-29af-4ca0-bf98-e8555ff3182f

📥 Commits

Reviewing files that changed from the base of the PR and between 71327ad and ea62a7e.

📒 Files selected for processing (2)

src/Build/Common/Version.props
src/Config/Analyzer.ANcpLua.Analyzers.editorconfig

📜 Recent review details

⏰ Context from checks skipped due to timeout of 180000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)

GitHub Check: create_nuget
GitHub Check: lint_config

🧰 Additional context used

📓 Path-based instructions (7)

src/Build/**/*.props

📄 CodeRabbit inference engine (src/CLAUDE.md)

src/Build/**/*.props: Props files in src/Build/Common/ and src/Build/Enforcement/ should set properties and defaults using guard patterns like Condition="'$(Property)' == ''" to allow consumer override
Use GlobalPackageReference in analyzer injection configuration for immutable package references when Central Package Management (CPM) is enabled

Files:

src/Build/Common/Version.props

src/Build/Common/Version.props

📄 CodeRabbit inference engine (src/CLAUDE.md)

Version.props in src/Build/Common/ is the authoritative source of truth for all package versions across the SDK

Files:

src/Build/Common/Version.props

**/*.props

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

Do not import Common.props outside the Sdk.props wrapper and do not change the import order: Sdk.props → Microsoft.NET.Sdk → Common.props → Enforcement.props — the _MustImportMicrosoftNETSdk guard enforces this

Files:

src/Build/Common/Version.props

⚙️ CodeRabbit configuration file

**/*.props: MSBuild property files. Review for: condition guards on every override
(consumer must be able to opt out), no <RemoveAttributes> on items
that consumers may have set, and that defaults are sensible without
forcing a downstream cascade.

Files:

src/Build/Common/Version.props

**/*.{props,targets}

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

Never use hardcoded paths in .props/.targets files — always use $(MSBuildThisFileDirectory) instead

Files:

src/Build/Common/Version.props

**/Build/Common/Version.props

📄 CodeRabbit inference engine (AGENTS.md)

Version.props in ANcpLua.NET.Sdk is the definitive source of truth for all SDK ecosystem package versions

Files:

src/Build/Common/Version.props

src/Build/**

⚙️ CodeRabbit configuration file

src/Build/**: Build targets shared across .NET.Sdk, .Test, .Web variants. Review for:
target-name collisions with consumer csproj (use unique prefixes), correct
BeforeTargets/AfterTargets ordering, and idempotent execution (target
should be safe to run twice).

Files:

src/Build/Common/Version.props

src/Config/**/*.editorconfig

📄 CodeRabbit inference engine (src/CLAUDE.md)

Configuration files in src/Config/ should use flat layout with specific naming conventions: Analyzer..editorconfig for per-analyzer rules, Global.editorconfig as authoritative, and per-variant ANcpLua.NET.Sdk..editorconfig files

Files:

src/Config/Analyzer.ANcpLua.Analyzers.editorconfig

🧠 Learnings (1)

📚 Learning: 2026-05-12T11:36:39.749Z

Learnt from: ANcpLua
Repo: ANcpLua/ANcpLua.NET.Sdk PR: 143
File: src/Config/ANcpLua.NET.Sdk.BitNet.editorconfig:5-9
Timestamp: 2026-05-12T11:36:39.749Z
Learning: In this repository’s per-variant editorconfig overlays under `src/Config/`, keep variant settings mirrored between the web-based overlays (e.g., `ANcpLua.NET.Sdk.Web.editorconfig` and `ANcpLua.NET.Sdk.BitNet.editorconfig`). Specifically, for CA1002 (`CA1002` / `dotnet_diagnostic.CA1002.severity`), any policy change must be made first in the Web overlay and then mirrored to the BitNet overlay—do not apply CA1002 changes asymmetrically to only one variant.

Applied to files:

src/Config/Analyzer.ANcpLua.Analyzers.editorconfig

🔇 Additional comments (2)

src/Build/Common/Version.props (1)

56-56: LGTM!

src/Config/Analyzer.ANcpLua.Analyzers.editorconfig (1)

481-494: LGTM!

📝 Walkthrough

Walkthrough

The PR updates ANcpLuaAnalyzersVersion in src/Build/Common/Version.props from 1.29.1 to 1.29.2. src/Config/Analyzer.ANcpLua.Analyzers.editorconfig removes many diagnostic entries (AL0010, AL0012, AL0013, AL0061–AL0079, AL0083, AL0085–AL0093, AL0096, AL0107–AL0110, AL0113, AL0124, AL0131–AL0136), retains AL0011 and AL0084 as warning, and adds AL0139 and AL0140 with severity suggestion.

Important

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

❌ Failed checks (1 error)

Check name	Status	Explanation	Resolution
Title check	❌ Error	Title uses 'Bump' prefix instead of conventional commit type (feat\|fix\|refactor\|chore\|docs\|test\|ci\|perf\|deps); does not follow required format.	Use conventional commit prefix: 'deps(build): bump ANcpLua.Analyzers to 1.29.2' or 'chore(deps): bump ANcpLua.Analyzers to 1.29.2'.

✅ Passed checks (7 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
No Datetime.Now/Utcnow	✅ Passed	No C# files modified in this PR. Changes limited to Version.props (MSBuild XML) and .editorconfig (diagnostic configuration). Check not applicable.
No .Result/.Wait() Blocking Async	✅ Passed	PR modifies only non-C# files: Version.props (MSBuild XML) and editorconfig (configuration). Custom check targets C# files for blocking async patterns. No C# files modified—check not applicable.
No Null-Forgiving Operator Without Justification	✅ Passed	Scanned all 18 added/modified C# files for null-forgiving operator (!) usage. Zero instances found across templates, tests, and tools.
No Suppression Of Fixable Diagnostics	✅ Passed	No C# files modified. PR changes only Version.props (MSBuild config) and Analyzer.ANcpLua.Analyzers.editorconfig (diagnostic settings). No pragma directives or SuppressMessage attributes present.

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai · 2026-05-13T09:25:08Z

Note

Autofix is a beta feature. Expect some limitations and changes as we gather feedback and continue to improve it.

Autofix skipped. No unresolved CodeRabbit review comments with fix instructions found.

claude · 2026-05-13T09:25:15Z

Claude encountered an error —— View job

I'll analyze this and get back to you.

Copilot

Pull request overview

Updates the SDK’s bundled analyzer package to the newly published ANcpLua.Analyzers v1.29.2 and refreshes the corresponding generated analyzer .editorconfig so it matches the diagnostics emitted by that version.

Changes:

Bump ANcpLuaAnalyzersVersion from 1.29.1 to 1.29.2.
Regenerate Analyzer.ANcpLua.Analyzers.editorconfig to remove stale diagnostics and add new rules AL0139/AL0140.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
`src/Build/Common/Version.props`	Updates the centralized analyzer package version to `1.29.2`.
`src/Config/Analyzer.ANcpLua.Analyzers.editorconfig`	Regenerated analyzer configuration to align severities and rule list with v1.29.2 (adds AL0139/AL0140, removes diagnostics no longer present).

ANcpLua · 2026-05-13T09:48:46Z

pr-heal: providers tried — CodeRabbit autofix=skipped, Claude=failure. None resolved the block (state was BEHIND). Next sweep in 15 min; if this is recurring, the Codex/Copilot fallback tiers are tracked in pr-heal.yml.

github-actions · 2026-05-13T09:56:48Z

@coderabbitai autofix

coderabbitai · 2026-05-13T09:56:54Z

Note

Autofix is a beta feature. Expect some limitations and changes as we gather feedback and continue to improve it.

Autofix skipped. No unresolved CodeRabbit review comments with fix instructions found.

claude · 2026-05-13T09:56:57Z

Claude encountered an error —— View job

I'll analyze this and get back to you.

Copilot AI review requested due to automatic review settings May 13, 2026 09:24

github-actions Bot enabled auto-merge (squash) May 13, 2026 09:25

Copilot started reviewing on behalf of ANcpLua May 13, 2026 09:25 View session

Copilot AI reviewed May 13, 2026

View reviewed changes

ANcpLua added 2 commits May 13, 2026 11:50

fix(versions): bump ANcpLua.Analyzers to 1.29.2

f21bbea

fix(config): demote analyzer type-style rules

ea62a7e

ANcpLua force-pushed the dev/bump-analyzers-1.29.2 branch from 71327ad to ea62a7e Compare May 13, 2026 09:56

github-actions Bot merged commit 3e67cb1 into main May 13, 2026
12 checks passed

ANcpLua deleted the dev/bump-analyzers-1.29.2 branch May 16, 2026 10:53

coderabbitai Bot mentioned this pull request May 18, 2026

chore: align analyzer conventions ANcpLua/ANcpLua.Roslyn.Utilities#129

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bump ANcpLua.Analyzers to 1.29.2#154

Bump ANcpLua.Analyzers to 1.29.2#154
github-actions[bot] merged 2 commits into
mainfrom
dev/bump-analyzers-1.29.2

ANcpLua commented May 13, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

github-actions Bot commented May 13, 2026

Uh oh!

coderabbitai Bot commented May 13, 2026 •

edited

Loading

Walkthrough

Pre-merge checks failed

Uh oh!

coderabbitai Bot commented May 13, 2026

Uh oh!

claude Bot commented May 13, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

ANcpLua commented May 13, 2026

Uh oh!

github-actions Bot commented May 13, 2026

Uh oh!

coderabbitai Bot commented May 13, 2026

Uh oh!

claude Bot commented May 13, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

ANcpLua commented May 13, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Release chain verified

Validation

Summary by CodeRabbit

Uh oh!

github-actions Bot commented May 13, 2026

Uh oh!

coderabbitai Bot commented May 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Pre-merge checks failed

❌ Failed checks (1 error)

Uh oh!

coderabbitai Bot commented May 13, 2026

Uh oh!

claude Bot commented May 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

ANcpLua commented May 13, 2026

Uh oh!

github-actions Bot commented May 13, 2026

Uh oh!

coderabbitai Bot commented May 13, 2026

Uh oh!

claude Bot commented May 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

ANcpLua commented May 13, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented May 13, 2026 •

edited

Loading

claude Bot commented May 13, 2026 •

edited

Loading

claude Bot commented May 13, 2026 •

edited

Loading