Skip to content

chore: align SDK version with 10.0.300#160

Merged
github-actions[bot] merged 2 commits into
mainfrom
codex/update-dotnet-sdk-10.0.300
May 16, 2026
Merged

chore: align SDK version with 10.0.300#160
github-actions[bot] merged 2 commits into
mainfrom
codex/update-dotnet-sdk-10.0.300

Conversation

@ANcpLua
Copy link
Copy Markdown
Owner

@ANcpLua ANcpLua commented May 16, 2026

Updates the internal SDK version inputs to align with .NET SDK 10.0.300.

Publishing remains handled by the existing trusted publishing workflow; this PR does not publish packages directly.

Summary by CodeRabbit

  • Chores
    • Updated .NET SDK version from 10.0.203 to 10.0.300 across build infrastructure and verification scripts.
  • Style
    • Added a global analyzer rule for CA2266 (file-based program entry point) and set its severity to warning.

Copilot AI review requested due to automatic review settings May 16, 2026 01:53
@github-actions
Copy link
Copy Markdown

@coderabbitai autofix

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 16, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 9830cde1-6e2c-4fc0-852b-cbfdfe588d90

📥 Commits

Reviewing files that changed from the base of the PR and between 3837cdb and 8e86f74.

📒 Files selected for processing (1)
  • src/Config/Analyzer.Microsoft.CodeAnalysis.NetAnalyzers.editorconfig
📜 Recent review details
⏰ Context from checks skipped due to timeout of 180000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: create_nuget
  • GitHub Check: Codacy Static Code Analysis
  • GitHub Check: lint_config
🧰 Additional context used
📓 Path-based instructions (1)
src/Config/**/*.editorconfig

📄 CodeRabbit inference engine (src/CLAUDE.md)

Configuration files in src/Config/ should use flat layout with specific naming conventions: Analyzer..editorconfig for per-analyzer rules, Global.editorconfig as authoritative, and per-variant ANcpLua.NET.Sdk..editorconfig files

Files:

  • src/Config/Analyzer.Microsoft.CodeAnalysis.NetAnalyzers.editorconfig
🧠 Learnings (1)
📚 Learning: 2026-05-12T11:36:39.749Z
Learnt from: ANcpLua
Repo: ANcpLua/ANcpLua.NET.Sdk PR: 143
File: src/Config/ANcpLua.NET.Sdk.BitNet.editorconfig:5-9
Timestamp: 2026-05-12T11:36:39.749Z
Learning: In this repository’s per-variant editorconfig overlays under `src/Config/`, keep variant settings mirrored between the web-based overlays (e.g., `ANcpLua.NET.Sdk.Web.editorconfig` and `ANcpLua.NET.Sdk.BitNet.editorconfig`). Specifically, for CA1002 (`CA1002` / `dotnet_diagnostic.CA1002.severity`), any policy change must be made first in the Web overlay and then mirrored to the BitNet overlay—do not apply CA1002 changes asymmetrically to only one variant.

Applied to files:

  • src/Config/Analyzer.Microsoft.CodeAnalysis.NetAnalyzers.editorconfig
🔇 Additional comments (1)
src/Config/Analyzer.Microsoft.CodeAnalysis.NetAnalyzers.editorconfig (1)

1178-1181: LGTM!


📝 Walkthrough

Walkthrough

This PR updates the .NET SDK version reference from 10.0.203 to 10.0.300 across the build system. The MSBuild property DotNetSdkVersion is updated in src/Build/Common/Version.props, and the corresponding version string in the Gate 1 macOS parity check within tools/verify-templates.ps1 is synchronized accordingly. Both changes are single-line updates that maintain consistent version targeting across build configuration and verification infrastructure. Additionally, a global analyzer rule for CA2266 is added to the repo-level editorconfig with severity set to warning.


Important

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

❌ Failed checks (1 error, 1 warning)

Check name Status Explanation Resolution
No Datetime.Now/Utcnow ❌ Error DateTime.Now found in 4 test fixture locations (BannedApiTests.cs:50, SdkTests.cs:227,272,291) without inline comments explaining necessity per test fixture exception. Add // TEST FIXTURE: comment before DateTime.Now usages explaining they intentionally test banned API detection (RS0030 analyzer warnings).
No Suppression Of Fixable Diagnostics ⚠️ Warning Three CA2000 SuppressMessage attributes added without matching allowlist categories: MEAI001/OPENAI002, source-gen, DevUI, AOT/trimming, netstandard2.0. Remove 3 CA2000 SuppressMessage attributes or refactor factory methods to eliminate the warning.
✅ Passed checks (6 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed Title follows conventional commit format (chore prefix), is under 72 characters (38 chars), and accurately describes the main changeset: aligning .NET SDK version to 10.0.300 across build, verification, and analyzer configs.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
No .Result/.Wait() Blocking Async ✅ Passed No C# files were modified in this PR. All three changed files are non-C# formats: .props (MSBuild), .ps1 (PowerShell), and .editorconfig. Check is inapplicable.
No Null-Forgiving Operator Without Justification ✅ Passed No C# files modified in this PR. Check scans only C# source files for null-forgiving operators without justification. PR changes limited to Version.props, verify-templates.ps1, and editorconfig.

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 16, 2026

Note

Autofix is a beta feature. Expect some limitations and changes as we gather feedback and continue to improve it.

Autofix skipped. No unresolved CodeRabbit review comments with fix instructions found.

@claude
Copy link
Copy Markdown

claude Bot commented May 16, 2026

Claude encountered an error after 2s —— View job


I'll analyze this and get back to you.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Aligns internal SDK version references with the repo's pinned .NET SDK 10.0.300 (already set in global.json), bringing build infrastructure metadata and documentation comments into sync.

Changes:

  • Bump DotNetSdkVersion from 10.0.203 to 10.0.300 in Version.props.
  • Update CI-parity comment in verify-templates.ps1 to reference 10.0.300.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/Build/Common/Version.props Updates <DotNetSdkVersion> to 10.0.300
tools/verify-templates.ps1 Updates doc comment to reflect new SDK version

@codacy-production
Copy link
Copy Markdown

codacy-production Bot commented May 16, 2026

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

AI Reviewer: first review requested successfully. AI can make mistakes. Always validate suggestions.

Run reviewer

TIP This summary will be updated as you push new changes.

Copy link
Copy Markdown

@codacy-production codacy-production Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

While the PR is technically 'Up to Standards' according to Codacy, it fails to meet its primary objective. The update is restricted to documentation comments in tools/verify-templates.ps1 and does not modify the actual SDK version used by the environment or CI workflows. This creates a risk of stale documentation where the claimed SDK version (10.0.300) does not match the version actually being utilized by the project. A complete implementation should include updates to configuration files like global.json or GitHub Action workflows.

About this PR

  • The PR title and description indicate an alignment with .NET SDK 10.0.300, yet no functional configuration files (e.g., global.json, YAML workflows) are included in the diff. This could lead to a configuration-documentation mismatch.

Test suggestions

  • Verify that the CI environment and build workflows are actually utilizing .NET SDK 10.0.300 as suggested by the documentation update.
Prompt proposal for missing tests
Consider implementing these tests if applicable:
1. Verify that the CI environment and build workflows are actually utilizing .NET SDK 10.0.300 as suggested by the documentation update.

TIP Improve review quality by adding custom instructions
TIP How was this review? Give us feedback


Run this BEFORE pushing PR changes that affect the templates pipeline. CI parity:
GitHub macOS uses identical dotnet 10.0.203 + identical fixture, so a green local
GitHub macOS uses identical dotnet 10.0.300 + identical fixture, so a green local
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 MEDIUM RISK

Suggestion: This update is limited to documentation. To fulfill the PR's stated intent of updating 'version inputs', ensure that actual configuration files (e.g., global.json or CI workflow files) are also updated to 10.0.300.

@ANcpLua
Copy link
Copy Markdown
Owner Author

ANcpLua commented May 16, 2026

@coderabbitai autofix

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 16, 2026

Note

Autofix is a beta feature. Expect some limitations and changes as we gather feedback and continue to improve it.

Autofix skipped. No unresolved CodeRabbit review comments with fix instructions found.

@ANcpLua
Copy link
Copy Markdown
Owner Author

ANcpLua commented May 16, 2026

pr-heal: providers tried — CodeRabbit autofix=true, Claude=failure. None resolved the block (state was BLOCKED). Next sweep in 15 min; if this is recurring, the Codex/Copilot fallback tiers are tracked in pr-heal.yml.

@github-actions
Copy link
Copy Markdown

@coderabbitai autofix

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 16, 2026

Note

Autofix is a beta feature. Expect some limitations and changes as we gather feedback and continue to improve it.

Autofix skipped. No unresolved CodeRabbit review comments with fix instructions found.

@claude
Copy link
Copy Markdown

claude Bot commented May 16, 2026

Claude encountered an error after 2s —— View job


I'll analyze this and get back to you.

@ANcpLua
Copy link
Copy Markdown
Owner Author

ANcpLua commented May 16, 2026

@coderabbitai autofix

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 16, 2026

Note

Autofix is a beta feature. Expect some limitations and changes as we gather feedback and continue to improve it.

Autofix skipped. No unresolved CodeRabbit review comments with fix instructions found.

@ANcpLua
Copy link
Copy Markdown
Owner Author

ANcpLua commented May 16, 2026

pr-heal: providers tried — CodeRabbit autofix=true, Claude=failure. None resolved the block (state was BLOCKED). Next sweep in 15 min; if this is recurring, the Codex/Copilot fallback tiers are tracked in pr-heal.yml.

@github-actions github-actions Bot merged commit ee7c14b into main May 16, 2026
13 checks passed
@ANcpLua ANcpLua deleted the codex/update-dotnet-sdk-10.0.300 branch May 16, 2026 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants