fix(windows): preserve nested node_modules during upgrade to avoid lo…#11
Merged
Conversation
…cked-file errors On Windows, `shutil.rmtree(webui)` fails with [WinError 5] because `esbuild.exe` inside `webui/node_modules/` is locked by a running process. The `_PRESERVE_NAMES` check only applied at the top level of install_root, so `webui/node_modules` was not protected. - Make `_replace_install_dir` recursively merge directories that contain preserved entries (e.g. `node_modules`) instead of rmtree + copytree - Add `_safe_rmtree` with an `onerror` handler on Windows that retries after clearing read-only flags, and skips truly locked files gracefully Made-with: Cursor
xiami762
approved these changes
Mar 31, 2026
duguwanglong
added a commit
that referenced
this pull request
Jun 8, 2026
Tests (issue #5) - Update all FakeProvider mocks from chat() to chat_stream() async generators; all 4 tests now pass (were 3/4 failing) _strip_think_blocks (issue #6) - Apply as a safety net on visible_content so think-tagged text that leaks through text deltas is stripped before the final result - Use visible_content (stripped) for final_content too System prompt alignment (issue #3) - memory_delegate: build tools before constructing the system prompt - Call SessionPrompt.build_system_prompts() with a synthetic session_id so the sub-agent gets PROMPT_DEFAULT (SecOps identity + guardrails), tool_protocol, and agent_identity — identical foundation to main loop Parallel TOCTOU guard (issue #4) - delegate_task is now serial against any non-delegation tool: prevents TOCTOU races where a sub-agent writes files while the parent loop concurrently reads (glob/grep); multiple delegations can still run concurrently against each other gateway.chat_stream tool_calls robustness (issue #11) - Emit any accumulated tool_calls after the stream loop ends, so they are not silently dropped when a gateway omits finish_reason on the final tool-call chunk loop_engine fallback warning (issue #12) - _resolve_loop_engine() now logs a warning when the requested engine id (session-level or agent-default) is not registered, making silent "UI shows Raptor, runs native" situations observable in logs loop_engine persistence deduplication (issue #13) - Extract repeated loop_engine persistence blocks into _persist_loop_engine_if_changed(); both message routes call it Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Windows,
shutil.rmtree(webui)fails with [WinError 5] becauseesbuild.exeinsidewebui/node_modules/is locked by a running process. The_PRESERVE_NAMEScheck only applied at the top level of install_root, sowebui/node_moduleswas not protected._replace_install_dirrecursively merge directories that contain preserved entries (e.g.node_modules) instead of rmtree + copytree_safe_rmtreewith anonerrorhandler on Windows that retries after clearing read-only flags, and skips truly locked files gracefully