use proper node_env env var

Author: Aiiion

docker-compose.yml

@@ -9,6 +9,7 @@ services:
     depends_on:
       - db
     environment:
+      - NODE_ENV=${NODE_ENV}
       - DB_HOST=${DB_HOST}
       - DB_PORT=${DB_PORT}
       - DB_USER=${DB_USER}

src/index.mjs

@@ -54,7 +54,7 @@ const stop = async () => {
 };
 
 // Auto-start unless running tests
-if (process.env.ENVIRONMENT !== 'test') {
+if (process.env.NODE_ENV !== 'test') {
   start().catch(() => process.exit(1));
 }
 

src/middleware/cache.middleware.mjs

@@ -2,7 +2,7 @@ import mcache from 'memory-cache';
 
 export const cache = (duration) => {
   return (req, res, next) => {
-    if(process.env.ENVIRONMENT === 'test')
+    if(process.env.NODE_ENV === 'test')
       return next()
 
     let key = '__express__' + req.originalUrl || req.url

src/tests/api.test.mjs

@@ -27,12 +27,12 @@ describe("API Routes", () => {
     lat: "40.7128",
     lon: "-74.0060",
   };
-  const originalEnv = process.env.ENVIRONMENT;
+  const originalEnv = process.env.NODE_ENV;
   const originalApiKey = process.env.OWM_API_KEY;
 
   beforeAll(async () => {
     process.env.OWM_API_KEY = 'test-key';
-    process.env.ENVIRONMENT = 'test';
+    process.env.NODE_ENV = 'test';
     // import app after env is set and mocks registered
     const mod = await import("../index.mjs");
     app = mod.default;
@@ -46,7 +46,7 @@ describe("API Routes", () => {
 
   afterAll(async () => {
     process.env.OWM_API_KEY = originalApiKey;
-    process.env.ENVIRONMENT = originalEnv;
+    process.env.NODE_ENV = originalEnv;
     if (stop) await stop();
     else if (server && typeof server.close === 'function') await new Promise((r) => server.close(r));
   });