more specific env var name for openWeatherMaps

Author: Aiiion

README.md

@@ -22,7 +22,7 @@ npm install --omit=dev
 
 npm start
 
-*You will need your own API key for openwheatermaps to get weatherdata. Add it in an .env file at the root as WEATHER_API_KEY.*
+*You will need your own API key for openwheatermaps to get weatherdata. Add it in an .env file at the root as OWM_API_KEY.*
 
 **Start this app up for development:**
 

src/middleware/validation.middleware.mjs

@@ -9,7 +9,7 @@ export const validateResult = (req, res, next) => {
 } 
 
 export const hasOwmKey = (req, res, next) => {
-    if (!process.env.WEATHER_API_KEY)
+    if (!process.env.OWM_API_KEY)
         return res
           .status(500)
           .send({ message: "API key missing from environment variables" });

src/services/openWeatherMaps.service.mjs

@@ -7,7 +7,7 @@ export const currentWeather = async (query) =>
         url: OWM_API_URL + '/weather',
         params: {
             ...query,
-            appid: process.env.WEATHER_API_KEY
+            appid: process.env.OWM_API_KEY
         }
     });
 
@@ -17,7 +17,7 @@ export const forecastWeather = async (query) =>
         url: OWM_API_URL + '/forecast',
         params: {
             ...query,
-            appid: process.env.WEATHER_API_KEY
+            appid: process.env.OWM_API_KEY
         }
     });
 
@@ -27,7 +27,7 @@ export const currentPollution = async (query) =>
         url: OWM_API_URL + '/air_pollution',
         params: {
             ...query,
-            appid: process.env.WEATHER_API_KEY
+            appid: process.env.OWM_API_KEY
         }
     });
 
@@ -37,6 +37,6 @@ export const forecastPollution = async (query) =>
         url: OWM_API_URL + '/air_pollution/forecast',
         params: {
             ...query,
-            appid: process.env.WEATHER_API_KEY
+            appid: process.env.OWM_API_KEY
         }
     });

src/tests/api.test.mjs

@@ -23,15 +23,15 @@ describe("API Routes", () => {
     lon: "-74.0060",
   };
   const originalEnv = process.env.ENVIRONMENT;
-  const originalApiKey = process.env.WEATHER_API_KEY;
+  const originalApiKey = process.env.OWM_API_KEY;
 
   beforeAll(() => {
-    process.env.WEATHER_API_KEY = 'test-key';
+    process.env.OWM_API_KEY = 'test-key';
     process.env.ENVIRONMENT = 'test';
   });
 
   afterAll((done) => {
-    process.env.WEATHER_API_KEY = originalEnv;
+    process.env.OWM_API_KEY = originalEnv;
     process.env.ENVIRONMENT = originalApiKey;
     server.close(done);
   });