From ea64b221471c74648b97fcfee38111597bdcd027 Mon Sep 17 00:00:00 2001 From: Aleksey Loginov Date: Mon, 7 Oct 2024 23:35:51 +0300 Subject: [PATCH 1/9] use cppcheck right --- CMakePresets.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CMakePresets.json b/CMakePresets.json index 149c07bd4..693a4afa8 100644 --- a/CMakePresets.json +++ b/CMakePresets.json @@ -73,7 +73,7 @@ "name": "cppcheck", "hidden": true, "cacheVariables": { - "CMAKE_CXX_CPPCHECK": "cppcheck;--inline-suppr;--std=c++20;--enable=all;--check-config;--suppress=missingIncludeSystem" + "CMAKE_CXX_CPPCHECK": "cppcheck;--inline-suppr;--std=c++20;--enable=all;--suppress=missingIncludeSystem" } }, { From 790b5b2b55d58141b554eba26390613bed0b4aef Mon Sep 17 00:00:00 2001 From: Aleksey Loginov Date: Mon, 7 Oct 2024 23:36:08 +0300 Subject: [PATCH 2/9] fix --- src/rpp/rpp/observers/observer.hpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/rpp/rpp/observers/observer.hpp b/src/rpp/rpp/observers/observer.hpp index 3f109f885..216916744 100644 --- a/src/rpp/rpp/observers/observer.hpp +++ b/src/rpp/rpp/observers/observer.hpp @@ -250,7 +250,7 @@ namespace rpp return dynamic_observer{std::move(*this)}; } - const dynamic_observer& as_dynamic() & + dynamic_observer as_dynamic() & { return dynamic_observer{*this}; } From c4760f2b29f7d62485c96619e0d2fd2ef13835d3 Mon Sep 17 00:00:00 2001 From: Aleksey Loginov Date: Mon, 7 Oct 2024 23:46:06 +0300 Subject: [PATCH 3/9] change way --- CMakePresets.json | 2 +- cppcheck.supp | 3 +++ 2 files changed, 4 insertions(+), 1 deletion(-) create mode 100644 cppcheck.supp diff --git a/CMakePresets.json b/CMakePresets.json index 693a4afa8..f7a5f3b96 100644 --- a/CMakePresets.json +++ b/CMakePresets.json @@ -73,7 +73,7 @@ "name": "cppcheck", "hidden": true, "cacheVariables": { - "CMAKE_CXX_CPPCHECK": "cppcheck;--inline-suppr;--std=c++20;--enable=all;--suppress=missingIncludeSystem" + "CMAKE_CXX_CPPCHECK": "cppcheck;--inline-suppr;--std=c++20;--enable=all;--suppressions-list=${sourceDir}/cppcheck.supp" } }, { diff --git a/cppcheck.supp b/cppcheck.supp new file mode 100644 index 000000000..c8014867f --- /dev/null +++ b/cppcheck.supp @@ -0,0 +1,3 @@ +missingIncludeSystem + +noExplicitConstructor \ No newline at end of file From 1ec1d93cbff61ac1653c4c67ed5f67fa05276d35 Mon Sep 17 00:00:00 2001 From: "pre-commit-ci[bot]" <66853113+pre-commit-ci[bot]@users.noreply.github.com> Date: Mon, 7 Oct 2024 20:46:03 +0000 Subject: [PATCH 4/9] [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --- cppcheck.supp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cppcheck.supp b/cppcheck.supp index c8014867f..108874758 100644 --- a/cppcheck.supp +++ b/cppcheck.supp @@ -1,3 +1,3 @@ missingIncludeSystem -noExplicitConstructor \ No newline at end of file +noExplicitConstructor From 1025bff2bd5d3ac69b14c3fc2992082c577a526b Mon Sep 17 00:00:00 2001 From: Aleksey Loginov Date: Tue, 8 Oct 2024 00:02:13 +0300 Subject: [PATCH 5/9] fix --- CMakePresets.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CMakePresets.json b/CMakePresets.json index f7a5f3b96..94a3861ed 100644 --- a/CMakePresets.json +++ b/CMakePresets.json @@ -80,7 +80,7 @@ "name": "clang-tidy", "hidden": true, "cacheVariables": { - "CMAKE_CXX_CLANG_TIDY": "clang-tidy;-header-filter=${sourceDir}/src/.*;-checks=-*,bugprone-*,concurrency-*,performance-*,-macro*,-bugprone-exception-escape;-warnings-as-errors=*" + "CMAKE_CXX_CLANG_TIDY": "clang-tidy;-header-filter=${sourceDir}/src/.*;-checks=-*,bugprone-*,concurrency-*,performance-*,-macro*,-bugprone-exception-escape;-warnings-as-errors=*;-extra-arg=-std=c++20" } }, { From 64a760e99c2b9903fd13e10039558a41d7d8e5e7 Mon Sep 17 00:00:00 2001 From: Aleksey Loginov Date: Tue, 8 Oct 2024 00:03:14 +0300 Subject: [PATCH 6/9] suppress --- CMakePresets.json | 2 +- cppcheck.supp | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/CMakePresets.json b/CMakePresets.json index 94a3861ed..b686f2c21 100644 --- a/CMakePresets.json +++ b/CMakePresets.json @@ -75,7 +75,7 @@ "cacheVariables": { "CMAKE_CXX_CPPCHECK": "cppcheck;--inline-suppr;--std=c++20;--enable=all;--suppressions-list=${sourceDir}/cppcheck.supp" } - }, + }, { "name": "clang-tidy", "hidden": true, diff --git a/cppcheck.supp b/cppcheck.supp index 108874758..a9aa14862 100644 --- a/cppcheck.supp +++ b/cppcheck.supp @@ -1,3 +1,5 @@ missingIncludeSystem noExplicitConstructor + +unknownMacro \ No newline at end of file From 25e418326e9b6bbe05f6e7d1cecdafb7ba48f3e6 Mon Sep 17 00:00:00 2001 From: "pre-commit-ci[bot]" <66853113+pre-commit-ci[bot]@users.noreply.github.com> Date: Mon, 7 Oct 2024 21:03:01 +0000 Subject: [PATCH 7/9] [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --- CMakePresets.json | 2 +- cppcheck.supp | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/CMakePresets.json b/CMakePresets.json index b686f2c21..94a3861ed 100644 --- a/CMakePresets.json +++ b/CMakePresets.json @@ -75,7 +75,7 @@ "cacheVariables": { "CMAKE_CXX_CPPCHECK": "cppcheck;--inline-suppr;--std=c++20;--enable=all;--suppressions-list=${sourceDir}/cppcheck.supp" } - }, + }, { "name": "clang-tidy", "hidden": true, diff --git a/cppcheck.supp b/cppcheck.supp index a9aa14862..e70020c6d 100644 --- a/cppcheck.supp +++ b/cppcheck.supp @@ -2,4 +2,4 @@ missingIncludeSystem noExplicitConstructor -unknownMacro \ No newline at end of file +unknownMacro From aa955b8faa0bf0c0ee6574bc9667ad44a0f3fd0a Mon Sep 17 00:00:00 2001 From: Aleksey Loginov Date: Tue, 8 Oct 2024 00:20:07 +0300 Subject: [PATCH 8/9] fix --- cppcheck.supp | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/cppcheck.supp b/cppcheck.supp index e70020c6d..43f309392 100644 --- a/cppcheck.supp +++ b/cppcheck.supp @@ -3,3 +3,9 @@ missingIncludeSystem noExplicitConstructor unknownMacro + +shadowFunction + +unusedVariable + +localMutex From e75e4e9152571a8fc1c643408f0dbef9b648f798 Mon Sep 17 00:00:00 2001 From: Aleksey Loginov Date: Tue, 8 Oct 2024 09:22:06 +0300 Subject: [PATCH 9/9] Update cppcheck.supp --- cppcheck.supp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/cppcheck.supp b/cppcheck.supp index 43f309392..0e4699980 100644 --- a/cppcheck.supp +++ b/cppcheck.supp @@ -9,3 +9,5 @@ shadowFunction unusedVariable localMutex + +unmatchedSuppression