PWGHF: Add Dplus selector and MC matching#5461
Merged
Merged
Conversation
1 task
vkucera
reviewed
Feb 18, 2021
vkucera
requested changes
Feb 26, 2021
vkucera
left a comment
vkucera
left a comment
Collaborator
There was a problem hiding this comment.
There is not much point polishing the selector now as it will need to be reworked soon with the 2D arrays and factorisation.
Please mention the MC matching in the PR title.
vkucera
reviewed
Feb 27, 2021
fcatalan92
changed the title
fcatalan92
force-pushed
the
dev_HF
branch
2 times, most recently
from
March 2, 2021 08:23
e294ecf to
7447340
Compare
Contributor
Author
|
@vkucera Please have another look, it should be ready to be merged now. |
vkucera
approved these changes
Mar 3, 2021
vkucera
left a comment
vkucera
left a comment
Collaborator
There was a problem hiding this comment.
Thanks @fcatalan92
@ginnocen Looks good to me.
fcatalan92
marked this pull request as ready for review
March 3, 2021 13:39
Contributor
Author
|
@vkucera Done! |
Collaborator
ginnocen
marked this pull request as draft
March 4, 2021 17:07
Contributor
|
done @vkucera |
vkucera
requested changes
Mar 4, 2021
vkucera
approved these changes
Mar 7, 2021
ginnocen
approved these changes
Mar 8, 2021
ginnocen
marked this pull request as ready for review
March 8, 2021 07:11
iarsene
approved these changes
Mar 8, 2021
EmilGorm
pushed a commit
to EmilGorm/AliceO2
that referenced
this pull request
Nov 22, 2021
* Implement Dplus to piKpi selector and add MC matching in task * Fix for PR 5566 * Address comment * Fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@ginnocen @vkucera @nzardosh This PR adds the Dplus selector and updates the Dplus task. I also added an additional variable.