diff --git a/Framework/Core/include/Framework/BinningPolicy.h b/Framework/Core/include/Framework/BinningPolicy.h index d4da8db8d627f..508c45786e68f 100644 --- a/Framework/Core/include/Framework/BinningPolicy.h +++ b/Framework/Core/include/Framework/BinningPolicy.h @@ -300,9 +300,6 @@ struct ColumnBinningPolicy : BinningPolicyBase { using persistent_columns_t = framework::selected_pack; }; -template -using BinningPolicy = ColumnBinningPolicy; - template struct NoBinningPolicy { // Just take the bin number from the column data diff --git a/Framework/Core/test/benchmark_EventMixing.cxx b/Framework/Core/test/benchmark_EventMixing.cxx index ddf6dbc20bdde..71f8d6ab2e0c7 100644 --- a/Framework/Core/test/benchmark_EventMixing.cxx +++ b/Framework/Core/test/benchmark_EventMixing.cxx @@ -48,7 +48,7 @@ static void BM_EventMixingTraditional(benchmark::State& state) std::vector xBins{VARIABLE_WIDTH, -0.064, -0.062, -0.060, 0.066, 0.068, 0.070, 0.072}; std::vector yBins{VARIABLE_WIDTH, -0.320, -0.301, -0.300, 0.330, 0.340, 0.350, 0.360}; - using BinningType = BinningPolicy; + using BinningType = ColumnBinningPolicy; BinningType binningOnPositions{{xBins, yBins}, true}; // true is for 'ignore overflows' (true by default) TableBuilder colBuilder, trackBuilder; @@ -135,7 +135,7 @@ static void BM_EventMixingCombinations(benchmark::State& state) std::vector xBins{VARIABLE_WIDTH, -0.064, -0.062, -0.060, 0.066, 0.068, 0.070, 0.072}; std::vector yBins{VARIABLE_WIDTH, -0.320, -0.301, -0.300, 0.330, 0.340, 0.350, 0.360}; - using BinningType = BinningPolicy; + using BinningType = ColumnBinningPolicy; BinningType binningOnPositions{{xBins, yBins}, true}; // true is for 'ignore overflows' (true by default) TableBuilder colBuilder, trackBuilder; diff --git a/Framework/Core/test/test_ASoAHelpers.cxx b/Framework/Core/test/test_ASoAHelpers.cxx index 1e4c963c44011..936f38ce248ad 100644 --- a/Framework/Core/test/test_ASoAHelpers.cxx +++ b/Framework/Core/test/test_ASoAHelpers.cxx @@ -133,7 +133,7 @@ BOOST_AUTO_TEST_CASE(CombinationsGeneratorConstruction) std::vector yBins{VARIABLE_WIDTH, 0, 5, 10, 20, 30, 40, 50, 101}; std::vector zBins{VARIABLE_WIDTH, -7.0, -5.0, -3.0, -1.0, 1.0, 3.0, 5.0, 7.0}; - BinningPolicy pairBinning{{yBins, zBins}, false}; + ColumnBinningPolicy pairBinning{{yBins, zBins}, false}; CombinationsGenerator>::CombinationsIterator combIt(CombinationsStrictlyUpperIndexPolicy(testsA, testsA)); BOOST_REQUIRE_NE(static_cast(std::get<0>(*(combIt))).getIterator().mCurrentPos, nullptr); @@ -293,8 +293,8 @@ BOOST_AUTO_TEST_CASE(CombinationsGeneratorConstruction) auto combBlock = combinations(CombinationsBlockStrictlyUpperSameIndexPolicy(pairBinning, 2, -1, testsA, testsA)); - static_assert(std::is_same_v, int32_t, TestA, TestA>>::CombinationsIterator>, "Wrong iterator type"); - static_assert(std::is_same_v, int32_t, TestA, TestA>::CombinationType&>, "Wrong combination type"); + static_assert(std::is_same_v, int32_t, TestA, TestA>>::CombinationsIterator>, "Wrong iterator type"); + static_assert(std::is_same_v, int32_t, TestA, TestA>::CombinationType&>, "Wrong combination type"); auto beginBlockCombination = *(combBlock.begin()); BOOST_REQUIRE_NE(static_cast(std::get<0>(beginBlockCombination)).getIterator().mCurrentPos, nullptr); @@ -948,8 +948,8 @@ BOOST_AUTO_TEST_CASE(BlockCombinations) std::vector yBins{VARIABLE_WIDTH, 0, 5, 10, 20, 30, 40, 50, 101}; std::vector zBins{VARIABLE_WIDTH, -7.0, -5.0, -3.0, -1.0, 1.0, 3.0, 5.0, 7.0}; - BinningPolicy pairBinning{{yBins, zBins}, false}; - BinningPolicy pairBinningNoOverflows{{yBins, zBins}, true}; + ColumnBinningPolicy pairBinning{{yBins, zBins}, false}; + ColumnBinningPolicy pairBinningNoOverflows{{yBins, zBins}, true}; // 2, 3, 5, 8, 9 have overflows in testA std::vector> expectedFullPairsNoOverflows{ @@ -1168,8 +1168,8 @@ BOOST_AUTO_TEST_CASE(BlockCombinations) // [3, 5] [0, 4], [7], [1, 6], [2], [8, 9] // Assuming bins intervals: [ , ) std::vector xBins{VARIABLE_WIDTH, 0, 7, 10}; - BinningPolicy tripleBinning{{xBins, yBins, zBins}, false}; - BinningPolicy tripleBinningNoOverflows{{xBins, yBins, zBins}, true}; + ColumnBinningPolicy tripleBinning{{xBins, yBins, zBins}, false}; + ColumnBinningPolicy tripleBinningNoOverflows{{xBins, yBins, zBins}, true}; // 2, 3, 5, 8, 9 have overflows in testA std::vector> expectedFullPairsTripleBinningNoOverflows{ @@ -1276,7 +1276,7 @@ BOOST_AUTO_TEST_CASE(CombinationsHelpers) std::vector yBins{VARIABLE_WIDTH, 0, 5, 10, 20, 30, 40, 50, 101}; std::vector zBins{VARIABLE_WIDTH, -7.0, -5.0, -3.0, -1.0, 1.0, 3.0, 5.0, 7.0}; - BinningPolicy pairBinning{{yBins, zBins}, false}; + ColumnBinningPolicy pairBinning{{yBins, zBins}, false}; std::vector> expectedStrictlyUpperPairs{ {0, 4}, {0, 7}, {4, 7}, {1, 6}, {3, 5}, {2, 8}, {2, 9}, {8, 9}};