PWGEM: Fix compilation warnings (#6783)

vkucera · alibuild · web-flow · commit e5c05be3c76a · 2024-07-09T16:23:30.000+02:00
* PWGEM: Fix compilation warnings * Please consider the following formatting changes (#93) --------- Co-authored-by: ALICE Builder <alibuild@users.noreply.github.com>
diff --git a/PWGEM/Dilepton/Core/PhotonHBT.h b/PWGEM/Dilepton/Core/PhotonHBT.h
@@ -219,7 +219,7 @@ struct PhotonHBT {
   std::vector<float> ep_bin_edges;
   std::vector<float> occ_bin_edges;
 
-  void init(InitContext& context)
+  void init(InitContext& /*context*/)
   {
     zvtx_bin_edges = std::vector<float>(ConfVtxBins.value.begin(), ConfVtxBins.value.end());
     zvtx_bin_edges.erase(zvtx_bin_edges.begin());
@@ -432,7 +432,7 @@ struct PhotonHBT {
   }
 
   template <int ev_id, typename TCollision>
-  void fillPairHistogram(TCollision const& collision, const ROOT::Math::PtEtaPhiMVector v1, const ROOT::Math::PtEtaPhiMVector v2, const float dca1, const float dca2)
+  void fillPairHistogram(TCollision const& /*collision*/, const ROOT::Math::PtEtaPhiMVector v1, const ROOT::Math::PtEtaPhiMVector v2, const float dca1, const float dca2)
   {
 
     //    if constexpr (ev_id == 1 && pairtype == PairType::kEEEE) {
diff --git a/PWGEM/Dilepton/TableProducer/createEMEventDilepton.cxx b/PWGEM/Dilepton/TableProducer/createEMEventDilepton.cxx
@@ -121,7 +121,7 @@ struct CreateEMEventDilepton {
   PresliceUnsorted<aod::EMPrimaryMuons> perCollision_mu = aod::emprimarymuon::collisionId;
 
   template <bool isMC, EMEventType eventype, typename TCollisions, typename TBCs>
-  void skimEvent(TCollisions const& collisions, TBCs const& bcs)
+  void skimEvent(TCollisions const& collisions, TBCs const&)
   {
     for (auto& collision : collisions) {
       if constexpr (isMC) {
diff --git a/PWGEM/Dilepton/TableProducer/skimmerPrimaryMuon.cxx b/PWGEM/Dilepton/TableProducer/skimmerPrimaryMuon.cxx
@@ -558,7 +558,7 @@ struct skimmerPrimaryMuon {
   Partition<MyTracksMC> global_muons_mc = o2::aod::fwdtrack::trackType == uint8_t(o2::aod::fwdtrack::ForwardTrackTypeEnum::GlobalMuonTrack); // MFT-MCH-MID
   Partition<MyTracksMC> sa_muons_mc = o2::aod::fwdtrack::trackType == uint8_t(o2::aod::fwdtrack::ForwardTrackTypeEnum::MuonStandaloneTrack); // MCH-MID
 
-  void processMC_SA(soa::Join<aod::McCollisionLabels, aod::Collisions, aod::EvSels> const& collisions, aod::BCsWithTimestamps const&, MyTracksMC const& tracks, MFTTracksMC const& mftsatracks)
+  void processMC_SA(soa::Join<aod::McCollisionLabels, aod::Collisions, aod::EvSels> const& collisions, aod::BCsWithTimestamps const&, MyTracksMC const& tracks, MFTTracksMC const&)
   {
     for (auto& collision : collisions) {
       if (!collision.has_mcCollision()) {
diff --git a/PWGEM/Dilepton/Tasks/dielectronQC.cxx b/PWGEM/Dilepton/Tasks/dielectronQC.cxx
@@ -259,7 +259,7 @@ struct dielectronQC {
   void addhistograms()
   {
     // event info
-    o2::aod::pwgem::dilepton::utils::eventhistogram::addEventHistograms(&fRegistry, cfgDo_v2 | cfgDo_v3);
+    o2::aod::pwgem::dilepton::utils::eventhistogram::addEventHistograms(&fRegistry, cfgDo_v2 || cfgDo_v3);
 
     // pair info
     const AxisSpec axis_mass{ConfMeeBins, "m_{ee} (GeV/c^{2})"};
@@ -589,11 +589,11 @@ struct dielectronQC {
         continue;
       }
 
-      o2::aod::pwgem::dilepton::utils::eventhistogram::fillEventInfo<0>(&fRegistry, collision, cfgDo_v2 | cfgDo_v3);
+      o2::aod::pwgem::dilepton::utils::eventhistogram::fillEventInfo<0>(&fRegistry, collision, cfgDo_v2 || cfgDo_v3);
       if (!fEMEventCut.IsSelected(collision)) {
         continue;
       }
-      o2::aod::pwgem::dilepton::utils::eventhistogram::fillEventInfo<1>(&fRegistry, collision, cfgDo_v2 | cfgDo_v3);
+      o2::aod::pwgem::dilepton::utils::eventhistogram::fillEventInfo<1>(&fRegistry, collision, cfgDo_v2 || cfgDo_v3);
       fRegistry.fill(HIST("Event/before/hCollisionCounter"), 10.0); // accepted
       fRegistry.fill(HIST("Event/after/hCollisionCounter"), 10.0);  // accepted
       std::array<float, 2> q2ft0m = {collision.q2xft0m(), collision.q2yft0m()};
diff --git a/PWGEM/Dilepton/Tasks/dimuonQC.cxx b/PWGEM/Dilepton/Tasks/dimuonQC.cxx
@@ -251,7 +251,7 @@ struct dimuonQC {
   void addhistograms()
   {
     // event info
-    o2::aod::pwgem::dilepton::utils::eventhistogram::addEventHistograms(&fRegistry, cfgDo_v2 | cfgDo_v3);
+    o2::aod::pwgem::dilepton::utils::eventhistogram::addEventHistograms(&fRegistry, cfgDo_v2 || cfgDo_v3);
 
     // pair info
     const AxisSpec axis_mass{ConfMmumuBins, "m_{#mu#mu} (GeV/c^{2})"};
@@ -509,11 +509,11 @@ struct dimuonQC {
         continue;
       }
 
-      o2::aod::pwgem::dilepton::utils::eventhistogram::fillEventInfo<0>(&fRegistry, collision, cfgDo_v2 | cfgDo_v3);
+      o2::aod::pwgem::dilepton::utils::eventhistogram::fillEventInfo<0>(&fRegistry, collision, cfgDo_v2 || cfgDo_v3);
       if (!fEMEventCut.IsSelected(collision)) {
         continue;
       }
-      o2::aod::pwgem::dilepton::utils::eventhistogram::fillEventInfo<1>(&fRegistry, collision, cfgDo_v2 | cfgDo_v3);
+      o2::aod::pwgem::dilepton::utils::eventhistogram::fillEventInfo<1>(&fRegistry, collision, cfgDo_v2 || cfgDo_v3);
       fRegistry.fill(HIST("Event/before/hCollisionCounter"), 10.0); // accepted
       fRegistry.fill(HIST("Event/after/hCollisionCounter"), 10.0);  // accepted
       std::array<float, 2> q2ft0m = {collision.q2xft0m(), collision.q2yft0m()};
diff --git a/PWGEM/Dilepton/Tasks/dimuonQCMC.cxx b/PWGEM/Dilepton/Tasks/dimuonQCMC.cxx
@@ -373,7 +373,7 @@ struct dimuonQCMC {
   }
 
   template <typename TCollision, typename TTrack1, typename TTrack2, typename TMCParticles>
-  bool fillTruePairInfo(TCollision const& collision, TTrack1 const& t1, TTrack2 const& t2, TMCParticles const& mcparticles)
+  bool fillTruePairInfo(TCollision const& /*collision*/, TTrack1 const& t1, TTrack2 const& t2, TMCParticles const& mcparticles)
   {
     if (!fDimuonCut.IsSelectedTrack(t1) || !fDimuonCut.IsSelectedTrack(t2)) {
       return false;
diff --git a/PWGEM/Dilepton/Tasks/tableReaderBarrel.cxx b/PWGEM/Dilepton/Tasks/tableReaderBarrel.cxx
@@ -812,7 +812,7 @@ struct AnalysisEventMixing {
 
   NoBinningPolicy<aod::dqanalysisflags::MixingHash> hashBin;
 
-  void init(o2::framework::InitContext& context)
+  void init(o2::framework::InitContext& /*context*/)
   {
     fCurrentRun = 0;
 
@@ -1051,7 +1051,7 @@ struct AnalysisSameEventPairing {
     }
   }
 
-  void init(o2::framework::InitContext& context)
+  void init(o2::framework::InitContext& /*context*/)
   {
     fCurrentRun = 0;
 
diff --git a/PWGEM/Dilepton/Utils/MomentumSmearer.h b/PWGEM/Dilepton/Utils/MomentumSmearer.h
@@ -47,7 +47,7 @@ class MomentumSmearer
   }
 
   /// Constructor with resolution histograms and efficiency
-  MomentumSmearer(TString resFileName, TString resPtHistName, TString resEtaHistName, TString resPhiPosHistName, TString resPhiNegHistName, TString effFileName, TString effHistName)
+  MomentumSmearer(TString resFileName, TString resPtHistName, TString resEtaHistName, TString resPhiPosHistName, TString resPhiNegHistName, TString /*effFileName*/, TString /*effHistName*/)
   {
     setResFileName(resFileName);
     setResPtHistName(resPtHistName);
diff --git a/PWGEM/PhotonMeson/Core/DalitzEECut.h b/PWGEM/PhotonMeson/Core/DalitzEECut.h
@@ -111,7 +111,7 @@ class DalitzEECut : public TNamed
   }
 
   template <bool isML = false, typename TTrack, typename TCollision = int>
-  bool IsSelectedTrack(TTrack const& track, TCollision const& collision = 0) const
+  bool IsSelectedTrack(TTrack const& track, TCollision const& = 0) const
   {
     if (!track.hasITS() || !track.hasTPC()) { // track has to be ITS-TPC matched track
       return false;
diff --git a/PWGEM/PhotonMeson/TableProducer/associateMCinfoPhoton.cxx b/PWGEM/PhotonMeson/TableProducer/associateMCinfoPhoton.cxx
@@ -107,7 +107,7 @@ struct AssociateMCInfoPhoton {
   std::vector<uint16_t> genEta;   // primary, pt, y
 
   template <uint8_t system, typename TTracks, typename TFwdTracks, typename TPCMs, typename TPCMLegs, typename TPHOSs, typename TEMCs, typename TEMPrimaryElectrons>
-  void skimmingMC(MyCollisionsMC const& collisions, aod::BCs const&, aod::McCollisions const&, aod::McParticles const& mcTracks, TTracks const& o2tracks, TFwdTracks const& o2fwdtracks, TPCMs const& v0photons, TPCMLegs const& /*v0legs*/, TPHOSs const& /*phosclusters*/, TEMCs const& emcclusters, TEMPrimaryElectrons const& emprimaryelectrons)
+  void skimmingMC(MyCollisionsMC const& collisions, aod::BCs const&, aod::McCollisions const&, aod::McParticles const& mcTracks, TTracks const& o2tracks, TFwdTracks const&, TPCMs const& v0photons, TPCMLegs const& /*v0legs*/, TPHOSs const& /*phosclusters*/, TEMCs const& emcclusters, TEMPrimaryElectrons const& emprimaryelectrons)
   {
     // temporary variables used for the indexing of the skimmed MC stack
     std::map<uint64_t, int> fNewLabels;
diff --git a/PWGEM/PhotonMeson/TableProducer/skimmerPrimaryElectronFromDalitzEE.cxx b/PWGEM/PhotonMeson/TableProducer/skimmerPrimaryElectronFromDalitzEE.cxx
@@ -153,7 +153,7 @@ struct skimmerPrimaryElectronFromDalitzEE {
   }
 
   template <bool isMC, typename TCollision, typename TTrack>
-  bool checkTrack(TCollision const& collision, TTrack const& track)
+  bool checkTrack(TCollision const&, TTrack const& track)
   {
     if constexpr (isMC) {
       if (!track.has_mcParticle()) {
diff --git a/PWGEM/PhotonMeson/Tasks/dalitzEEQC.cxx b/PWGEM/PhotonMeson/Tasks/dalitzEEQC.cxx
@@ -253,7 +253,7 @@ struct DalitzEEQC {
   }
 
   template <typename TCollision, typename TTrack1, typename TTrack2>
-  bool fillPairInfo(TCollision const& collision, TTrack1 const& t1, TTrack2 const& t2)
+  bool fillPairInfo(TCollision const&, TTrack1 const& t1, TTrack2 const& t2)
   {
     if (t1.trackId() == t2.trackId()) { // this is protection against pairing identical 2 tracks. This happens, when TTCA is used. TTCA can assign a track to several possible collisions.
       return false;
diff --git a/PWGEM/PhotonMeson/Tasks/dalitzEEQCMC.cxx b/PWGEM/PhotonMeson/Tasks/dalitzEEQCMC.cxx
@@ -308,7 +308,7 @@ struct DalitzEEQCMC {
   }
 
   template <typename TCollision, typename TTrack1, typename TTrack2, typename TMCParticles>
-  bool fillTruePairInfo(TCollision const& collision, TTrack1 const& t1, TTrack2 const& t2, TMCParticles const& mcparticles)
+  bool fillTruePairInfo(TCollision const&, TTrack1 const& t1, TTrack2 const& t2, TMCParticles const& mcparticles)
   {
     if (!fDileptonCut.IsSelectedTrack(t1) || !fDileptonCut.IsSelectedTrack(t2)) {
       return false;
diff --git a/PWGEM/PhotonMeson/Utils/NMHistograms.h b/PWGEM/PhotonMeson/Utils/NMHistograms.h
@@ -12,21 +12,21 @@
 /// \header file for histograms
 /// \author daiki.sekihata@cern.ch
 
+#ifndef PWGEM_PHOTONMESON_UTILS_NMHISTOGRAMS_H_
+#define PWGEM_PHOTONMESON_UTILS_NMHISTOGRAMS_H_
+
 #include <vector>
 #include "TF1.h"
 #include "PWGEM/PhotonMeson/Utils/PairUtilities.h"
 #include "PWGEM/PhotonMeson/Utils/MCUtilities.h"
 
-#ifndef PWGEM_PHOTONMESON_UTILS_NMHISTOGRAMS_H_
-#define PWGEM_PHOTONMESON_UTILS_NMHISTOGRAMS_H_
-
 using namespace o2::framework;
 // using namespace o2::aod::pwgem::photonmeson::photonpair;
 using namespace o2::aod::pwgem::photonmeson::utils::mcutil;
 
 namespace o2::aod::pwgem::photonmeson::utils::nmhistogram
 {
-void addNMHistograms(HistogramRegistry* fRegistry, bool isMC, const char* pairname = "#gamma#gamma", const char* epdetname = "")
+void addNMHistograms(HistogramRegistry* fRegistry, bool isMC, const char* pairname = "#gamma#gamma", const char* /*epdetname*/ = "")
 {
   // !!Don't change pt,eta,y binning. These binnings have to be consistent with binned data at skimming.!!
   std::vector<double> ptbins;
diff --git a/PWGEM/Tasks/phosNbar.cxx b/PWGEM/Tasks/phosNbar.cxx
@@ -984,7 +984,7 @@ struct phosNbar {
   PROCESS_SWITCH(phosNbar, processData, "process data", false);
 
   void processMC(SelCollisionMC const& coll,
-                 aod::BCsWithTimestamps const&, mcClusters const& clusters, mcTracks const& tracks, aod::McParticles const& mcPart, aod::McCollisions const& mcCol)
+                 aod::BCsWithTimestamps const&, mcClusters const& clusters, mcTracks const& tracks, aod::McParticles const& mcPart, aod::McCollisions const& /*mcCol*/)
   {
     // Initialize B-field
     if (mBz == 123456.) {
diff --git a/PWGEM/Tasks/phosPi0.cxx b/PWGEM/Tasks/phosPi0.cxx
@@ -236,7 +236,7 @@ struct phosPi0 {
   void processMC(SelCollisionsMC::iterator const& col,
                  mcClusters const& clusters,
                  aod::McParticles const& mcPart,
-                 aod::McCollisions const& mcCol)
+                 aod::McCollisions const& /*mcCol*/)
   {
     scanAll<true>(col, clusters, &mcPart);
   }

Original file line number	Diff line number	Diff line change
`@@ -219,7 +219,7 @@ struct PhotonHBT {`
`219`	`219`	`std::vector<float> ep_bin_edges;`
`220`	`220`	`std::vector<float> occ_bin_edges;`
`221`	`221`
`222`		`- void init(InitContext& context)`
	`222`	`+ void init(InitContext& /context/)`
`223`	`223`	`{`
`224`	`224`	`zvtx_bin_edges = std::vector<float>(ConfVtxBins.value.begin(), ConfVtxBins.value.end());`
`225`	`225`	`zvtx_bin_edges.erase(zvtx_bin_edges.begin());`
`@@ -432,7 +432,7 @@ struct PhotonHBT {`
`432`	`432`	`}`
`433`	`433`
`434`	`434`	`template <int ev_id, typename TCollision>`
`435`		`- void fillPairHistogram(TCollision const& collision, const ROOT::Math::PtEtaPhiMVector v1, const ROOT::Math::PtEtaPhiMVector v2, const float dca1, const float dca2)`
	`435`	`+ void fillPairHistogram(TCollision const& /collision/, const ROOT::Math::PtEtaPhiMVector v1, const ROOT::Math::PtEtaPhiMVector v2, const float dca1, const float dca2)`
`436`	`436`	`{`
`437`	`437`
`438`	`438`	`// if constexpr (ev_id == 1 && pairtype == PairType::kEEEE) {`
Original file line number	Diff line number	Diff line change
`@@ -121,7 +121,7 @@ struct CreateEMEventDilepton {`
`121`	`121`	`PresliceUnsorted<aod::EMPrimaryMuons> perCollision_mu = aod::emprimarymuon::collisionId;`
`122`	`122`
`123`	`123`	`template <bool isMC, EMEventType eventype, typename TCollisions, typename TBCs>`
`124`		`- void skimEvent(TCollisions const& collisions, TBCs const& bcs)`
	`124`	`+ void skimEvent(TCollisions const& collisions, TBCs const&)`
`125`	`125`	`{`
`126`	`126`	`for (auto& collision : collisions) {`
`127`	`127`	`if constexpr (isMC) {`
Original file line number	Diff line number	Diff line change
`@@ -558,7 +558,7 @@ struct skimmerPrimaryMuon {`
`558`	`558`	`Partition<MyTracksMC> global_muons_mc = o2::aod::fwdtrack::trackType == uint8_t(o2::aod::fwdtrack::ForwardTrackTypeEnum::GlobalMuonTrack); // MFT-MCH-MID`
`559`	`559`	`Partition<MyTracksMC> sa_muons_mc = o2::aod::fwdtrack::trackType == uint8_t(o2::aod::fwdtrack::ForwardTrackTypeEnum::MuonStandaloneTrack); // MCH-MID`
`560`	`560`
`561`		`- void processMC_SA(soa::Join<aod::McCollisionLabels, aod::Collisions, aod::EvSels> const& collisions, aod::BCsWithTimestamps const&, MyTracksMC const& tracks, MFTTracksMC const& mftsatracks)`
	`561`	`+ void processMC_SA(soa::Join<aod::McCollisionLabels, aod::Collisions, aod::EvSels> const& collisions, aod::BCsWithTimestamps const&, MyTracksMC const& tracks, MFTTracksMC const&)`
`562`	`562`	`{`
`563`	`563`	`for (auto& collision : collisions) {`
`564`	`564`	`if (!collision.has_mcCollision()) {`
Original file line number	Diff line number	Diff line change
`@@ -373,7 +373,7 @@ struct dimuonQCMC {`
`373`	`373`	`}`
`374`	`374`
`375`	`375`	`template <typename TCollision, typename TTrack1, typename TTrack2, typename TMCParticles>`
`376`		`- bool fillTruePairInfo(TCollision const& collision, TTrack1 const& t1, TTrack2 const& t2, TMCParticles const& mcparticles)`
	`376`	`+ bool fillTruePairInfo(TCollision const& /collision/, TTrack1 const& t1, TTrack2 const& t2, TMCParticles const& mcparticles)`
`377`	`377`	`{`
`378`	`378`	`if (!fDimuonCut.IsSelectedTrack(t1) \|\| !fDimuonCut.IsSelectedTrack(t2)) {`
`379`	`379`	`return false;`
Original file line number	Diff line number	Diff line change
`@@ -812,7 +812,7 @@ struct AnalysisEventMixing {`
`812`	`812`
`813`	`813`	`NoBinningPolicy<aod::dqanalysisflags::MixingHash> hashBin;`
`814`	`814`
`815`		`- void init(o2::framework::InitContext& context)`
	`815`	`+ void init(o2::framework::InitContext& /context/)`
`816`	`816`	`{`
`817`	`817`	`fCurrentRun = 0;`
`818`	`818`
`@@ -1051,7 +1051,7 @@ struct AnalysisSameEventPairing {`
`1051`	`1051`	`}`
`1052`	`1052`	`}`
`1053`	`1053`
`1054`		`- void init(o2::framework::InitContext& context)`
	`1054`	`+ void init(o2::framework::InitContext& /context/)`
`1055`	`1055`	`{`
`1056`	`1056`	`fCurrentRun = 0;`
`1057`	`1057`
Original file line number	Diff line number	Diff line change
`@@ -47,7 +47,7 @@ class MomentumSmearer`
`47`	`47`	`}`
`48`	`48`
`49`	`49`	`/// Constructor with resolution histograms and efficiency`
`50`		`- MomentumSmearer(TString resFileName, TString resPtHistName, TString resEtaHistName, TString resPhiPosHistName, TString resPhiNegHistName, TString effFileName, TString effHistName)`
	`50`	`+ MomentumSmearer(TString resFileName, TString resPtHistName, TString resEtaHistName, TString resPhiPosHistName, TString resPhiNegHistName, TString /effFileName/, TString /effHistName/)`
`51`	`51`	`{`
`52`	`52`	`setResFileName(resFileName);`
`53`	`53`	`setResPtHistName(resPtHistName);`
Original file line number	Diff line number	Diff line change
`@@ -111,7 +111,7 @@ class DalitzEECut : public TNamed`
`111`	`111`	`}`
`112`	`112`
`113`	`113`	`template <bool isML = false, typename TTrack, typename TCollision = int>`
`114`		`- bool IsSelectedTrack(TTrack const& track, TCollision const& collision = 0) const`
	`114`	`+ bool IsSelectedTrack(TTrack const& track, TCollision const& = 0) const`
`115`	`115`	`{`
`116`	`116`	`if (!track.hasITS() \|\| !track.hasTPC()) { // track has to be ITS-TPC matched track`
`117`	`117`	`return false;`
Original file line number	Diff line number	Diff line change
`@@ -107,7 +107,7 @@ struct AssociateMCInfoPhoton {`
`107`	`107`	`std::vector<uint16_t> genEta; // primary, pt, y`
`108`	`108`
`109`	`109`	`template <uint8_t system, typename TTracks, typename TFwdTracks, typename TPCMs, typename TPCMLegs, typename TPHOSs, typename TEMCs, typename TEMPrimaryElectrons>`
`110`		`- void skimmingMC(MyCollisionsMC const& collisions, aod::BCs const&, aod::McCollisions const&, aod::McParticles const& mcTracks, TTracks const& o2tracks, TFwdTracks const& o2fwdtracks, TPCMs const& v0photons, TPCMLegs const& /v0legs/, TPHOSs const& /phosclusters/, TEMCs const& emcclusters, TEMPrimaryElectrons const& emprimaryelectrons)`
	`110`	`+ void skimmingMC(MyCollisionsMC const& collisions, aod::BCs const&, aod::McCollisions const&, aod::McParticles const& mcTracks, TTracks const& o2tracks, TFwdTracks const&, TPCMs const& v0photons, TPCMLegs const& /v0legs/, TPHOSs const& /phosclusters/, TEMCs const& emcclusters, TEMPrimaryElectrons const& emprimaryelectrons)`
`111`	`111`	`{`
`112`	`112`	`// temporary variables used for the indexing of the skimmed MC stack`
`113`	`113`	`std::map<uint64_t, int> fNewLabels;`