Skip to content

[EMCAL-734][EMCAL-689] implemented track matching and connection between cell and cluster#1079

Merged
iarsene merged 4 commits into
AliceO2Group:masterfrom
fjonasALICE:EMCAL-734
Aug 1, 2022
Merged

[EMCAL-734][EMCAL-689] implemented track matching and connection between cell and cluster#1079
iarsene merged 4 commits into
AliceO2Group:masterfrom
fjonasALICE:EMCAL-734

Conversation

@fjonasALICE

@fjonasALICE fjonasALICE commented Jul 29, 2022

Copy link
Copy Markdown
Collaborator

The following things changed:

  • adaptation of cluster definition and corresponding filter. From now on the integer hast to be used to filter, since runtime changes to the filter when using a string as a configurable are not supported by framework. The correction framework and task have to now be run like this for example:
    o2-analysis-je-emcal-correction-task --clusterDefinition "kV3Default" \ | o2-analysis-je-emc-clustermonitor --clusterDefinition 10
  • implemeted cluster to track matching by adapting the jetmatching algorithm using a KDTree. This has the advantage of improved performance for Run3 with O(n log(n)). The algorithm is adapted to contain not only the closest match but the K closest matches to a cluster within a specified radius. At the same time K closest clusters for each track are also found (can be used by electron group). Added tables accordingly that contain the matching relations. Open todo: so far the track eta and phi is used. Once the propagated tracks to emcal surface are provided, this will be adapted. After this is done, performance can be further improved by only doing matching for tracks that point to emcal surface.
  • implemented table that allows to retreive information about each cell in a cluster, linken the calo table in AO2D

@fjonasALICE fjonasALICE requested review from a team, alibuild, iarsene, jgrosseo and ktf as code owners July 29, 2022 09:55
@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/o2 for 0b365fe at 2022-07-29 12:22:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/1079-slc7_x86-64/0/PWGJE/Tasks/emcclustermonitor.cxx:214:26: error: variable 'dR' set but not used [-Werror=unused-but-set-variable]
/sw/SOURCES/O2Physics/1079-slc7_x86-64/0/PWGJE/TableProducer/emcalCorrectionTask.cxx:291:41: error: comparison of integer expressions of different signedness: 'int' and 'std::vector<int>::size_type' {aka 'long unsigned int'} [-Werror=sign-compare]
/sw/SOURCES/O2Physics/1079-slc7_x86-64/0/PWGJE/TableProducer/emcalCorrectionTask.cxx:264:17: error: unused variable 'cellampfraction' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/1079-slc7_x86-64/0/PWGJE/TableProducer/emcalCorrectionTask.cxx:309:15: error: variable 'cellampfraction' set but not used [-Werror=unused-but-set-variable]
ninja: build stopped: subcommand failed.

Full log here.

@iarsene iarsene merged commit 3242656 into AliceO2Group:master Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants