[PWGHF] UPC utils: Make SGSelector parameters configurable#14923
Merged
Conversation
Rrantu
commented
Feb 11, 2026
Rrantu
commented
Contributor
- The default values of NDtColl, MinNBCs, MinNTracks and MaxNTracksFix in utilsUpcHf.h were not optimal and have been changed to Configurable parameters.
- Reduced the number of bins in the UPC QA histograms in taskLc.cxx to optimize memory usage.
Rrantu
requested review from
NicoleBastid,
alibuild,
apalasciano,
deepathoms,
fcatalan92,
fcolamar,
fgrosa,
gluparel,
hahassan7,
jpxrk,
mfaggin,
mmazzilli,
singhra1994,
stefanopolitano,
vkucera and
zhangbiao-phy
as code owners
February 11, 2026 17:22
github-actions
Bot
changed the title
vkucera
marked this pull request as draft
February 11, 2026 17:25
Collaborator
|
Hi @Rrantu , when these parameters were being added, my understanding was that these were already optimised constants taken from the UD. Can you please explain the motivation of your PR? |
Rrantu
changed the title
Contributor
Author
Hi @vkucera, the original default values were not fully consistent with the UD configurations. I have now made these parameters configurable based on the settings used in the UD analysis. |
Rrantu
marked this pull request as ready for review
February 11, 2026 17:58
vkucera
requested changes
Feb 11, 2026
vkucera
requested changes
Feb 11, 2026
vkucera
marked this pull request as draft
February 11, 2026 18:45
Rrantu
marked this pull request as ready for review
February 11, 2026 19:30
vkucera
marked this pull request as draft
February 11, 2026 19:53
Rrantu
marked this pull request as ready for review
February 11, 2026 20:21
vkucera
reviewed
Feb 12, 2026
vkucera
changed the title
vkucera
approved these changes
Feb 13, 2026
Collaborator
|
Looks good to me. |
Collaborator
|
Thanks @Rrantu ! |
feisenhu
pushed a commit
to feisenhu/O2Physics
that referenced
this pull request
Feb 16, 2026
comrademarvin
pushed a commit
to comrademarvin/O2Physics
that referenced
this pull request
Mar 16, 2026
hyungjun-lee
pushed a commit
to hyungjun-lee/O2Physics
that referenced
this pull request
Apr 15, 2026
mtorresc15
pushed a commit
to mtorresc15/O2Physics
that referenced
this pull request
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.