Skip to content

[PWGHF,PWGJE] Add variables to derivedDataCreatorBplusToD0Pi.cxx#15349

Merged
vkucera merged 5 commits into
AliceO2Group:masterfrom
atavirag:add-vars-bplus
Mar 19, 2026
Merged

[PWGHF,PWGJE] Add variables to derivedDataCreatorBplusToD0Pi.cxx#15349
vkucera merged 5 commits into
AliceO2Group:masterfrom
atavirag:add-vars-bplus

Conversation

@atavirag

@atavirag atavirag commented Mar 11, 2026

Copy link
Copy Markdown
Contributor

The purpose of this PR is to add extra variables needed to study the viability of using GNNs for HF selection.

Tagging @deepathoms @alphaflores

@alibuild alibuild mentioned this pull request Mar 11, 2026
Merged
@atavirag
Merge pull request #3 from alibuild/alibot-cleanup-15349
993ab36 
Please consider the following formatting changes to AliceO2Group#15349
@atavirag
atavirag marked this pull request as ready for review March 12, 2026 09:45
@alibuild

alibuild commented Mar 12, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/o2 for 993ab36 at 2026-03-12 12:25:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/15349-slc9_x86-64/0/PWGHF/TableProducer/derivedDataCreatorBplusToD0Pi.cxx:208:13: error: 'invMassD0' may be used uninitialized [-Werror=maybe-uninitialized]
/sw/SOURCES/O2Physics/15349-slc9_x86-64/0/PWGHF/TableProducer/derivedDataCreatorBplusToD0Pi.cxx:208:13: error: 'invMassD0' may be used uninitialized [-Werror=maybe-uninitialized]
/sw/SOURCES/O2Physics/15349-slc9_x86-64/0/PWGHF/TableProducer/derivedDataCreatorBplusToD0Pi.cxx:208:13: error: 'invMassD0' may be used uninitialized [-Werror=maybe-uninitialized]
/sw/SOURCES/O2Physics/15349-slc9_x86-64/0/PWGHF/TableProducer/derivedDataCreatorBplusToD0Pi.cxx:208:13: error: 'invMassD0' may be used uninitialized [-Werror=maybe-uninitialized]
ninja: build stopped: subcommand failed.

Full log here.

@vkucera
vkucera marked this pull request as draft March 12, 2026 12:04
@vkucera
vkucera marked this pull request as ready for review March 13, 2026 13:49
@alibuild

alibuild commented Mar 13, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/o2 for 1e12da9 at 2026-03-13 17:21:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/15349-slc9_x86-64/0/PWGJE/Core/JetHFUtilities.h:1358:17: error: no match for call to '(o2::framework::Produces<o2::soa::Table<o2::aod::Hash<703906712>, o2::aod::Hash<3247407173>, o2::aod::Hash<3168903298> > >) (const float&, const float&, const float&, const float&, const float&, const float&, const float&, const float&, const float&, const float&, const float&, const float&, const float&)'
/sw/SOURCES/O2Physics/15349-slc9_x86-64/0/PWGJE/Core/JetHFUtilities.h:1373:18: error: no match for call to '(o2::framework::Produces<o2::soa::Table<o2::aod::Hash<1063605839>, o2::aod::Hash<2419091464>, o2::aod::Hash<3168903298> > >) (const float&, const float&, const float&, const float&, const float&, const float&, const float&, const float&, const float&, const float&, const float&, const float&, const float&, const float&, const float&, const float&, const float&)'
/sw/SOURCES/O2Physics/15349-slc9_x86-64/0/PWGJE/Core/JetHFUtilities.h:1358:17: error: no match for call to '(o2::framework::Produces<o2::soa::Table<o2::aod::Hash<703906712>, o2::aod::Hash<3247407173>, o2::aod::Hash<3168903298> > >) (const float&, const float&, const float&, const float&, const float&, const float&, const float&, const float&, const float&, const float&, const float&, const float&, const float&)'
/sw/SOURCES/O2Physics/15349-slc9_x86-64/0/PWGJE/Core/JetHFUtilities.h:1373:18: error: no match for call to '(o2::framework::Produces<o2::soa::Table<o2::aod::Hash<1063605839>, o2::aod::Hash<2419091464>, o2::aod::Hash<3168903298> > >) (const float&, const float&, const float&, const float&, const float&, const float&, const float&, const float&, const float&, const float&, const float&, const float&, const float&, const float&, const float&, const float&, const float&)'
ninja: build stopped: subcommand failed.

Full log here.

@vkucera
vkucera marked this pull request as draft March 13, 2026 16:27
@vkucera

vkucera commented Mar 13, 2026

Copy link
Copy Markdown
Collaborator

@atavirag Did you compile the changes?

@atavirag

atavirag commented Mar 16, 2026

Copy link
Copy Markdown
Contributor Author

Hi @vkucera, I did, but I did not get these errors locally:
output.log

@vkucera

vkucera commented Mar 16, 2026

Copy link
Copy Markdown
Collaborator

Hi @vkucera, I did, but I did not get these errors locally: output.log

The log comes from a recompilation of PWGHF. There are no mentions of recompiling PWGJE.

@github-actions github-actions Bot added the pwgje label Mar 18, 2026
@atavirag atavirag changed the title [PWGHF] Add variables to derivedDataCreatorBplusToD0Pi.cxx [PWGHF, PWGJE] Add variables to derivedDataCreatorBplusToD0Pi.cxx Mar 19, 2026
@github-actions github-actions Bot changed the title [PWGHF, PWGJE] Add variables to derivedDataCreatorBplusToD0Pi.cxx [PWGHF,PWGJE] Add variables to derivedDataCreatorBplusToD0Pi.cxx Mar 19, 2026
@atavirag
atavirag marked this pull request as ready for review March 19, 2026 14:48
nzardosh
nzardosh reviewed Mar 19, 2026
View reviewed changes
Comment thread PWGHF/TableProducer/derivedDataCreatorBplusToD0Pi.cxx
candidate.pxProng1(),
candidate.pyProng1(),
candidate.pzProng1(),
RecoDecay::p(candidate.pxProng0(), candidate.pyProng0(), candidate.pzProng0()),

@nzardosh nzardosh Mar 19, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do you not store this instead as a dynamic coloumn?

@vkucera vkucera Mar 19, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a derived table.

@nzardosh
nzardosh self-requested a review March 19, 2026 16:06
@vkucera
vkucera merged commit 9901618 into AliceO2Group:master Mar 19, 2026
16 of 17 checks passed
scannito pushed a commit to scannito/O2Physics that referenced this pull request Mar 20, 2026
@atavirag @alibuild @scannito
[PWGHF,PWGJE] Add variables to derivedDataCreatorBplusToD0Pi.cxx (Ali…
36985c7 
…ceO2Group#15349)

Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
hyungjun-lee pushed a commit to hyungjun-lee/O2Physics that referenced this pull request Apr 15, 2026
@atavirag @alibuild @hyungjun-lee
[PWGHF,PWGJE] Add variables to derivedDataCreatorBplusToD0Pi.cxx (Ali…
6a5b140 
…ceO2Group#15349)

Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
smaff92 pushed a commit to smaff92/O2Physics that referenced this pull request Apr 27, 2026
@atavirag @alibuild @smaff92
[PWGHF,PWGJE] Add variables to derivedDataCreatorBplusToD0Pi.cxx (Ali…
53802b3 
…ceO2Group#15349)

Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
mtorresc15 pushed a commit to mtorresc15/O2Physics that referenced this pull request May 5, 2026
@atavirag @alibuild @mtorresc15
[PWGHF,PWGJE] Add variables to derivedDataCreatorBplusToD0Pi.cxx (Ali…
61fff98 
…ceO2Group#15349)

Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vkucera vkucera vkucera approved these changes
@nzardosh nzardosh nzardosh approved these changes
@alibuild alibuild Awaiting requested review from alibuild alibuild is a code owner
@fcolamar fcolamar Awaiting requested review from fcolamar fcolamar is a code owner
@fgrosa fgrosa Awaiting requested review from fgrosa fgrosa is a code owner
@fcatalan92 fcatalan92 Awaiting requested review from fcatalan92 fcatalan92 is a code owner
@mfaggin mfaggin Awaiting requested review from mfaggin mfaggin is a code owner
@mmazzilli mmazzilli Awaiting requested review from mmazzilli mmazzilli is a code owner
@deepathoms deepathoms Awaiting requested review from deepathoms deepathoms is a code owner
@NicoleBastid NicoleBastid Awaiting requested review from NicoleBastid NicoleBastid is a code owner
@hahassan7 hahassan7 Awaiting requested review from hahassan7 hahassan7 is a code owner
@jpxrk jpxrk Awaiting requested review from jpxrk jpxrk is a code owner
@apalasciano apalasciano Awaiting requested review from apalasciano apalasciano is a code owner
@zhangbiao-phy zhangbiao-phy Awaiting requested review from zhangbiao-phy zhangbiao-phy is a code owner
@gluparel gluparel Awaiting requested review from gluparel gluparel is a code owner
@stefanopolitano stefanopolitano Awaiting requested review from stefanopolitano stefanopolitano is a code owner
@singhra1994 singhra1994 Awaiting requested review from singhra1994 singhra1994 is a code owner
@maoyx maoyx Awaiting requested review from maoyx
@raymondEhlers raymondEhlers Awaiting requested review from raymondEhlers
@fjonasALICE fjonasALICE Awaiting requested review from fjonasALICE fjonasALICE is a code owner
@mfasDa mfasDa Awaiting requested review from mfasDa
@mhemmer-cern mhemmer-cern Awaiting requested review from mhemmer-cern mhemmer-cern is a code owner

Assignees

No one assigned

Labels

datamodel pwghf PWG-HF pwgje

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@atavirag @alibuild @vkucera @nzardosh