PWGHF: Adding process functions for linearly-selected D+ and Ds#4332
Merged
Conversation
stefanopolitano
requested review from
NicoleBastid,
alibuild,
deepathoms,
fcatalan92,
fcolamar,
fgrosa,
mfaggin,
mmazzilli,
nzardosh and
vkucera
as code owners
January 16, 2024 13:53
stefanopolitano
added a commit
to stefanopolitano/O2Physics
that referenced
this pull request
Jan 16, 2024
Please consider the following formatting changes to AliceO2Group#4332
fgrosa
requested changes
Jan 16, 2024
fgrosa
left a comment
fgrosa
left a comment
Collaborator
There was a problem hiding this comment.
Hi @stefanopolitano, thanks! I have only few comments, then we can merge it
Comment on lines
+200
to
+204
| if (storeMl) { | ||
| registry.fill(HIST("hSparseFlowCharm"), mass, pt, cent, cosNPhi, cosDeltaPhi, sp, outputMl[0], outputMl[1]); | ||
| } else { | ||
| registry.fill(HIST("hSparseFlowCharm"), mass, pt, cent, cosNPhi, cosDeltaPhi, sp); | ||
| } |
Collaborator
There was a problem hiding this comment.
I would pass these values by reference in the function, so that no copy is created in memory
fcatalan92
previously approved these changes
Jan 16, 2024
stefanopolitano
requested review from
BongHwi,
ChiaraDeMartin95,
aalkin,
aortizve,
chiarapinto,
dsekihat,
feisenhu,
fmazzasc,
iarsene,
ivorobye,
mbombara,
mikesas,
njacazio,
pbuehler,
rbailhac and
skundu692
as code owners
January 17, 2024 13:40
stefanopolitano
requested review from
jgrosseo,
lucamicheletti93,
mpuccio,
saganatt,
strogolo,
victor-gonzalez,
zchochul and
zhangbiao-phy
as code owners
January 17, 2024 13:40
stefanopolitano
force-pushed
the
dev_spolitan_flow
branch
from
January 17, 2024 13:42
dc2cf4e to
f5e1628
Compare
fgrosa
approved these changes
Jan 17, 2024
fgrosa
enabled auto-merge (squash)
January 17, 2024 13:44
hahassan7
pushed a commit
to hahassan7/O2Physics
that referenced
this pull request
Feb 1, 2024
basiach
pushed a commit
to basiach/O2Physics
that referenced
this pull request
Feb 23, 2024
ercolessi
pushed a commit
to ercolessi/O2Physics
that referenced
this pull request
Feb 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains: