-
Notifications
You must be signed in to change notification settings - Fork 1
Expand file tree
/
Copy pathTODO
More file actions
80 lines (77 loc) · 4.37 KB
/
TODO
File metadata and controls
80 lines (77 loc) · 4.37 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
## Beta-Test Edits
- [ ] Resolve uncertainty metadata requirement (re-visit validation logic in `validate_parameters.py` regarding `uncertainty_method`)
- [x] `remove_event()` function (and CLI)
- [x] `remove_solution()` function (and CLI)
- [x] Window 11 text editior
- [x] Quickstart/tutorial:
- [x] cd to project directory
or
- [x] init without name inside the existing project folder
and
- [x] must include repo
and
- [x] must include hardware info
or
- [x] nexus init
- [x] required venv with windows (huh? who uses windows anyway?)
- [x] export location-of-script to PATH
Some of my beta testers where having issues with the PyPI release on widows. Fuck windows, but I guesss we should try to fix it. The issue they were having was that "the scripts weren't being added to their path unless the used a venv". Is this a them problem, like they are just setting up their python wrong, or is this an us problem?
- [x] add GPU section to hardware info
- [x] auto populate hardware info
- [x] ".001" gets interpreted as a string
- [x] nexus init gives hardware warning and it doesn't need to
- [x] nexus dosiers (with submission in /teams/*) not displaying images (problem in AAS workshop notebooks)
- [x] "Experienced' tier not "Advanced"
- [x] validate physical parameters
- [x] "piEN (instead of piEN)" when piEN was missing
- [x] additional model types
- [x] git and submission in different locations (add git_dir)
- [x] Windows build in workflow
- [x] Release Workflow
- [x] Wheel build CI
- [x] Unhelpful error when band not supoplied but a flux value is
- [x] What the fuck do we do about uncertainties?
- meta data and the same single value or paired values options
## Conda Forge
- [x] Windows installer isn't made?
- [x] Workflow to update version in recipe and sync feedstock
- [ ] related to do's from other projects:
- [ ] MulensModel feedstock
- [ ] VBMicrolensing feedstock
## v1.0.0 debug
- [x] undo image bug fuck up
- [x] fix image asset bug in dossiers
- [x] add `data_challenge_0_129_335` to `test` tier allowed event list
- [x] "Invalid parameter 'F0_S' for model type '1S1L'; Invalid parameter 'F0_B' for model type '1S1L'"
- [x] need a more graceful resolution to alias duplicates
> ⚠️ Save completed with validation warnings:
> Event 'data_challenge_0_129_335' is not valid for tier 'test' (Testing tier for development). Valid events for this tier: ['EVENT001', 'EVENT002', 'EVENT003', 'EVENT004', 'EVENT005', 'EVENT006', 'EVENT007', 'evt', 'test-event']
> Duplicate alias 'Preliminary PSPL - Band 0' found in event 'data_challenge_0_129_335'. Alias must be unique within each event.
> 💡 Fix validation errors before exporting for submission
> 💾 Submission saved locally (incomplete - not ready for submission)
> ❌ Save failed due to alias validation errors:
> Duplicate alias 'Preliminary PSPL - Band 0' found in event 'data_challenge_0_129_335'. Alias must be unique within each event.
> 💡 Solutions with duplicate aliases remain in memory but are not saved
> Use different aliases or remove aliases to resolve conflicts
> ---------------------------------------------------------------------------
> ValueError Traceback (most recent call last)
> Cell In[14], line 33
> 16 solution.set_notes(f"""
> 17 # Preliminary Fit Analysis
> 18
> (...) 29 This solution is marked as inactive as it represents a preliminary analysis.
> 30 """)
> 32 # Save everything
> ---> 33 submission.save()
> 35 print(f"✅ Solution '{solution.alias}' ({solution.solution_id}) created and saved!")
> 36 print(f" - Posteriors saved to: {posterior_path}")
>
> File /opt/conda/envs/rges-pit-dc/lib/python3.11/site-packages/microlens_submit/models/submission.py:428, in Submission.save(self, force)
> 426 print(f"{symbol('hint')} Solutions with duplicate aliases remain in memory but are not saved")
> 427 print(" Use different aliases or remove aliases to resolve conflicts")
> --> 428 raise ValueError("Alias validation failed:\n" + "\n".join(alias_errors))
> 430 unsaved_count = sum(1 for event in self.events.values() for sol in event.solutions.values() if not sol.saved)
> 431 project = Path(self.project_path)
>
> ValueError: Alias validation failed:
> Duplicate alias 'Preliminary PSPL - Band 0' found in event 'data_challenge_0_129_335'. Alias must be unique within each event.