Skip to content

Compose Multiplatform First Step - #47

Merged
283375 merged 21 commits into
masterfrom
feat/cmp-first-step
Jul 1, 2026
Merged

Compose Multiplatform First Step#47
283375 merged 21 commits into
masterfrom
feat/cmp-first-step

Conversation

@283375

@283375 283375 commented Jul 1, 2026

Copy link
Copy Markdown
Collaborator
  • Basic working proof-of-concept of multiplatform shared logics, UI, and tests
  • Adjust CI

@283375

283375 commented Jul 1, 2026

Copy link
Copy Markdown
Collaborator Author

/opencode /review pr

@opencode-agent

opencode-agent Bot commented Jul 1, 2026

Copy link
Copy Markdown

Approve — this is a clean, well-tested first step toward multiplatform. The architecture is sound and the new components have solid test coverage. The three suggestions above are minor and non-blocking.

New%20session%20-%202026-07-01T19%3A51%3A22.121Z
opencode session  |  github run

@283375

283375 commented Jul 1, 2026

Copy link
Copy Markdown
Collaborator Author

/opencode

@opencode-agent

opencode-agent Bot commented Jul 1, 2026

Copy link
Copy Markdown

PR Summary: Compose Multiplatform First Step

This PR introduces Kotlin Multiplatform (KMP) support to the project, moving core logic, UI components, and theming into a shared multiplatform module. It's an approved, well-tested proof-of-concept with:

  • New shared/ module with commonMain, androidMain, jvmMain, and test sources containing ported models, calculators, UI components (e.g., DecimalStepperTextField, AutoRepeatController), and theming
  • New desktopApp/ module as a desktop-proof-of-concept entry point
  • CI adjustments — updated workflows (check.yml, build_unstable.yml, connected-android-test.yml) and a new test script
  • Code migration — renamed/moved files from app/ and core/ into shared/, updated imports; removed obsolete tests
  • i18n — added strings.xml for English and Chinese (values-zh-rCN)
  • 21 commits, 48 files changed (+1768 / -429), state: open, base: master

The review comment marked it as approved with only minor, non-blocking suggestions.

New%20session%20-%202026-07-01T23%3A37%3A20.590Z
opencode session  |  github run

@283375
283375 merged commit 222b0d8 into master Jul 1, 2026
4 checks passed
@283375
283375 deleted the feat/cmp-first-step branch July 1, 2026 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant