feat: check for updates last and improve update prompt styling (VeryGoodOpenSource#207)

Author: felangel

lib/src/command_runner.dart

@@ -95,28 +95,37 @@ class VeryGoodCommandRunner extends CommandRunner<int> {
 
   @override
   Future<int?> runCommand(ArgResults topLevelResults) async {
-    await _checkForUpdates();
+    int? exitCode = ExitCode.unavailable.code;
     if (topLevelResults['version'] == true) {
       _logger.info('very_good version: $packageVersion');
-      return ExitCode.success.code;
-    }
-    if (topLevelResults['analytics'] != null) {
+      exitCode = ExitCode.success.code;
+    } else if (topLevelResults['analytics'] != null) {
       final optIn = topLevelResults['analytics'] == 'true';
       _analytics.enabled = optIn;
       _logger.info('analytics ${_analytics.enabled ? 'enabled' : 'disabled'}.');
-      return ExitCode.success.code;
+      exitCode = ExitCode.success.code;
+    } else {
+      exitCode = await super.runCommand(topLevelResults);
     }
-    return super.runCommand(topLevelResults);
+    await _checkForUpdates();
+    return exitCode;
   }
 
   Future<void> _checkForUpdates() async {
     try {
       final latestVersion = await _pubUpdater.getLatestVersion(packageName);
       final isUpToDate = packageVersion == latestVersion;
       if (!isUpToDate) {
-        _logger.info(
-          '''${lightYellow.wrap('A new version of $packageName is available:')} ${lightCyan.wrap(packageVersion)} -> ${lightCyan.wrap(latestVersion)}''',
-        );
+        _logger
+          ..info('')
+          ..info('''
++------------------------------------------------------------------------------------+
+|                                                                                    |
+|                     ${lightYellow.wrap('Update available!')} ${lightCyan.wrap(packageVersion)} \u2192 ${lightCyan.wrap(latestVersion)}                                |
+| ${lightYellow.wrap('Changelog:')} ${lightCyan.wrap('https://github.com/verygoodopensource/very_good_cli/releases/tag/v$latestVersion')} |
+|                                                                                    |
++------------------------------------------------------------------------------------+
+''');
         final response = _logger.prompt('Would you like to update? (y/n) ');
         if (response.isYes()) {
           final done = _logger.progress('Updating to $latestVersion');

pubspec.yaml

@@ -12,7 +12,7 @@ dependencies:
   mason: ^0.0.1-dev.51
   meta: ^1.3.0
   path: ^1.8.0
-  pub_updater: ^0.2.0
+  pub_updater: ^0.2.1
   universal_io: ^2.0.4
   usage: ^4.0.2
   very_good_analysis: ^2.3.0

test/src/command_runner_test.dart

@@ -108,7 +108,14 @@ void main() {
         expect(result, equals(ExitCode.success.code));
         verify(
           () => logger.info(
-            '''${lightYellow.wrap('A new version of $packageName is available:')} ${lightCyan.wrap(packageVersion)} -> ${lightCyan.wrap(latestVersion)}''',
+            '''
++------------------------------------------------------------------------------------+
+|                                                                                    |
+|                     ${lightYellow.wrap('Update available!')} ${lightCyan.wrap(packageVersion)} \u2192 ${lightCyan.wrap(latestVersion)}                                |
+| ${lightYellow.wrap('Changelog:')} ${lightCyan.wrap('https://github.com/verygoodopensource/very_good_cli/releases/tag/v$latestVersion')} |
+|                                                                                    |
++------------------------------------------------------------------------------------+
+''',
           ),
         ).called(1);
         verify(