fix: packages get --recursive run sequentially (VeryGoodOpenSource#211)

Author: felangel

lib/src/cli/flutter_cli.dart

@@ -20,13 +20,26 @@ class Flutter {
   static Future<void> packagesGet({
     String cwd = '.',
     bool recursive = false,
+    void Function([String?]) Function(String message)? progress,
   }) async {
     await _installPackages(
-      cmd: (cwd) => _Cmd.run(
-        'flutter',
-        ['packages', 'get'],
-        workingDirectory: cwd,
-      ),
+      cmd: (cwd) async {
+        final installDone = progress?.call(
+          'Running "flutter packages get" in $cwd',
+        );
+        try {
+          final result = await _Cmd.run(
+            'flutter',
+            ['packages', 'get'],
+            workingDirectory: cwd,
+          );
+          return result;
+        } catch (_) {
+          rethrow;
+        } finally {
+          installDone?.call();
+        }
+      },
       cwd: cwd,
       recursive: recursive,
     );
@@ -70,6 +83,8 @@ class Flutter {
 
     if (processes.isEmpty) throw PubspecNotFound();
 
-    await Future.wait(processes);
+    for (final process in processes) {
+      await process;
+    }
   }
 }

lib/src/commands/packages.dart

@@ -62,18 +62,16 @@ class PackagesGetCommand extends Command<int> {
     final targetPath = path.normalize(Directory(target).absolute.path);
     final isFlutterInstalled = await Flutter.installed();
     if (isFlutterInstalled) {
-      final installDependenciesDone = _logger.progress(
-        'Running "flutter packages get" in $targetPath',
-      );
       try {
-        await Flutter.packagesGet(cwd: targetPath, recursive: recursive);
-        installDependenciesDone();
+        await Flutter.packagesGet(
+          cwd: targetPath,
+          recursive: recursive,
+          progress: _logger.progress,
+        );
       } on PubspecNotFound catch (_) {
-        installDependenciesDone();
         _logger.err('Could not find a pubspec.yaml in $targetPath');
         return ExitCode.noInput.code;
       } catch (error) {
-        installDependenciesDone();
         _logger.err('$error');
         return ExitCode.unavailable.code;
       }

test/src/commands/packages_test.dart

@@ -181,7 +181,7 @@ void main() {
           logger.progress(
             any(that: contains('Running "flutter packages get" in')),
           );
-        }).called(1);
+        }).called(2);
       });
     });
   });