Skip to content

Commit dadeb76

Browse files
committed
change type for ext to int8_t
1 parent b7243a0 commit dadeb76

File tree

2 files changed

+14
-20
lines changed

2 files changed

+14
-20
lines changed

include/mruby/msgpack.h

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -13,13 +13,13 @@ MRB_API mrb_value mrb_msgpack_unpack(mrb_state *mrb, mrb_value data);
1313
MRB_API mrb_value mrb_str_constantize(mrb_state *mrb, mrb_value str);
1414

1515
MRB_API void mrb_msgpack_ensure(mrb_state *mrb);
16-
MRB_API void mrb_msgpack_register_pack_type_value(mrb_state *mrb, int type, mrb_value klass, mrb_value proc);
17-
MRB_API void mrb_msgpack_register_unpack_type_value(mrb_state *mrb, int type, mrb_value proc);
18-
MRB_API void mrb_msgpack_register_pack_type_cfunc(mrb_state *mrb, int type, struct RClass *klass, mrb_func_t cfunc, mrb_int argc, const mrb_value *argv);
19-
MRB_API void mrb_msgpack_register_unpack_type_cfunc(mrb_state *mrb, int type, mrb_func_t cfunc, mrb_int argc, const mrb_value *argv);
16+
MRB_API void mrb_msgpack_register_pack_type_value(mrb_state *mrb, int8_t type, mrb_value klass, mrb_value proc);
17+
MRB_API void mrb_msgpack_register_unpack_type_value(mrb_state *mrb, int8_t type, mrb_value proc);
18+
MRB_API void mrb_msgpack_register_pack_type_cfunc(mrb_state *mrb, int8_t type, struct RClass *klass, mrb_func_t cfunc, mrb_int argc, const mrb_value *argv);
19+
MRB_API void mrb_msgpack_register_unpack_type_cfunc(mrb_state *mrb, int8_t type, mrb_func_t cfunc, mrb_int argc, const mrb_value *argv);
2020
MRB_API void mrb_msgpack_teardown(mrb_state *mrb);
2121
MRB_API void
22-
mrb_msgpack_set_symbol_strategy(mrb_state *mrb, mrb_sym which, mrb_int ext_type);
22+
mrb_msgpack_set_symbol_strategy(mrb_state *mrb, mrb_sym which, int8_t ext_type);
2323

2424
MRB_API mrb_value
2525
mrb_msgpack_get_symbol_strategy(mrb_state *mrb);

src/mrb_msgpack.cpp

Lines changed: 9 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -170,22 +170,16 @@ MRB_API void
170170
mrb_msgpack_ensure(mrb_state *mrb)
171171
{
172172
/* Ensure MessagePack module exists */
173-
struct RClass *msgpack_mod = mrb_module_get_id(mrb, MRB_SYM(MessagePack));
174-
if (!msgpack_mod) {
175-
msgpack_mod = mrb_define_module_id(mrb, MRB_SYM(MessagePack));
176-
}
173+
struct RClass *msgpack_mod = mrb_define_module_id(mrb, MRB_SYM(MessagePack));
177174

178175
/* Ensure MessagePack::Error exists */
179-
struct RClass *err = mrb_class_get_under_id(mrb, msgpack_mod, MRB_SYM(Error));
180-
if (!err) {
181-
err = mrb_define_class_under_id(mrb, msgpack_mod, MRB_SYM(Error), E_RUNTIME_ERROR);
182-
}
176+
mrb_define_class_under_id(mrb, msgpack_mod, MRB_SYM(Error), E_RUNTIME_ERROR);
183177
ensure_ext_registry(mrb);
184178
ensure_msgpack_ctx(mrb);
185179
}
186180

187181
MRB_API void
188-
mrb_msgpack_register_pack_type_value(mrb_state *mrb, int type, mrb_value klass, mrb_value proc)
182+
mrb_msgpack_register_pack_type_value(mrb_state *mrb, int8_t type, mrb_value klass, mrb_value proc)
189183
{
190184
ensure_ext_registry(mrb);
191185
if (type < 0 || type > 127) mrb_raise(mrb, E_RANGE_ERROR, "ext type out of range");
@@ -199,7 +193,7 @@ mrb_msgpack_register_pack_type_value(mrb_state *mrb, int type, mrb_value klass,
199193
}
200194

201195
MRB_API void
202-
mrb_msgpack_register_unpack_type_value(mrb_state *mrb, int type, mrb_value proc)
196+
mrb_msgpack_register_unpack_type_value(mrb_state *mrb, int8_t type, mrb_value proc)
203197
{
204198
ensure_ext_registry(mrb);
205199
if (type < 0 || type > 127) mrb_raise(mrb, E_RANGE_ERROR, "ext type out of range");
@@ -211,7 +205,7 @@ mrb_msgpack_register_unpack_type_value(mrb_state *mrb, int type, mrb_value proc)
211205

212206
MRB_API void
213207
mrb_msgpack_register_pack_type_cfunc(mrb_state *mrb,
214-
int type,
208+
int8_t type,
215209
struct RClass *klass,
216210
mrb_func_t cfunc,
217211
mrb_int argc,
@@ -233,7 +227,7 @@ mrb_msgpack_register_pack_type_cfunc(mrb_state *mrb,
233227

234228
MRB_API void
235229
mrb_msgpack_register_unpack_type_cfunc(mrb_state *mrb,
236-
int type,
230+
int8_t type,
237231
mrb_func_t cfunc,
238232
mrb_int argc,
239233
const mrb_value *argv)
@@ -1125,7 +1119,7 @@ mrb_msgpack_ext_unpacker_registered(mrb_state *mrb, mrb_value self)
11251119
}
11261120

11271121
MRB_API void
1128-
mrb_msgpack_set_symbol_strategy(mrb_state *mrb, mrb_sym which, mrb_int ext_type)
1122+
mrb_msgpack_set_symbol_strategy(mrb_state *mrb, mrb_sym which, int8_t ext_type)
11291123
{
11301124
mrb_msgpack_ctx *ctx = MRB_MSGPACK_CONTEXT(mrb);
11311125

@@ -1139,14 +1133,14 @@ mrb_msgpack_set_symbol_strategy(mrb_state *mrb, mrb_sym which, mrb_int ext_type)
11391133
if (which == MRB_SYM(string)) {
11401134
ctx->sym_packer = mrb_msgpack_pack_symbol_value_as_string;
11411135
ctx->sym_unpacker = mrb_msgpack_unpack_symbol_as_string;
1142-
ctx->ext_type = (int8_t)ext_type;
1136+
ctx->ext_type = ext_type;
11431137
return;
11441138
}
11451139

11461140
if (which == MRB_SYM(int)) {
11471141
ctx->sym_packer = mrb_msgpack_pack_symbol_value_as_int;
11481142
ctx->sym_unpacker = mrb_msgpack_unpack_symbol_as_int;
1149-
ctx->ext_type = (int8_t)ext_type;
1143+
ctx->ext_type = ext_type;
11501144
return;
11511145
}
11521146

0 commit comments

Comments
 (0)