Skip to content

Commit e814770

Browse files
refactor: Move types from workflow-history.types.ts to workflow-history-v2.types.ts (cadence-workflow#1177)
* Move Workflow History types from v1 folder to v2 folder, to prepare for changes to history event group computation * Refactor v2 code to use the types from workflow-history-v2.types.ts Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com>
1 parent 980743b commit e814770

File tree

28 files changed

+310
-49
lines changed

28 files changed

+310
-49
lines changed

src/views/workflow-history-v2/__fixtures__/ungrouped-events-info.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
1-
import { type HistoryEventsGroup } from '@/views/workflow-history/workflow-history.types';
2-
31
import compareUngroupedEvents from '../workflow-history-ungrouped-table/helpers/compare-ungrouped-events';
42
import { type UngroupedEventInfo } from '../workflow-history-ungrouped-table/workflow-history-ungrouped-table.types';
3+
import { type HistoryEventsGroup } from '../workflow-history-v2.types';
54

65
export function createUngroupedEventsInfo(
76
eventGroupsById: Array<[string, HistoryEventsGroup]>

src/views/workflow-history-v2/__tests__/workflow-history-v2.test.tsx

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -16,10 +16,6 @@ import { type HistoryEvent } from '@/__generated__/proto-ts/uber/cadence/api/v1/
1616
import * as usePageFiltersModule from '@/components/page-filters/hooks/use-page-filters';
1717
import { type PageQueryParamValues } from '@/hooks/use-page-query-params/use-page-query-params.types';
1818
import { type GetWorkflowHistoryResponse } from '@/route-handlers/get-workflow-history/get-workflow-history.types';
19-
import {
20-
type PendingActivityTaskStartEvent,
21-
type PendingDecisionTaskStartEvent,
22-
} from '@/views/workflow-history/workflow-history.types';
2319
import { mockDescribeWorkflowResponse } from '@/views/workflow-page/__fixtures__/describe-workflow-response';
2420
import type workflowPageQueryParamsConfig from '@/views/workflow-page/config/workflow-page-query-params.config';
2521

@@ -40,6 +36,10 @@ import {
4036
import { WorkflowHistoryContext } from '../../workflow-history/workflow-history-context-provider/workflow-history-context-provider';
4137
import { type Props as NavbarProps } from '../workflow-history-navigation-bar/workflow-history-navigation-bar.types';
4238
import WorkflowHistoryV2 from '../workflow-history-v2';
39+
import {
40+
type PendingActivityTaskStartEvent,
41+
type PendingDecisionTaskStartEvent,
42+
} from '../workflow-history-v2.types';
4343

4444
jest.mock('@/hooks/use-page-query-params/use-page-query-params', () =>
4545
jest.fn(() => [{ historySelectedEventId: '1' }, jest.fn()])

src/views/workflow-history-v2/config/workflow-history-filters.config.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,8 @@ import {
1111
type WorkflowHistoryEventFilteringType,
1212
type WorkflowHistoryFiltersTypeValue,
1313
} from '@/views/workflow-history/workflow-history-filters-type/workflow-history-filters-type.types';
14-
import { type WorkflowHistoryFilterConfig } from '@/views/workflow-history/workflow-history.types';
14+
15+
import { type WorkflowHistoryFilterConfig } from '../workflow-history-v2.types';
1516

1617
import workflowHistoryFiltersStatusOptionsConfig from './workflow-history-filters-status-options.config';
1718
import workflowHistoryFiltersTypeOptionsConfig from './workflow-history-filters-type-options.config';

src/views/workflow-history-v2/helpers/__tests__/generate-history-group-details.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,8 @@ import {
88
import { mockActivityEventGroup } from '@/views/workflow-history/__fixtures__/workflow-history-event-groups';
99
import { pendingActivityTaskStartEvent } from '@/views/workflow-history/__fixtures__/workflow-history-pending-events';
1010
import isPendingHistoryEvent from '@/views/workflow-history/workflow-history-event-details/helpers/is-pending-history-event';
11-
import { type HistoryEventsGroup } from '@/views/workflow-history/workflow-history.types';
1211

12+
import { type HistoryEventsGroup } from '../../workflow-history-v2.types';
1313
import generateHistoryEventDetails from '../generate-history-event-details';
1414
import generateHistoryGroupDetails from '../generate-history-group-details';
1515

src/views/workflow-history-v2/helpers/__tests__/get-navigation-bar-events-menu-items.test.ts

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,11 @@ import {
22
mockActivityEventGroup,
33
mockDecisionEventGroup,
44
} from '@/views/workflow-history/__fixtures__/workflow-history-event-groups';
5-
import { type HistoryEventsGroup } from '@/views/workflow-history/workflow-history.types';
65

7-
import { type EventGroupEntry } from '../../workflow-history-v2.types';
6+
import {
7+
type HistoryEventsGroup,
8+
type EventGroupEntry,
9+
} from '../../workflow-history-v2.types';
810
import getNavigationBarEventsMenuItems from '../get-navigation-bar-events-menu-items';
911

1012
jest.mock(

src/views/workflow-history-v2/helpers/generate-history-group-details.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
import formatPendingWorkflowHistoryEvent from '@/utils/data-formatters/format-pending-workflow-history-event';
22
import formatWorkflowHistoryEvent from '@/utils/data-formatters/format-workflow-history-event';
33
import isPendingHistoryEvent from '@/views/workflow-history/workflow-history-event-details/helpers/is-pending-history-event';
4-
import { type HistoryEventsGroup } from '@/views/workflow-history/workflow-history.types';
54

65
import generateHistoryEventDetails from '../helpers/generate-history-event-details';
76
import { type EventDetailsTabContent } from '../workflow-history-group-details/workflow-history-group-details.types';
7+
import { type HistoryEventsGroup } from '../workflow-history-v2.types';
88

99
export default function generateHistoryGroupDetails(
1010
eventGroup: HistoryEventsGroup

src/views/workflow-history-v2/helpers/get-navigation-bar-events-menu-items.ts

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,9 @@
1-
import { type HistoryEventsGroup } from '@/views/workflow-history/workflow-history.types';
2-
31
import getEventGroupFilteringType from '../workflow-history-event-group/helpers/get-event-group-filtering-type';
42
import { type NavigationBarEventsMenuItem } from '../workflow-history-navigation-bar-events-menu/workflow-history-navigation-bar-events-menu.types';
5-
import { type EventGroupEntry } from '../workflow-history-v2.types';
3+
import {
4+
type HistoryEventsGroup,
5+
type EventGroupEntry,
6+
} from '../workflow-history-v2.types';
67

78
export default function getNavigationBarEventsMenuItems(
89
eventGroupsEntries: Array<EventGroupEntry>,

src/views/workflow-history-v2/hooks/__tests__/use-group-details-entries.test.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
import { renderHook } from '@/test-utils/rtl';
22

33
import { mockActivityEventGroup } from '@/views/workflow-history/__fixtures__/workflow-history-event-groups';
4-
import { type HistoryEventsGroup } from '@/views/workflow-history/workflow-history.types';
5-
import type { EventDetailsTabContent } from '@/views/workflow-history-v2/workflow-history-group-details/workflow-history-group-details.types';
64

75
import * as generateHistoryGroupDetailsModule from '../../helpers/generate-history-group-details';
6+
import type { EventDetailsTabContent } from '../../workflow-history-group-details/workflow-history-group-details.types';
7+
import { type HistoryEventsGroup } from '../../workflow-history-v2.types';
88
import useGroupDetailsEntries from '../use-group-details-entries';
99

1010
jest.mock('../../helpers/generate-history-group-details');

src/views/workflow-history-v2/hooks/use-group-details-entries.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,8 @@
11
import { useMemo } from 'react';
22

3-
import { type HistoryEventsGroup } from '@/views/workflow-history/workflow-history.types';
4-
53
import generateHistoryGroupDetails from '../helpers/generate-history-group-details';
64
import getSummaryTabContentEntry from '../helpers/get-summary-tab-content-entry';
5+
import { type HistoryEventsGroup } from '../workflow-history-v2.types';
76

87
export default function useGroupDetailsEntries(eventGroup: HistoryEventsGroup) {
98
const { groupDetailsEntries, summaryDetailsEntries } = useMemo(

src/views/workflow-history-v2/workflow-history-details-row/helpers/__tests__/get-parsed-details-row-items.test.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
1-
import { type EventDetailsEntries } from '@/views/workflow-history-v2/workflow-history-event-details/workflow-history-event-details.types';
2-
31
import * as workflowHistoryDetailsRowParsersConfigModule from '../../../config/workflow-history-details-row-parsers.config';
2+
import { type EventDetailsEntries } from '../../../workflow-history-event-details/workflow-history-event-details.types';
43
import { type DetailsRowItemParser } from '../../workflow-history-details-row.types';
54
import getParsedDetailsRowItems from '../get-parsed-details-row-items';
65

0 commit comments

Comments
 (0)