Allow Transfer assets via Call Runtime#1004
Closed
PierreOssun wants to merge 4 commits into
Closed
Conversation
Minimum allowed line rate is |
Contributor
ashutoshvarma
left a comment
There was a problem hiding this comment.
Just wanted to check again, what are our plans if pallet_assets's transfer and transfer_approved disptach changes ?
Contributor
Author
|
We have a dependency on the
|
Contributor
Author
|
This feature is on hold. Waiting for XVM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Summary
Note: resubmitting PR as broke the rebase in #963
This PR removes chain extensions from the runtime.
Add assets_pallet transfer & transfer_approved in call filter to allow call_runtime in ink! contracts.
PS: No need for approve function as the Origin will be the contract.
In the case of a wrapper token pattern (check HERE ) users should approve the contract address via a pallet asset calls before calling
depositCheck list