refactor: barretenberg => bb namespace shortening#4066
Conversation
Benchmark resultsMetrics with a significant change:
Detailed resultsAll benchmarks are run on txs on the This benchmark source data is available in JSON format on S3 here. Values are compared against data from master at commit L2 block published to L1Each column represents the number of txs on an L2 block published to L1.
L2 chain processingEach column represents the number of blocks on the L2 chain where each block has 16 txs.
Circuits statsStats on running time and I/O sizes collected for every circuit run across all benchmarks.
Tree insertion statsThe duration to insert a fixed batch of leaves into each tree type.
MiscellaneousTransaction sizes based on how many contracts are deployed in the tx.
Transaction processing duration by data writes.
|
| { | ||
| plonk::stdlib::field_t a(plonk::stdlib::witness_t(&builder, barretenberg::fr::random_element())); | ||
| plonk::stdlib::field_t b(plonk::stdlib::witness_t(&builder, barretenberg::fr::random_element())); | ||
| plonk::stdlib::field_t a(plonk::stdlib::witness_t(&builder, bb::fr::random_element())); |
There was a problem hiding this comment.
As a follow-on: let's make this bb::bn254::fr, bb::grumpkin::fr etc
| @@ -6,9 +6,9 @@ | |||
| namespace proof_system::honk { | |||
There was a problem hiding this comment.
As a follow-on: we should put everything in bb namespace and remove unneeded qualifications.
| @@ -70,6 +70,6 @@ class Bn254FrParams { | |||
|
|
|||
| using fr = field<Bn254FrParams>; | |||
There was a problem hiding this comment.
I'm personally in favor of calling this Fr but perhaps we should put it to a vote
This is the first phase of namespace refactors planned. Just renames barretenberg=>bb. The followups will mostly collapse long namespaces, e.g. bb::plonk::crypto::aes128 => bb::crypto --------- Co-authored-by: ludamad <adam@aztecprotocol.com>
This is the first phase of namespace refactors planned. Just renames barretenberg=>bb.
The followups will mostly collapse long namespaces, e.g. bb::plonk::crypto::aes128 => bb::crypto