fix #526 - add upgrade mechanism to registry#625
Merged
Conversation
rahul-kothari
force-pushed
the
rk/registry
branch
from
5901aee to
284b5a5
Compare
LHerskind
reviewed
May 19, 2023
rahul-kothari
force-pushed
the
rk/registry
branch
from
284b5a5 to
3dd7525
Compare
LHerskind
reviewed
May 22, 2023
LHerskind
left a comment
LHerskind
left a comment
Contributor
There was a problem hiding this comment.
Needs some natspec for all the functions in Registry
rahul-kothari
force-pushed
the
rk/registry
branch
from
03a80c4 to
2b4f183
Compare
LHerskind
approved these changes
May 22, 2023
LHerskind
left a comment
LHerskind
left a comment
Contributor
There was a problem hiding this comment.
More consistency on @notice then good to go.
rahul-kothari
force-pushed
the
rk/registry
branch
from
2b4f183 to
329e2d0
Compare
This was referenced Jul 25, 2023
danielntmd
pushed a commit
to danielntmd/aztec-packages
that referenced
this pull request
Jun 4, 2026
…ol#23607) Follow-up to AztecProtocol#23600 (merged), which pointed CI at the ClaudeBox v2 `/run` webhook but did not pass a mode. A v2 session's GitHub repo access is derived from its mode (`slack_route.effective_mode` in session meta). The `slackbot` group's repos are entirely mode-scoped, so a `/run` session **without** a mode only resolves the group chain's unscoped repos (`claudebox` + `honk-ai`) and **cannot write `aztec-packages`** — the same "no GitHub access" failure AztecProtocol#23600 set out to fix. Prompt text has no effect; `/run` never parses mode flags. This passes **`mode: "public"`** in both dispatch payloads (overridable via repo var `CLAUDEBOX_MODE`), so kickoff/`/claudebox`/review sessions resolve the public read-write repo set and can open PRs against aztec-packages. **Depends on AztecProtocol/claudebox#625**, which adds `mode` support to the v2 `/run` endpoint (it stamps `effective_mode` into the new session's meta). Without AztecProtocol#625 deployed, `mode` is accepted but ignored, so land/deploy AztecProtocol#625 first or together. ## Testing - `bash -n` on every `run:` body (7 steps) and YAML parse — pass. - `jq` payload validated with `mode: "public"` for the issue-comment, workflow_dispatch, and review shapes — valid JSON matching the v2 `RunRequest`. --- *Created by [claudebox](https://claudebox.work/v2/sessions/4b53f2dd8370a83a) · group: `slackbot`*
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Per our slack discussion of registry snapshotting issue, currently, rollup/inbox/outbox just call the latest version of each other. So we aren't really handling forks for now. I have therefore created #624 for when we reach consensus on how to handle forks for L1<>L2 communication.
Fixes #526
Checklist: