fix #741 and #646#772
Merged
Merged
Conversation
Maddiaa0
reviewed
Jun 7, 2023
Maddiaa0
left a comment
Maddiaa0
left a comment
Member
There was a problem hiding this comment.
small nit over typing, but looks good once ci gets resolved les do it
| * @param secret - the secret to hash (defaults to a random field element) | ||
| * @returns secret and its pederson hash (in hex). | ||
| */ | ||
| export async function createMessageSecretAndHash(secret = Fr.random()) { |
Member
There was a problem hiding this comment.
return as fr to prevent viem coupling
rahul-kothari
force-pushed
the
rk/741-secrethash
branch
2 times, most recently
from
75c10c5 to
4f53e53
Compare
rahul-kothari
force-pushed
the
rk/741-secrethash
branch
from
4f53e53 to
969067d
Compare
LHerskind
requested changes
Jun 8, 2023
| import { computeSecretMessageHash } from '@aztec/circuits.js/abis'; | ||
|
|
||
| /** | ||
| * Given a secret, it computes its pederson hash - used to send l1 to l2 messages |
Contributor
There was a problem hiding this comment.
Suggested change
| * Given a secret, it computes its pederson hash - used to send l1 to l2 messages | |
| * Given a secret, it computes its pedersen hash - used to send l1 to l2 messages |
rahul-kothari
force-pushed
the
rk/741-secrethash
branch
from
6d8a667 to
7e92302
Compare
rahul-kothari
force-pushed
the
rk/741-secrethash
branch
from
7e92302 to
2bc37c8
Compare
rahul-kothari
force-pushed
the
rk/741-secrethash
branch
from
2bc37c8 to
197f631
Compare
This was referenced Jul 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
hash()is not used anywhereChecklist: