Skip to content

fix: pad entry string in l1 to l2 tests#796

Merged
Maddiaa0 merged 1 commit into
masterfrom
md/pad-entry
Jun 9, 2023
Merged

fix: pad entry string in l1 to l2 tests#796
Maddiaa0 merged 1 commit into
masterfrom
md/pad-entry

Conversation

@Maddiaa0

@Maddiaa0 Maddiaa0 commented Jun 9, 2023

Copy link
Copy Markdown
Member

Description

fixes #795

Please provide a paragraph or two giving a summary of the change, including relevant motivation and context.

Checklist:

  • I have reviewed my diff in github, line by line.
  • Every change is related to the PR description.
  • I have linked this pull request to the issue(s) that it resolves.
  • There are no unexpected formatting changes, superfluous debug logs, or commented-out code.
  • The branch has been merged or rebased against the head of its merge target.
  • I'm happy for the PR to be merged at the reviewer's next convenience.

@Maddiaa0 Maddiaa0 marked this pull request as ready for review June 9, 2023 18:33

@ludamad ludamad left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, technically hard to tell if fixed but we can be optimistic on this one

@Maddiaa0

Maddiaa0 commented Jun 9, 2023

Copy link
Copy Markdown
Member Author

yeah agree its hard to tell, however fr.toString() does go to the smallest size, i think it was just a hash getting lucky and ending up being under 32 bytes. But yet again its all speculation

@Maddiaa0 Maddiaa0 merged commit 71b2690 into master Jun 9, 2023
@Maddiaa0 Maddiaa0 deleted the md/pad-entry branch June 9, 2023 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix periodic failing of e2e_cross_chain_messaging.test.ts

2 participants