feat(messaging): public cross chain message e2e#841
Conversation
Maddiaa0
force-pushed
the
md/public-cross-chain-message-test
branch
from
a1f32f7 to
ba27e19
Compare
|
|
||
| describe('Private Execution test suite', () => { | ||
| let bbWasm: CircuitsWasm; | ||
| let circuitsWasm: CircuitsWasm; |
There was a problem hiding this comment.
changed this as it put me off when bbWasm was referring to CircuitsWasm
LHerskind
left a comment
LHerskind
left a comment
There was a problem hiding this comment.
Minor nits here and there. Nice work
|
|
||
| const secretHash = computeSecretMessageHash(wasm, secret); | ||
|
|
||
| // Eventually the kernel will need to prove the kernel portal pair exists within the contract tree, |
There was a problem hiding this comment.
Can you throw in a Todo here, probably best to point to @dbanks12 for ideas around if there already is a issue addressing or when this would make sense.
There was a problem hiding this comment.
Can you expand on this just a bit? This is for L1->L2 messages? The kernel doesn't even know that L1->L2 messages exist at the moment, does it?
|
|
||
| // Compute Nullifier | ||
| let nullifier = l1_to_l2_message_data.message.compute_nullifier(); | ||
| let nullifier = process_l1_to_l2_message(inputs.roots.l1_to_l2_messages_tree_root, inputs.call_context.storage_contract_address, msg_key, content, secret); |
| use crate::messaging::l1_to_l2_message_getter_data::L1ToL2MessageGetterData; | ||
| use crate::messaging::l1_to_l2_message_getter_data::make_l1_to_l2_message_getter_data; | ||
|
|
||
|
|
| } | ||
|
|
||
|
|
||
| fn _get_mint_content_hash(amount: Field, owner_address: Field, canceller: Field) -> pub Field { |
There was a problem hiding this comment.
@kevaundray visibility for noir functions wen? 👀
There was a problem hiding this comment.
OkAy, OkAy, OkAy, I NeEd iNtErNaL FuNcTiOnS. i cAn't tAkE ThIs aNyMoRe. EvErYdAy i'm cHeCkInG ThE InTeRnAl fUnCtIoNs aNd iT'S NoT CoMpIlInG. eVeRyDaY I ChEcK ThE DoCs, BaD DoCs. I CaN'T TaKe tHiS AnYmOrE MaN. i hAvE OvEr-iNvEsTeD, bY A LoT. iT Is wHaT It iS BuT I NeEd tHe iNtErNaL FuNcTiOnS. cAn dEvS Do sOmEtHiNg?
3 participants
Description
fixes #616
Creates a public end to end cross chain messaging test.
As a consequence, public functions will need to be able to generate nullifiers, and read from the l1 to l2 messages tree.
Checklist: