feat: add designated caller on token portal and update uniswap to use it.#896
Merged
Conversation
4e68618 to
7500298
Compare
LHerskind
reviewed
Jun 22, 2023
419bf43 to
f758921
Compare
LHerskind
reviewed
Jun 22, 2023
LHerskind
approved these changes
Jun 22, 2023
This was referenced Jul 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix #877 -> currently, anyone can call our token portal to consume the
withdrawmessage. This doesn't seem a problem there is no use ofmsg.senderin its code and the funds would go to the recipient specified in the message hash. However, in some cases it might be important, like when a contract is consuming multiple messages as part of a smart contract function - in such a case only this contract should call it.Note - once again we implement this at the portal and not the protocol side to maintain flexibility.
I have added tests in solidity to check that caller works as expected.
This builds on #876 which I will fix after this pr! There I will add more tests on an e2e scale.
Checklist: