Skip to content

fix: Fix ABI array/struct decoding#956

Merged
ludamad merged 5 commits into
masterfrom
adam/fix-abi-array-decoding
Jul 4, 2023
Merged

fix: Fix ABI array/struct decoding#956
ludamad merged 5 commits into
masterfrom
adam/fix-abi-array-decoding

Conversation

@ludamad

@ludamad ludamad commented Jul 4, 2023

Copy link
Copy Markdown
Collaborator

Description

Came out of Noir/aztec dogfooding. Could not return an array from a view function. Gets rid of any's

Checklist:

  • I have reviewed my diff in github, line by line.
  • Every change is related to the PR description.
  • I have linked this pull request to the issue(s) that it resolves.
  • There are no unexpected formatting changes, superfluous debug logs, or commented-out code.
  • The branch has been merged or rebased against the head of its merge target.
  • I'm happy for the PR to be merged at the reviewer's next convenience.

@ludamad ludamad changed the title fix: Fix ABI array decoding fix: Fix ABI array/struct decoding Jul 4, 2023

@sirasistant sirasistant left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ludamad ludamad enabled auto-merge (squash) July 4, 2023 09:54
@ludamad ludamad merged commit 404c3f8 into master Jul 4, 2023
@ludamad ludamad deleted the adam/fix-abi-array-decoding branch July 4, 2023 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants