Skip to content

fix(foundation): should error on attempt to convert negative bigint to buffer#981

Merged
dbanks12 merged 2 commits into
masterfrom
db/error-on-negative-bigint-tobuffer
Jul 6, 2023
Merged

fix(foundation): should error on attempt to convert negative bigint to buffer#981
dbanks12 merged 2 commits into
masterfrom
db/error-on-negative-bigint-tobuffer

Conversation

@dbanks12

@dbanks12 dbanks12 commented Jul 6, 2023

Copy link
Copy Markdown
Contributor

Description

Should error on attempt to convert negative bigint to buffer. Encountered this in a branch when intentionally using leafIndex -1 to flag commitments as transient.

Checklist:

  • I have reviewed my diff in github, line by line.
  • Every change is related to the PR description.
  • I have linked this pull request to the issue(s) that it resolves.
  • There are no unexpected formatting changes, superfluous debug logs, or commented-out code.
  • The branch has been merged or rebased against the head of its merge target.
  • I'm happy for the PR to be merged at the reviewer's next convenience.

@dbanks12 dbanks12 requested a review from ludamad July 6, 2023 18:45
@dbanks12 dbanks12 merged commit 6e0d658 into master Jul 6, 2023
@dbanks12 dbanks12 deleted the db/error-on-negative-bigint-tobuffer branch July 6, 2023 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants