Skip to content

chore: fix prettier inside worktrees#22557

Merged
alexghr merged 1 commit into
merge-train/spartanfrom
ag/fix-git-hooks
Apr 22, 2026
Merged

chore: fix prettier inside worktrees#22557
alexghr merged 1 commit into
merge-train/spartanfrom
ag/fix-git-hooks

Conversation

@alexghr

@alexghr alexghr commented Apr 15, 2026

Copy link
Copy Markdown
Contributor

.

@alexghr alexghr changed the base branch from next to merge-train/spartan April 15, 2026 11:34
@alexghr alexghr enabled auto-merge April 15, 2026 11:34
@alexghr alexghr merged commit 765702d into merge-train/spartan Apr 22, 2026
36 checks passed
@alexghr alexghr deleted the ag/fix-git-hooks branch April 22, 2026 09:43
chrismarino pushed a commit to chrismarino/aztec-packages that referenced this pull request May 5, 2026
BEGIN_COMMIT_OVERRIDE
fix(kv-store): ensure LMDB cursor is closed on iteration abort (AztecProtocol#22509)
fix(telemetry-client): use appropriate histogram buckets for L1 gas
prices (AztecProtocol#22512)
fix(telemetry-client): log warning when BatchSpanProcessor drops spans
(AztecProtocol#22511)
fix(stdlib): wrap HA signer databaseUrl in SecretValue (AztecProtocol#22510)
fix(prover-client): don't mark in-progress epoch N jobs as stale when
epoch N+1 starts (AztecProtocol#22508)
chore: (A-730) graceful shutdown for services in node startup failure
path (AztecProtocol#22112)
fix(prover-client): reject stale job promises and count timeouts toward
retry limit (AztecProtocol#21842)
feat(archiver): validate historical L1 log availability at startup
(AztecProtocol#22644)
fix(archiver): do not query MessageSent events by blockhash (AztecProtocol#22641)
refactor(e2e): skip initial sequencer in p2p and epochs tests (AztecProtocol#22535)
fix: handle missing L1 finalized block on devnets (AztecProtocol#22663)
fix(world-state): treat historical block 0 queries as historical, not
latest (AztecProtocol#22679)
fix(sequencer): re-check parent checkpoint validity before pipelined L1
submission (AztecProtocol#22586)
fix(world-state): make block 0 a first-class historical block (AztecProtocol#22711)
chore: show all running versions (AztecProtocol#22376)
chore: fix prettier inside worktrees (AztecProtocol#22557)
feat: use optimized verifier for rollup (AztecProtocol#21840)
fix(kv-store): skip pool creation on ephemeral deleteDb to unstick
browser tests (AztecProtocol#22693)
chore: rm claude lockfile (AztecProtocol#22718)
fix(e2e): wait for first checkpoint in fee_asset_price_oracle_gossip
test (AztecProtocol#22719)
chore(prover-node): track estimated L1 fee when proof publishing is
disabled (AztecProtocol#22691)
fix(ci): rerun squashed PR check on base branch change (AztecProtocol#22713)
feat(archiver): decouple calldata from blob fetching in L1 synchronizer
(AztecProtocol#22716)
refactor(e2e): enable pipelining in e2e_epochs tests (AztecProtocol#22544)
feat(p2p): reject and evict txs with insufficient max fee per gas
(AztecProtocol#22118)
refactor(world-state): always index block 0 regardless of initial tree
size (AztecProtocol#22724)
fix(e2e): fix redistribution test (AztecProtocol#22729)
END_COMMIT_OVERRIDE
vezenovm pushed a commit that referenced this pull request May 28, 2026
Same bug and fix as #22557 — that PR patched `yarn-project/precommit.sh`
but didn't touch `noir-projects/precommit.sh`, which has the same `cd
$(dirname $0)` + later `git rev-parse --show-toplevel` pattern.

Inside a worktree, git sets `GIT_DIR` absolutely when invoking hooks;
after the `cd`, `--show-toplevel` returns the `noir-projects/` subdir
instead of the worktree root. The re-staging step then runs `git add` on
paths that don't exist on disk, and `git add` on a missing path that's
in the index stages a deletion — so committing `.nr` files inside a
worktree silently dropped them from the tree.

Same one-liner fix: `unset GIT_DIR` near the top.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants