Skip to content

fix: add aztecVersion to PXE schema_tests fixture#22960

Merged
benesjan merged 1 commit into
merge-train/fairiesfrom
claudebox/fix-fairies-ci
May 5, 2026
Merged

fix: add aztecVersion to PXE schema_tests fixture#22960
benesjan merged 1 commit into
merge-train/fairiesfrom
claudebox/fix-fairies-ci

Conversation

@AztecBot

@AztecBot AztecBot commented May 5, 2026

Copy link
Copy Markdown
Collaborator

Summary

Fixes the merge-train/fairies CI failure introduced by #22550 (feat: stamping aztec version into contract artifacts). That PR added aztecVersion as a required field on ContractArtifact but missed updating the hand-rolled fixture in pxe/src/storage/backwards_compatibility_tests/schema_tests.ts, breaking the yarn tsgo -b --emitDeclarationOnly step:

pxe/src/storage/backwards_compatibility_tests/schema_tests.ts(658,3):
  error TS2741: Property 'aztecVersion' is missing in type '{...}'
  but required in type 'ContractArtifact'.

Fix

  • Add aztecVersion: 'schema-fixture-version' to buildSchemaContractArtifact() so the literal satisfies ContractArtifact. Uses a deterministic test-only string (rather than DEV_VERSION) to keep the snapshot stable across release version bumps.
  • Update __snapshots__/ContractStore.json to include the new field in the serialized hex bytes (insertion is between name and functions, matching declaration order in ContractArtifactSchema).

Schema-version impact

ARTIFACT_VERSION_BEFORE_INJECTION is the schema's default for missing aztecVersion, so this is read-defaultable, not breaking — PXE_DATA_SCHEMA_VERSION does not need bumping.

CI log: http://ci.aztec-labs.com/1777999383723761

ClaudeBox log: https://claudebox.work/s/0e57df71aab3db0e?run=1

@AztecBot AztecBot added ci-draft Run CI on draft PRs. claudebox Owned by claudebox. it can push to this PR. labels May 5, 2026
@benesjan benesjan marked this pull request as ready for review May 5, 2026 17:04
@benesjan benesjan merged commit e047e38 into merge-train/fairies May 5, 2026
39 of 45 checks passed
@benesjan benesjan deleted the claudebox/fix-fairies-ci branch May 5, 2026 17:26
@AztecBot

AztecBot commented May 5, 2026

Copy link
Copy Markdown
Collaborator Author

❌ Failed to cherry-pick to v4-next due to conflicts. (🤖) View backport run.

rangozd pushed a commit to rangozd/aztec-packages that referenced this pull request May 16, 2026
BEGIN_COMMIT_OVERRIDE
refactor: `getPackageVersion` fn cleanup (AztecProtocol#22941)
fix(ci): skip acceptance test for canary -commit. tags (AztecProtocol#22951)
fix: closing db, correct stub side effects (AztecProtocol#22939)
feat: wallet-sdk heartbeat (AztecProtocol#22948)
chore: pxe db schema compatibility test (AztecProtocol#22872)
feat: stamping aztec version into contract artifacts (AztecProtocol#22550)
fix: add aztecVersion to PXE schema_tests fixture (AztecProtocol#22960)
feat(pxe): deduplicate class ID verification per contract (AztecProtocol#22966)
chore: add noirfmt.toml to noir-contracts and run nargo fmt (AztecProtocol#22971)
feat(aztec-nr): Initial handshake registry contract with non interactive
handshake function (AztecProtocol#22854)
chore: merge next into merge-train/fairies (AztecProtocol#22991)
fix(aztec-up): Aztec installer does not shadow user installed binaries
on PATH (AztecProtocol#22902)
test(ci): drop e2e_kernelless_simulation from backwards-compat e2e
(AztecProtocol#23005)
feat(ci): notify #team-fairies when backwards-compat e2e fails on
nightly (AztecProtocol#23006)
chore: merge next into merge-train/fairies (AztecProtocol#23021)
fix: better DeployMethod (AztecProtocol#22985)
refactor(pxe): batch RPC calls for note and event validation (AztecProtocol#22988)
END_COMMIT_OVERRIDE
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-to-v4-next ci-draft Run CI on draft PRs. claudebox Owned by claudebox. it can push to this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants