Skip to content

refactor: move public_checks caller helpers into aztec-nr (prep for public_checks demotion)#23215

Merged
dbanks12 merged 6 commits into
merge-train/fairiesfrom
dbanks12/public-checks-to-aztec-nr
May 27, 2026
Merged

refactor: move public_checks caller helpers into aztec-nr (prep for public_checks demotion)#23215
dbanks12 merged 6 commits into
merge-train/fairiesfrom
dbanks12/public-checks-to-aztec-nr

Conversation

@dbanks12

Copy link
Copy Markdown
Contributor

Moves PublicChecks caller helpers from public_checks_contract/src/utils.nr into aztec-nr/aztec/src/public_checks.nr. Consumer contracts (app_subscription, crowdfunding) now import from aztec-nr.

Stacked on #23214.

dbanks12 commented May 12, 2026

Copy link
Copy Markdown
Contributor Author

@dbanks12 dbanks12 force-pushed the dbanks12/public-checks-to-aztec-nr branch 2 times, most recently from 4ab38c0 to 763b311 Compare May 12, 2026 19:28
@dbanks12 dbanks12 changed the base branch from dbanks12/authwit-split to graphite-base/23215 May 13, 2026 17:27
@dbanks12 dbanks12 force-pushed the dbanks12/public-checks-to-aztec-nr branch from 763b311 to e5e600b Compare May 13, 2026 17:27
@dbanks12 dbanks12 changed the base branch from graphite-base/23215 to merge-train/fairies May 13, 2026 17:27
@dbanks12 dbanks12 changed the title refactor(public_checks): move caller helpers into aztec-nr refactor: move public_checks caller helpers into aztec-nr May 13, 2026
@dbanks12 dbanks12 changed the title refactor: move public_checks caller helpers into aztec-nr refactor: move public_checks caller helpers into aztec-nr (prep for public_checks demotion) May 14, 2026
@dbanks12 dbanks12 force-pushed the dbanks12/public-checks-to-aztec-nr branch from e5e600b to 3fe485f Compare May 26, 2026 18:59
@dbanks12 dbanks12 marked this pull request as ready for review May 26, 2026 19:12
@dbanks12 dbanks12 requested a review from nventuro as a code owner May 26, 2026 19:12
@dbanks12 dbanks12 requested review from benesjan and removed request for nventuro May 26, 2026 20:24

@benesjan benesjan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@dbanks12 dbanks12 merged commit fe58c0f into merge-train/fairies May 27, 2026
14 checks passed
@dbanks12 dbanks12 deleted the dbanks12/public-checks-to-aztec-nr branch May 27, 2026 15:31
dbanks12 added a commit that referenced this pull request May 27, 2026
- schnorr/simulated_schnorr account contracts and uniswap_contract still imported authwit::common::*; rename the path to authwit::utils::* to match the split.
- app_subscription_contract: revert the spurious 'use public_checks::utils::privately_check_block_number' (the public_checks crate is no longer a separate crate after #23215 moved the helpers into aztec-nr) back to 'use aztec::public_checks::privately_check_block_number'.
dbanks12 added a commit that referenced this pull request May 27, 2026
- schnorr/simulated_schnorr account contracts and uniswap_contract still imported authwit::common::*; rename the path to authwit::utils::* to match the split.
- app_subscription_contract: revert the spurious 'use public_checks::utils::privately_check_block_number' (the public_checks crate is no longer a separate crate after #23215 moved the helpers into aztec-nr) back to 'use aztec::public_checks::privately_check_block_number'.
dbanks12 added a commit that referenced this pull request May 27, 2026
- schnorr/simulated_schnorr account contracts and uniswap_contract still imported authwit::common::*; rename the path to authwit::utils::* to match the split.
- app_subscription_contract: revert the spurious 'use public_checks::utils::privately_check_block_number' (the public_checks crate is no longer a separate crate after #23215 moved the helpers into aztec-nr) back to 'use aztec::public_checks::privately_check_block_number'.
dbanks12 added a commit that referenced this pull request May 28, 2026
- schnorr/simulated_schnorr account contracts and uniswap_contract still imported authwit::common::*; rename the path to authwit::utils::* to match the split.
- app_subscription_contract: revert the spurious 'use public_checks::utils::privately_check_block_number' (the public_checks crate is no longer a separate crate after #23215 moved the helpers into aztec-nr) back to 'use aztec::public_checks::privately_check_block_number'.
dbanks12 added a commit that referenced this pull request May 28, 2026
- schnorr/simulated_schnorr account contracts and uniswap_contract still imported authwit::common::*; rename the path to authwit::utils::* to match the split.
- app_subscription_contract: revert the spurious 'use public_checks::utils::privately_check_block_number' (the public_checks crate is no longer a separate crate after #23215 moved the helpers into aztec-nr) back to 'use aztec::public_checks::privately_check_block_number'.
dbanks12 added a commit that referenced this pull request May 28, 2026
- schnorr/simulated_schnorr account contracts and uniswap_contract still imported authwit::common::*; rename the path to authwit::utils::* to match the split.
- app_subscription_contract: revert the spurious 'use public_checks::utils::privately_check_block_number' (the public_checks crate is no longer a separate crate after #23215 moved the helpers into aztec-nr) back to 'use aztec::public_checks::privately_check_block_number'.
dbanks12 added a commit that referenced this pull request May 28, 2026
- schnorr/simulated_schnorr account contracts and uniswap_contract still imported authwit::common::*; rename the path to authwit::utils::* to match the split.
- app_subscription_contract: revert the spurious 'use public_checks::utils::privately_check_block_number' (the public_checks crate is no longer a separate crate after #23215 moved the helpers into aztec-nr) back to 'use aztec::public_checks::privately_check_block_number'.
dbanks12 added a commit that referenced this pull request May 28, 2026
- schnorr/simulated_schnorr account contracts and uniswap_contract still imported authwit::common::*; rename the path to authwit::utils::* to match the split.
- app_subscription_contract: revert the spurious 'use public_checks::utils::privately_check_block_number' (the public_checks crate is no longer a separate crate after #23215 moved the helpers into aztec-nr) back to 'use aztec::public_checks::privately_check_block_number'.
dbanks12 added a commit that referenced this pull request May 28, 2026
- schnorr/simulated_schnorr account contracts and uniswap_contract still imported authwit::common::*; rename the path to authwit::utils::* to match the split.
- app_subscription_contract: revert the spurious 'use public_checks::utils::privately_check_block_number' (the public_checks crate is no longer a separate crate after #23215 moved the helpers into aztec-nr) back to 'use aztec::public_checks::privately_check_block_number'.
dbanks12 added a commit that referenced this pull request May 28, 2026
- schnorr/simulated_schnorr account contracts and uniswap_contract still imported authwit::common::*; rename the path to authwit::utils::* to match the split.
- app_subscription_contract: revert the spurious 'use public_checks::utils::privately_check_block_number' (the public_checks crate is no longer a separate crate after #23215 moved the helpers into aztec-nr) back to 'use aztec::public_checks::privately_check_block_number'.
dbanks12 added a commit that referenced this pull request May 28, 2026
- schnorr/simulated_schnorr account contracts and uniswap_contract still imported authwit::common::*; rename the path to authwit::utils::* to match the split.
- app_subscription_contract: revert the spurious 'use public_checks::utils::privately_check_block_number' (the public_checks crate is no longer a separate crate after #23215 moved the helpers into aztec-nr) back to 'use aztec::public_checks::privately_check_block_number'.
dbanks12 added a commit that referenced this pull request May 28, 2026
- schnorr/simulated_schnorr account contracts and uniswap_contract still imported authwit::common::*; rename the path to authwit::utils::* to match the split.
- app_subscription_contract: revert the spurious 'use public_checks::utils::privately_check_block_number' (the public_checks crate is no longer a separate crate after #23215 moved the helpers into aztec-nr) back to 'use aztec::public_checks::privately_check_block_number'.
dbanks12 added a commit that referenced this pull request May 28, 2026
- schnorr/simulated_schnorr account contracts and uniswap_contract still imported authwit::common::*; rename the path to authwit::utils::* to match the split.
- app_subscription_contract: revert the spurious 'use public_checks::utils::privately_check_block_number' (the public_checks crate is no longer a separate crate after #23215 moved the helpers into aztec-nr) back to 'use aztec::public_checks::privately_check_block_number'.
dbanks12 added a commit that referenced this pull request May 28, 2026
- schnorr/simulated_schnorr account contracts and uniswap_contract still imported authwit::common::*; rename the path to authwit::utils::* to match the split.
- app_subscription_contract: revert the spurious 'use public_checks::utils::privately_check_block_number' (the public_checks crate is no longer a separate crate after #23215 moved the helpers into aztec-nr) back to 'use aztec::public_checks::privately_check_block_number'.
dbanks12 added a commit that referenced this pull request May 28, 2026
- schnorr/simulated_schnorr account contracts and uniswap_contract still imported authwit::common::*; rename the path to authwit::utils::* to match the split.
- app_subscription_contract: revert the spurious 'use public_checks::utils::privately_check_block_number' (the public_checks crate is no longer a separate crate after #23215 moved the helpers into aztec-nr) back to 'use aztec::public_checks::privately_check_block_number'.
dbanks12 added a commit that referenced this pull request May 29, 2026
- schnorr/simulated_schnorr account contracts and uniswap_contract still imported authwit::common::*; rename the path to authwit::utils::* to match the split.
- app_subscription_contract: revert the spurious 'use public_checks::utils::privately_check_block_number' (the public_checks crate is no longer a separate crate after #23215 moved the helpers into aztec-nr) back to 'use aztec::public_checks::privately_check_block_number'.
dbanks12 added a commit that referenced this pull request May 29, 2026
- schnorr/simulated_schnorr account contracts and uniswap_contract still imported authwit::common::*; rename the path to authwit::utils::* to match the split.
- app_subscription_contract: revert the spurious 'use public_checks::utils::privately_check_block_number' (the public_checks crate is no longer a separate crate after #23215 moved the helpers into aztec-nr) back to 'use aztec::public_checks::privately_check_block_number'.
danielntmd pushed a commit to danielntmd/aztec-packages that referenced this pull request Jun 4, 2026
BEGIN_COMMIT_OVERRIDE
chore(aztec-nr): extract per-signature calldata unpack helpers to shrink
public_dispatch (AztecProtocol#23464)
refactor: move public_checks caller helpers into aztec-nr (prep for
public_checks demotion) (AztecProtocol#23215)
refactor(pxe): introduce typed oracle registry for serialization
(AztecProtocol#23516)
END_COMMIT_OVERRIDE
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants