feat!: demote public_checks to non-protocol contract#23217
Merged
Conversation
dbanks12
force-pushed
the
dbanks12/demote-public-checks
branch
2 times, most recently
from
d4e3d99 to
f510541
Compare
This was referenced May 12, 2026
Merged
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
dbanks12
force-pushed
the
dbanks12/demote-public-checks
branch
from
f510541 to
ab09d50
Compare
dbanks12
force-pushed
the
dbanks12/demote-public-checks
branch
4 times, most recently
from
6578b98 to
9a6b2ac
Compare
dbanks12
force-pushed
the
dbanks12/demote-public-checks
branch
from
9a6b2ac to
df5c16a
Compare
dbanks12
changed the title
dbanks12
force-pushed
the
dbanks12/demote-public-checks
branch
2 times, most recently
from
d333bc5 to
c6ec6a6
Compare
dbanks12
force-pushed
the
dbanks12/demote-public-checks
branch
4 times, most recently
from
5d2eb19 to
3666379
Compare
dbanks12
force-pushed
the
dbanks12/demote-public-checks
branch
6 times, most recently
from
b46df9a to
454db0d
Compare
dbanks12
requested review from
LeilaWang,
MirandaWood,
jeanmon and
nventuro
as code owners
Thunkar
reviewed
May 28, 2026
| import { StandardContractAddress, StandardContractClassId } from '../standard_contract_data.js'; | ||
|
|
||
| export const STANDARD_PUBLIC_CHECKS_ADDRESS = StandardContractAddress.PublicChecks; | ||
| export const STANDARD_PUBLIC_CHECKS_CLASS_ID = StandardContractClassId.PublicChecks; |
Contributor
There was a problem hiding this comment.
Another nit: maybe the export should be /data or something like that and include the salt too
Contributor
Author
There was a problem hiding this comment.
renamed constants.ts
…written interface
PublicStaticCall<NameLen, ArgsLen, ReturnT> needs its return type fixed explicitly; without the let-binding ascription the compiler cannot infer ReturnT from the args at the call site, yielding 'Type annotation needed' on enqueue_view_incognito. Match the (15, 2, ()) / (18, 2, ()) parameters used in the upstack PublicChecksInterface stub.
PUBLIC_CHECKS_ADDRESS now lives in aztec/src/standard_addresses.nr (and its aztec_sublib twin), not the deleted standard_addresses crate.
…lic_checks_contract
…tants.ts; export STANDARD_PUBLIC_CHECKS_SALT
Address derivation changed because upstream changes to aztec-nr (notably BoundedVec max-length embedding) altered the AuthRegistry and PublicChecks artifact hashes. Pinned values now match what the drift check produces.
…ild cache The yarn-project build cache tarball is assembled from `git ls-files --others --ignored` (ignored untracked files only). standard-contracts/dest is ignored via **/dest and gets cached, but standard-contracts/artifacts was untracked-yet- not-ignored, so it was dropped from the tarball. On cache-restore builds, dest/ landed without its sibling artifacts/, breaking every consumer that imports artifacts/AuthRegistry.json (e2e jest + rollup playground). Matches the existing convention for protocol-contracts/artifacts, accounts/artifacts, etc.
Collaborator
Flakey Tests🤖 says: This CI run detected 1 tests that failed, but were tolerated due to a .test_patterns.yml entry. |
This was referenced May 28, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Demotes public_checks from protocol contract.
Stacked on #23106.