feat(pxe)!: add source and block-range filtering to get_logs_by_tag#23326
Merged
nchamo merged 8 commits intoMay 21, 2026
Merged
Conversation
nchamo
changed the title
nchamo
changed the title
nchamo
commented
May 15, 2026
| /// without actually using any of the new oracles then there is no reason to throw. | ||
| pub global ORACLE_VERSION_MAJOR: Field = 22; | ||
| pub global ORACLE_VERSION_MINOR: Field = 1; | ||
| pub global ORACLE_VERSION_MAJOR: Field = 23; |
Contributor
Author
There was a problem hiding this comment.
I would have expected this to be 12 (the version we decided protocol contracts were going to use), but apparently we are keeping it up to date with PXE's version
mverzilli
reviewed
May 18, 2026
Comment on lines
+21
to
+23
| + source: LogSource.PUBLIC_AND_PRIVATE, | ||
| + from_block: Option::none(), | ||
| + to_block: Option::none(), |
Contributor
There was a problem hiding this comment.
would it make sense to add a default constructor?
mverzilli
reviewed
May 18, 2026
Comment on lines
+699
to
+700
| // The deprecated v1 oracle expects Option<LogRetrievalResponse> (at most one per tag). | ||
| const maybeLogRetrievalResponses = logRetrievalResponses.map(logs => logs[0] ?? null); |
Contributor
There was a problem hiding this comment.
I know we're deprecating this soon, but maybe add a unit tests for this case
Collaborator
Flakey Tests🤖 says: This CI run detected 1 tests that failed, but were tolerated due to a .test_patterns.yml entry. |
mverzilli
approved these changes
May 21, 2026
nchamo
deleted the
nchamo/f-657-add-fromto-block-range-filtering-to-get_logs_by_tag
branch
github-merge-queue Bot
pushed a commit
that referenced
this pull request
May 25, 2026
BEGIN_COMMIT_OVERRIDE feat(txe): add TXE oracle version check to bootstrap (#23324) fix(txe): correct TXE_ORACLE_INTERFACE_HASH to match current oracle interface (#23460) feat(aztec-nr): add Serialize/Deserialize for EphemeralArray (#23417) refactor: move validation and error handling out of transport layer (#23422) feat(pxe)!: add source and block-range filtering to get_logs_by_tag (#23326) fix(txe): update TXE oracle interface hash for new AVM oracle methods (#23492) chore(ci): capture sandbox diagnostics on acceptance test failure (#23495) feat(aztec-nr)!: rename push_nullifier to push_nullifier_unsafe (#23488) feat(aztec-nr)!: add explicit custom_sync_state hook to AztecConfig (#23446) fix(ci): skip aztec-cli notify job when acceptance test is skipped (#23534) fix: released contract artifact aztec version (forward port of #23470) (#23500) fix: merge train conflicts (#23548) END_COMMIT_OVERRIDE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Constrained delivery introduces log tags that can be repeated across multiple logs and that only appear on private logs. The current
get_logs_by_tagoracle returns at most one log per tag and always queries both private and public RPCs, which doesn't work for this use case:from_block/to_blocklet callers scope queries to new blocks onlysourcefilter lets callers specify private, public, or bothOur fix
LogRetrievalRequestwithsource,from_block, andto_blockfields across the Noir-TS boundaryfetchLogsByTagto return all matching logs per tag (LogRetrievalResponse[][]) instead of only the first matchLogSourceenum (private / public / public-and-private) following the repo's struct-based enum pattern, with validation on TS deserialization[fromBlock, toBlock)semantics to matchAztecNodeconventionsFixes F-657
Fixes #15052