feat!: add message signing and fallback keys#23510
Merged
IlyasRidhuan merged 7 commits intoMay 28, 2026
Merged
Conversation
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
IlyasRidhuan
force-pushed
the
ir/05-22-feat_add_message_signing_and_fallback_keys
branch
2 times, most recently
from
7a0ba6b to
ce2e7f9
Compare
MirandaWood
approved these changes
May 26, 2026
MirandaWood
left a comment
MirandaWood
left a comment
Contributor
There was a problem hiding this comment.
LGTM so far! May need more fixtures to be updated but pil, docs, nr, and y-p all look great 🎉
IlyasRidhuan
force-pushed
the
ir/05-22-feat_add_message_signing_and_fallback_keys
branch
from
ce2e7f9 to
92ffcd8
Compare
IlyasRidhuan
requested review from
LeilaWang,
jeanmon and
nventuro
as code owners
jeanmon
approved these changes
May 27, 2026
jeanmon
left a comment
jeanmon
left a comment
Contributor
There was a problem hiding this comment.
The AVM specific changes look good to me.
nventuro
reviewed
May 27, 2026
IlyasRidhuan
force-pushed
the
ir/05-22-feat_add_message_signing_and_fallback_keys
branch
from
92ffcd8 to
a427e00
Compare
IlyasRidhuan
force-pushed
the
ir/05-22-feat_add_message_signing_and_fallback_keys
branch
from
a427e00 to
9a402f1
Compare
IlyasRidhuan
force-pushed
the
ir/05-22-feat_add_message_signing_and_fallback_keys
branch
from
dd2b1fe to
23c9dfa
Compare
IlyasRidhuan
deleted the
ir/05-22-feat_add_message_signing_and_fallback_keys
branch
dbanks12
added a commit
that referenced
this pull request
May 29, 2026
…sses Recent merges into the train (key/authwit changes via #23510) shifted the compiled bytecode of both standard contracts, so their derived addresses changed and the committed values were stale, failing the standard-contracts drift guard during build. Regenerated via two-pass build (converged): AuthRegistry 0x1c3bd1fb... -> 0x27ced680... PublicChecks 0x23a16bc3... -> 0x05d900a6...
nchamo
added a commit
that referenced
this pull request
May 29, 2026
The merge brought in message-signing and fallback keys (#23510), which extended the contract instance (CONTRACT_INSTANCE_LENGTH 10 -> 12). The previously committed addresses were derived against a stale local TS build using the old instance layout. Regenerate against the rebuilt toolchain so the compile_all drift check passes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a new message signing key and fallback key to the protocol public keys. They're grumpkin curve points but following the recent AZIP-8 related changes they are stored in hash form in the relevant data structures.
Note that this PR adds it to the protocol but does NOT expose a derivation path nor does it expose a way to set these keys as part of the stdlib in
yarn-project. So fixed default values are used in their place.