feat: merge-train/fairies#23584
Merged
Merged
Conversation
…ink public_dispatch (#23464) ## Summary Additional work towards resolving AztecProtocol/aztec-nr#35 - In `generate_public_dispatch`, count parameter-type signatures across the contract public functions. When at least `EXTRACTION_THRESHOLD` (4) functions share a signature, emit one `#[inline_never]` `__aztec_nr_internals__unpack_arguments_<N>` helper that does the `calldata_copy` + per-parameter `stream_deserialize` once, and rewrite those dispatch arms to call it. - Signatures below the threshold keep the previous inline shape, so we do not pay CALL/RET overhead on call sites that would not recoup it. - Follows the same pattern as #23161, but targets the calldata-deserialization boilerplate the dispatch macro inlines into every arm rather than user-written helpers. ## Bytecode impact Measured via `nargo compile --inliner-aggressiveness 0` + `bb aztec_process`, reading `public_dispatch` packed bytecode: | Contract | Baseline | Post | Δ | |---------------------------------------|----------|--------|----------------| | `public_fns_with_emit_repro_contract` | 4,601 | 4,227 | -374 (-8.1%) | | `avm_test_contract` | 51,333 | 51,048 | -285 (-0.55%) | The repro contract is the same one used in #23161, so the delta stacks on top of that one. Real contracts with many public functions sharing parameter shapes is where we see savings from this change. ## Additional Context - The threshold is a single share-count knob for now. The real break-even depends on per-site `stream_deserialize` size (one `Field` arg vs. e.g. `(AztecAddress, U128, PartialUintNote)`), but a single threshold keeps the macro readable; we can size helpers against per-site savings later if needed. - Follow-up: [F-675](https://linear.app/aztec-labs/issue/F-675/centralize-validation-for-aztec-nr-macro-generated-internal-function) tracks centralizing validation for aztec-nr macro-generated internal names. The generated-name collision class predates this PR, and the new unpack helper names are one specific instance.
Collaborator
Author
|
🤖 Auto-merge enabled after 4 hours of inactivity. This PR will be merged automatically once all checks pass. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BEGIN_COMMIT_OVERRIDE
chore(aztec-nr): extract per-signature calldata unpack helpers to shrink public_dispatch (#23464)
refactor: move public_checks caller helpers into aztec-nr (prep for public_checks demotion) (#23215)
refactor(pxe): introduce typed oracle registry for serialization (#23516)
END_COMMIT_OVERRIDE