fix(txe): drop AuthRegistry from TXE_REQUIRED_PROTOCOL_CONTRACTS#23703
Closed
AztecBot wants to merge 1 commit into
Closed
fix(txe): drop AuthRegistry from TXE_REQUIRED_PROTOCOL_CONTRACTS#23703AztecBot wants to merge 1 commit into
AztecBot wants to merge 1 commit into
Conversation
AuthRegistry was demoted from a protocol contract to a standard contract on next (moved to @aztec/standard-contracts). After next merged into merge-train/fairies, the txe-speedup change (#23578) that introduced TXE_REQUIRED_PROTOCOL_CONTRACTS = ['AuthRegistry'] no longer type-checked, since 'AuthRegistry' is no longer a ProtocolContractName. txe_session.ts already deploys AuthRegistry (and PublicChecks) per-session via deployManyInSingleBlock, so no protocol contract needs pre-loading into the shared contract store today. Empty the list to restore the build.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
CI on
merge-train/fairies(log 1780065325061237) fails in theyarn-projectcompile_allstep with:This surfaced now (not when #23578 landed) because the failing commit —
fix(ci): don't serve cached results for disabled-cache test commands (#23658)— stopped serving stale cached results for this command, exposing a latent compile failure introduced by an earliernextmerge.Root cause
next,AuthRegistrywas demoted from a protocol contract to a standard contract and moved to the new@aztec/standard-contractspackage, so it is no longer a member ofProtocolContractName.merge-train/fairiesintroducedTXE_REQUIRED_PROTOCOL_CONTRACTS: ProtocolContractName[] = ['AuthRegistry']to pre-load protocol contracts into the shared TXE contract store.nextinto the train left that'AuthRegistry'literal referencing a name that is no longer aProtocolContractName→TS2322.The merged
txe_session.tsalready deploysAuthRegistry(andPublicChecks) per session viadeployManyInSingleBlock([getStandardAuthRegistry(), getStandardPublicChecks()]), so the protocol-contract pre-load ofAuthRegistryis both type-invalid and functionally superseded.Fix
Empty
TXE_REQUIRED_PROTOCOL_CONTRACTS— no protocol contract needs pre-loading into the shared store today — and update the comment. The type annotation and@aztec/protocol-contractsimport are kept so the list stays an easy extension point if a future protocol-contract lookup is needed.dispatcher_pool.tssimply maps over the (now empty) array, so its behavior is a no-op for the pre-load.Verification
./bootstrap.sh ci-fast/ native build chain cannot run in this container (no docker/redis for the test engine; the noir Rust toolchain is not provisioned), so a full local CI run was not possible — CI on this PR is the authoritative check.tsc --strictcheck using the exactProtocolContractNameunion from the error:['AuthRegistry']reproducesTS2322;[]compiles cleanly and still supports the.map()call indispatcher_pool.ts.Targets the
merge-train/fairiesbranch directly per the merge-train fix workflow.Created by claudebox · group:
slackbot