test(cli-wallet): wait for checkpointed in serial sandbox flow tests#23916
Merged
spalladino merged 1 commit intoJun 5, 2026
Merged
Conversation
AztecBot
added
ci-draft
The cli-wallet flow tests run serially against the single-block local-network sandbox, where a proposed block can be orphaned and pruned before its checkpoint is published (a reorg). When that happens a tx the caller already moved on from is dropped, and a later step that depends on it breaks: in shield_and_transfer.sh the bridged fee-juice L1->L2 message is discarded and the subsequent fee_juice claim fails with "No L1 to L2 message found". This intermittently dequeued the merge-train/spartan-v5 PR from the merge queue. Make the flow-test aztec-wallet wrapper pass --wait-for-status checkpointed for the tx-producing commands (send/deploy/deploy-account/create-account), so each tx is durably included before the next is sent. Scoped to the test harness only; the cli-wallet default is unchanged (still 'proposed').
AztecBot
changed the title
AztecBot
force-pushed
the
cb/fix-spartan-v5-cli-flow-reorg
branch
from
53f912d to
70cf7ae
Compare
spalladino
approved these changes
Jun 5, 2026
spalladino
left a comment
spalladino
left a comment
Contributor
There was a problem hiding this comment.
Pending rollback after #23821 lands
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The
merge-train/spartan-v5PR (#23910) was dequeued from the merge queue: the merge-queue-heavy run failed on one of its 10 grind runs, on the cli-wallet flow testcli-wallet/test/flows/shield_and_transfer.sh.The fatal error was a fee-juice claim failing after a chain reorg:
Root cause
The cli-wallet
send/deploy/create-account/deploy-accountcommands wait for tx statusproposedby default. In the serial, single-block local-network sandbox a proposed block can be orphaned and pruned before its checkpoint is published — exactly the reorg above. When that happens, a tx the caller already moved on from is dropped, and the bridged fee-juice L1→L2 message that the nextdeploy-account --payment fee_juice,claimdepends on disappears, so the claim fails withNo L1 to L2 message found. It is intermittent (1/10 grinds here), which is why it only bit in the heavy merge-queue run.Fix
Scoped entirely to the flow-test harness: the
aztec-walletwrapper inshared/setup.shnow passes--wait-for-status checkpointedfor the tx-producing commands (send,deploy,deploy-account,create-account), so each tx is durably included before the next is sent. Commands that pass--no-wait(e.g.bridge-fee-juice) or already set--wait-for-statusare left untouched.The cli-wallet itself is unchanged — its default is still
proposed. This addresses the earlier review note to not change the wallet default and keep the change within the tests.