fix: Ensure TBB is optional using OPTIONAL_COMPONENTS#127
Merged
Conversation
ludamad
pushed a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Jul 22, 2023
…barretenberg#127) * fix: Ensure TBB is optional using OPTIONAL_COMPONENTS * chore: Avoid noisy message when tbb not found
ludamad
pushed a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Jul 24, 2023
…barretenberg#127) * fix: Ensure TBB is optional using OPTIONAL_COMPONENTS * chore: Avoid noisy message when tbb not found
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When compiling bb on Mac M1, the cmake configure failed due to TBB not being available. It looks like this is meant to be optional if not available but the
find_packagecall marks it asREQUIRED. It's not enough to just removeREQUIREDbecause it still assumes thetbbcomponent to be mandatory, so I moved them toOPTIONAL_COMPONENTSto move past this section without failing.Checklist:
/markdown/specshave been updated.@briefdescribing the intended functionality.