Skip to content

fix: Ensure TBB is optional using OPTIONAL_COMPONENTS#127

Merged
dbanks12 merged 2 commits into
masterfrom
phated/tbb-optional
Feb 9, 2023
Merged

fix: Ensure TBB is optional using OPTIONAL_COMPONENTS#127
dbanks12 merged 2 commits into
masterfrom
phated/tbb-optional

Conversation

@phated

@phated phated commented Feb 7, 2023

Copy link
Copy Markdown

Description

When compiling bb on Mac M1, the cmake configure failed due to TBB not being available. It looks like this is meant to be optional if not available but the find_package call marks it as REQUIRED. It's not enough to just remove REQUIRED because it still assumes the tbb component to be mandatory, so I moved them to OPTIONAL_COMPONENTS to move past this section without failing.

Checklist:

  • I have reviewed my diff in github, line by line.
  • Every change is related to the PR description.
  • I have linked this pull request to the issue(s) that it resolves.
  • There are no unexpected formatting changes, superfluous debug logs, or commented-out code.
  • There are no circuit changes, OR specifications in /markdown/specs have been updated.
  • There are no circuit changes, OR a cryptographer has been assigned for review.
  • I've updated any terraform that needs updating (e.g. environment variables) for deployment.
  • The branch has been rebased against the head of its merge target.
  • I'm happy for the PR to be merged at the reviewer's next convenience.
  • New functions, classes, etc. have been documented according to the doxygen comment format. Classes and structs must have @brief describing the intended functionality.
  • If existing code has been modified, such documentation has been added or updated.

@phated phated requested review from charlielye and dbanks12 February 7, 2023 19:27

@dbanks12 dbanks12 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@dbanks12 dbanks12 merged commit e3039b2 into master Feb 9, 2023
@dbanks12 dbanks12 deleted the phated/tbb-optional branch February 9, 2023 00:11
ludamad pushed a commit to AztecProtocol/aztec-packages that referenced this pull request Jul 22, 2023
…barretenberg#127)

* fix: Ensure TBB is optional using OPTIONAL_COMPONENTS

* chore: Avoid noisy message when tbb not found
ludamad pushed a commit to AztecProtocol/aztec-packages that referenced this pull request Jul 24, 2023
…barretenberg#127)

* fix: Ensure TBB is optional using OPTIONAL_COMPONENTS

* chore: Avoid noisy message when tbb not found
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants