feat: Add equality and serialization to poly_triple#172
Merged
Conversation
adr1anh
reviewed
Feb 22, 2023
…ing a struct which contains a vector of poly_triple
ledwards2225
force-pushed
the
phated/noir-needs-3
branch
from
8237885 to
295a8cb
Compare
ludamad
pushed a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Jul 22, 2023
…rretenberg#172) * NOIR NEEDS: Equality method and serialisation are needed for serialising a struct which contains a vector of poly_triple * Light formatting * remove added newline * change to default * diff nit --------- Co-authored-by: kevaundray <kevtheappdev@gmail.com>
ludamad
pushed a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Jul 24, 2023
…rretenberg#172) * NOIR NEEDS: Equality method and serialisation are needed for serialising a struct which contains a vector of poly_triple * Light formatting * remove added newline * change to default * diff nit --------- Co-authored-by: kevaundray <kevtheappdev@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Noir needs to be able to serialize and deserialize the poly_triple struct. It also needs to be able to check equality of these.
Checklist:
/markdown/specshave been updated.@briefdescribing the intended functionality.