fix: Check for wasm-opt during configure & run on post_build#175
Merged
Conversation
dbanks12
reviewed
Feb 22, 2023
|
Left a comment. Otherwise looks good to me. This is good cleanup. |
ludamad
pushed a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Jul 22, 2023
ludamad
pushed a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Jul 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR makes the wasm-opt dependency more explicit. It is now referenced as a dependency since the wasm build fails without it. I've also added a
find_programcall to ensure it is installed during the configure phase for a wasm build; otherwise you'd get to the very end and it would crash.I've changed the executable target to be
barretenberg.wasmand then used theTARGETvariant ofadd_custom_commandso the wasm-opt command isn't run ifbarretenberg.wasmis already built. The previous way of doing this created a target that was always stale.This should enable adding the wasm binary as an installation target, which is not possible with custom targets.
Checklist:
/markdown/specshave been updated.@briefdescribing the intended functionality.