Skip to content

fix: Ensure barretenberg provides headers that Noir needs#200

Merged
kevaundray merged 4 commits into
masterfrom
phated/c-bind-headers
Mar 8, 2023
Merged

fix: Ensure barretenberg provides headers that Noir needs#200
kevaundray merged 4 commits into
masterfrom
phated/c-bind-headers

Conversation

@phated

@phated phated commented Mar 6, 2023

Copy link
Copy Markdown

Description

This adds headers for the c_binds files that Noir binds to. It also exposes pedersen__commit which is something we converted to a public function on Pedersen, and changes the new_pippenger "points" argument to a uint8_t type so it is easier to bind to.

Checklist:

  • I have reviewed my diff in github, line by line.
  • Every change is related to the PR description.
  • I have linked this pull request to the issue(s) that it resolves.
  • There are no unexpected formatting changes, superfluous debug logs, or commented-out code.
  • There are no circuit changes, OR specifications in /markdown/specs have been updated.
  • There are no circuit changes, OR a cryptographer has been assigned for review.
  • I've updated any terraform that needs updating (e.g. environment variables) for deployment.
  • The branch has been rebased against the head of its merge target.
  • I'm happy for the PR to be merged at the reviewer's next convenience.
  • New functions, classes, etc. have been documented according to the doxygen comment format. Classes and structs must have @brief describing the intended functionality.
  • If existing code has been modified, such documentation has been added or updated.

@phated phated requested review from codygunton and dbanks12 March 6, 2023 16:18
@codygunton codygunton requested review from ledwards2225 and removed request for codygunton March 7, 2023 14:44
Comment thread cpp/src/aztec/crypto/schnorr/c_bind.hpp

@ledwards2225 ledwards2225 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me. Can't speak to why these were removed originally. None of these c_binds are used by the Honk team (including, for future ref, the multisig_* functions).

@kevaundray kevaundray merged commit 0171a49 into master Mar 8, 2023
@kevaundray kevaundray deleted the phated/c-bind-headers branch March 8, 2023 14:41
ludamad pushed a commit to AztecProtocol/aztec-packages that referenced this pull request Jul 22, 2023
ludamad pushed a commit to AztecProtocol/aztec-packages that referenced this pull request Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants