fix: Ensure barretenberg provides headers that Noir needs#200
Merged
Conversation
kevaundray
reviewed
Mar 7, 2023
ledwards2225
approved these changes
Mar 8, 2023
ledwards2225
left a comment
Collaborator
There was a problem hiding this comment.
Looks fine to me. Can't speak to why these were removed originally. None of these c_binds are used by the Honk team (including, for future ref, the multisig_* functions).
ludamad
pushed a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Jul 22, 2023
ludamad
pushed a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Jul 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This adds headers for the
c_bindsfiles that Noir binds to. It also exposespedersen__commitwhich is something we converted to a public function on Pedersen, and changes thenew_pippenger"points" argument to auint8_ttype so it is easier to bind to.Checklist:
/markdown/specshave been updated.@briefdescribing the intended functionality.